OpenJDK / jdk / hs
changeset 29696:01571dfab5be
8073944: Simplify ArgumentsExt and remove unneeded functionallity
Reviewed-by: kbarrett, dholmes
author | sjohanss |
---|---|
date | Mon, 02 Mar 2015 11:08:09 +0100 |
parents | 7f733c2a8db4 |
children | 92501504191b |
files | hotspot/src/share/vm/runtime/arguments.cpp hotspot/src/share/vm/runtime/arguments.hpp hotspot/src/share/vm/runtime/arguments_ext.hpp |
diffstat | 3 files changed, 5 insertions(+), 20 deletions(-) [+] |
line wrap: on
line diff
--- a/hotspot/src/share/vm/runtime/arguments.cpp Mon Mar 23 12:18:20 2015 +0100 +++ b/hotspot/src/share/vm/runtime/arguments.cpp Mon Mar 02 11:08:09 2015 +0100 @@ -1612,7 +1612,7 @@ void Arguments::select_gc() { if (!gc_selected()) { - ArgumentsExt::select_gc_ergonomically(); + select_gc_ergonomically(); } } @@ -2121,7 +2121,7 @@ } // Check consistency of GC selection -bool Arguments::check_gc_consistency_user() { +bool Arguments::check_gc_consistency() { check_gclog_consistency(); // Ensure that the user has not selected conflicting sets // of collectors. @@ -2265,7 +2265,7 @@ FLAG_SET_DEFAULT(UseGCOverheadLimit, false); } - status = status && check_gc_consistency_user(); + status = status && check_gc_consistency(); status = status && check_stack_pages(); status = status && verify_percentage(CMSIncrementalSafetyFactor, @@ -3900,7 +3900,7 @@ set_shared_spaces_flags(); // Check the GC selections again. - if (!ArgumentsExt::check_gc_consistency_ergo()) { + if (!check_gc_consistency()) { return JNI_EINVAL; }
--- a/hotspot/src/share/vm/runtime/arguments.hpp Mon Mar 23 12:18:20 2015 +0100 +++ b/hotspot/src/share/vm/runtime/arguments.hpp Mon Mar 02 11:08:09 2015 +0100 @@ -477,8 +477,7 @@ static bool verify_MaxHeapFreeRatio(FormatBuffer<80>& err_msg, uintx max_heap_free_ratio); // Check for consistency in the selection of the garbage collector. - static bool check_gc_consistency_user(); // Check user-selected gc - static inline bool check_gc_consistency_ergo(); // Check ergonomic-selected gc + static bool check_gc_consistency(); // Check user-selected gc static void check_deprecated_gc_flags(); // Check consistency or otherwise of VM argument settings static bool check_vm_args_consistency(); @@ -618,10 +617,6 @@ return UseConcMarkSweepGC || UseG1GC || UseParallelGC || UseParallelOldGC || UseSerialGC; } -bool Arguments::check_gc_consistency_ergo() { - return check_gc_consistency_user(); -} - // Disable options not supported in this release, with a warning if they // were explicitly requested on the command-line #define UNSUPPORTED_OPTION(opt, description) \
--- a/hotspot/src/share/vm/runtime/arguments_ext.hpp Mon Mar 23 12:18:20 2015 +0100 +++ b/hotspot/src/share/vm/runtime/arguments_ext.hpp Mon Mar 02 11:08:09 2015 +0100 @@ -30,9 +30,7 @@ class ArgumentsExt: AllStatic { public: - static inline void select_gc_ergonomically(); static inline void set_gc_specific_flags(); - static inline bool check_gc_consistency_ergo(); // The argument processing extension. Returns true if there is // no additional parsing needed in Arguments::parse() for the option. // Otherwise returns false. @@ -40,16 +38,8 @@ static inline void report_unsupported_options() { } }; -void ArgumentsExt::select_gc_ergonomically() { - Arguments::select_gc_ergonomically(); -} - void ArgumentsExt::set_gc_specific_flags() { Arguments::set_gc_specific_flags(); } -bool ArgumentsExt::check_gc_consistency_ergo() { - return Arguments::check_gc_consistency_ergo(); -} - #endif // SHARE_VM_RUNTIME_ARGUMENTS_EXT_HPP