OpenJDK / jdk / jdk
changeset 58042:cf6409153216
8238811: C2: assert(i >= req() || i == 0 || is_Region() || is_Phi()) with -XX:+VerifyGraphEdges
Summary: Fix -XX:+VerifyGraphEdges by additionally handling ArrayCopyNodes and UnlockNodes and add some basic flag testing.
Reviewed-by: roland, neliasso
author | chagedorn |
---|---|
date | Thu, 13 Feb 2020 15:08:08 +0100 |
parents | cd78b249e6a4 |
children | b7f4baa47fe2 |
files | src/hotspot/share/opto/node.cpp test/hotspot/jtreg/compiler/c2/TestVerifyGraphEdges.java |
diffstat | 2 files changed, 39 insertions(+), 4 deletions(-) [+] |
line wrap: on
line diff
--- a/src/hotspot/share/opto/node.cpp Thu Feb 13 15:07:45 2020 +0100 +++ b/src/hotspot/share/opto/node.cpp Thu Feb 13 15:08:08 2020 +0100 @@ -2123,7 +2123,8 @@ } assert( cnt == 0,"Mismatched edge count."); } else if (n == NULL) { - assert(i >= req() || i == 0 || is_Region() || is_Phi(), "only regions or phis have null data edges"); + assert(i >= req() || i == 0 || is_Region() || is_Phi() || is_ArrayCopy() + || (is_Unlock() && i == req()-1), "only region, phi, arraycopy or unlock nodes have null data edges"); } else { assert(n->is_top(), "sanity"); // Nothing to check. @@ -2137,9 +2138,6 @@ } } -//------------------------------verify_recur----------------------------------- -static const Node *unique_top = NULL; - void Node::verify_recur(const Node *n, int verify_depth, VectorSet &old_space, VectorSet &new_space) { if ( verify_depth == 0 ) return;
--- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/hotspot/jtreg/compiler/c2/TestVerifyGraphEdges.java Thu Feb 13 15:08:08 2020 +0100 @@ -0,0 +1,37 @@ +/* + * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8238811 + * @requires vm.debug == true & vm.flavor == "server" + * @summary Run with -Xcomp to test -XX:+VerifyGraphEdges in debug builds. + * + * @run main/othervm -Xbatch -Xcomp -XX:+VerifyGraphEdges compiler.c2.TestVerifyGraphEdges + */ +package compiler.c2; + +public class TestVerifyGraphEdges { + public static void main(String[] args) { + } +}