OpenJDK / jdk / jdk10
changeset 36581:8d65a7db1582
6787054: Par compact - remove code that clears source_region
Reviewed-by: mgerdin, tschatzl
author | jwilhelm |
---|---|
date | Mon, 29 Feb 2016 15:47:41 +0100 |
parents | c3090eae87e6 |
children | ad9ee98daf2c |
files | hotspot/src/share/vm/gc/parallel/psParallelCompact.cpp hotspot/src/share/vm/gc/parallel/psParallelCompact.hpp hotspot/src/share/vm/utilities/globalDefinitions.hpp |
diffstat | 3 files changed, 5 insertions(+), 19 deletions(-) [+] |
line wrap: on
line diff
--- a/hotspot/src/share/vm/gc/parallel/psParallelCompact.cpp Mon Mar 07 15:07:58 2016 +0100 +++ b/hotspot/src/share/vm/gc/parallel/psParallelCompact.cpp Mon Feb 29 15:47:41 2016 +0100 @@ -1484,17 +1484,6 @@ } void -PSParallelCompact::clear_source_region(HeapWord* beg_addr, HeapWord* end_addr) -{ - RegionData* const beg_ptr = _summary_data.addr_to_region_ptr(beg_addr); - HeapWord* const end_aligned_up = _summary_data.region_align_up(end_addr); - RegionData* const end_ptr = _summary_data.addr_to_region_ptr(end_aligned_up); - for (RegionData* cur = beg_ptr; cur < end_ptr; ++cur) { - cur->set_source_region(0); - } -} - -void PSParallelCompact::summarize_space(SpaceId id, bool maximum_compaction) { assert(id < last_space_id, "id out of range");
--- a/hotspot/src/share/vm/gc/parallel/psParallelCompact.hpp Mon Mar 07 15:07:58 2016 +0100 +++ b/hotspot/src/share/vm/gc/parallel/psParallelCompact.hpp Mon Feb 29 15:47:41 2016 +0100 @@ -1065,9 +1065,6 @@ // non-empty. static void fill_dense_prefix_end(SpaceId id); - // Clear the summary data source_region field for the specified addresses. - static void clear_source_region(HeapWord* beg_addr, HeapWord* end_addr); - static void summarize_spaces_quick(); static void summarize_space(SpaceId id, bool maximum_compaction); static void summary_phase(ParCompactionManager* cm, bool maximum_compaction);
--- a/hotspot/src/share/vm/utilities/globalDefinitions.hpp Mon Mar 07 15:07:58 2016 +0100 +++ b/hotspot/src/share/vm/utilities/globalDefinitions.hpp Mon Feb 29 15:47:41 2016 +0100 @@ -313,7 +313,7 @@ // ANSI C++ does not allow casting from one pointer type to a function pointer // directly without at best a warning. This macro accomplishes it silently // In every case that is present at this point the value be cast is a pointer -// to a C linkage function. In somecase the type used for the cast reflects +// to a C linkage function. In some case the type used for the cast reflects // that linkage and a picky compiler would not complain. In other cases because // there is no convenient place to place a typedef with extern C linkage (i.e // a platform dependent header file) it doesn't. At this point no compiler seems @@ -678,7 +678,7 @@ inline const char* type2name(BasicType t) { return (uint)t < T_CONFLICT+1 ? type2name_tab[t] : NULL; } extern BasicType name2type(const char* name); -// Auxilary math routines +// Auxiliary math routines // least common multiple extern size_t lcm(size_t a, size_t b); @@ -801,7 +801,7 @@ // TosState describes the top-of-stack state before and after the execution of // a bytecode or method. The top-of-stack value may be cached in one or more CPU -// registers. The TosState corresponds to the 'machine represention' of this cached +// registers. The TosState corresponds to the 'machine representation' of this cached // value. There's 4 states corresponding to the JAVA types int, long, float & double // as well as a 5th state in case the top-of-stack value is actually on the top // of stack (in memory) and thus not cached. The atos state corresponds to the itos @@ -876,7 +876,7 @@ // a transition from one state to another. These extra states makes it possible for the safepoint code to // handle certain thread_states without having to suspend the thread - making the safepoint code faster. // -// Given a state, the xxx_trans state can always be found by adding 1. +// Given a state, the xxxx_trans state can always be found by adding 1. // enum JavaThreadState { _thread_uninitialized = 0, // should never happen (missing initialization) @@ -1425,7 +1425,7 @@ // operations. // The goal of this code to avoid undefined or implementation-defined -// behaviour. The use of an lvalue to reference cast is explicitly +// behavior. The use of an lvalue to reference cast is explicitly // permitted by Lvalues and rvalues [basic.lval]. [Section 3.10 Para // 15 in C++03] #define JAVA_INTEGER_OP(OP, NAME, TYPE, UNSIGNED_TYPE) \