changeset 5870:83923cc50252 it2-bootstrap

Minor tweaks
author briangoetz
date Mon, 27 Aug 2012 18:47:18 -0400
parents e45e67f1f21f
children ef17a5d81036
files src/share/classes/java/util/Sized.java src/share/classes/java/util/StringJoiner.java
diffstat 2 files changed, 6 insertions(+), 11 deletions(-) [+]
line wrap: on
line diff
--- a/src/share/classes/java/util/Sized.java	Mon Aug 27 17:31:45 2012 -0400
+++ b/src/share/classes/java/util/Sized.java	Mon Aug 27 18:47:18 2012 -0400
@@ -45,5 +45,5 @@
      *
      * @return  {@code true} if the size is zero otherwise {@code false}.
      */
-    public boolean isEmpty() default { return size() != 0; }
+    public boolean isEmpty() default { return size() == 0; }
 }
--- a/src/share/classes/java/util/StringJoiner.java	Mon Aug 27 17:31:45 2012 -0400
+++ b/src/share/classes/java/util/StringJoiner.java	Mon Aug 27 18:47:18 2012 -0400
@@ -201,10 +201,8 @@
      * @param newElement
      * @return this StringJoiner
      */
-    private boolean add(CharSequence newElement) {
-        CharSequence element = (newElement == null ? nullOutput : newElement);
-        prepareBuilder().append(element);
-        return true;
+    private void add(CharSequence newElement) {
+        prepareBuilder().append((newElement == null ? nullOutput : newElement));
     }
 
     @Override
@@ -221,9 +219,8 @@
      * @param newElements
      * @return this StringJoiner
      */
-    public StringJoiner add(CharSequence... newElements) {
+    public void add(CharSequence... newElements) {
         addAll(newElements == null ? null : Arrays.asList(newElements));
-        return this;
     }
 
     /**
@@ -233,10 +230,8 @@
      * @param newElement
      * @return this StringJoiner
      */
-    public StringJoiner add(char[] newElement) {
-        char[] element = (newElement == null ? nullOutputChars : newElement);
-        prepareBuilder().append(element);
-        return this;
+    public void add(char[] newElement) {
+        prepareBuilder().append((newElement == null ? nullOutputChars : newElement));
     }
 
     private StringBuilder prepareBuilder() {