OpenJDK / portola / portola
changeset 47574:15294343ba19
8187979: Clean up info printing at CDS dump time
Reviewed-by: jiangli, ccheung
author | iklam |
---|---|
date | Mon, 02 Oct 2017 16:00:42 -0700 |
parents | 552a97e8edad |
children | c0c98a4c290b |
files | src/hotspot/share/memory/allocation.hpp src/hotspot/share/memory/metaspaceShared.cpp test/hotspot/jtreg/runtime/SharedArchiveFile/SpaceUtilizationCheck.java test/hotspot/jtreg/runtime/modules/PatchModule/PatchModuleCDS.java |
diffstat | 4 files changed, 7 insertions(+), 8 deletions(-) [+] |
line wrap: on
line diff
--- a/src/hotspot/share/memory/allocation.hpp Mon Oct 02 18:56:30 2017 -0400 +++ b/src/hotspot/share/memory/allocation.hpp Mon Oct 02 16:00:42 2017 -0700 @@ -233,7 +233,6 @@ void print_address_on(outputStream* st) const; // nonvirtual address printing #define METASPACE_OBJ_TYPES_DO(f) \ - f(Unknown) \ f(Class) \ f(Symbol) \ f(TypeArrayU1) \
--- a/src/hotspot/share/memory/metaspaceShared.cpp Mon Oct 02 18:56:30 2017 -0400 +++ b/src/hotspot/share/memory/metaspaceShared.cpp Mon Oct 02 16:00:42 2017 -0700 @@ -165,7 +165,7 @@ } void print(size_t total_bytes) const { - tty->print_cr("%s space: " SIZE_FORMAT_W(9) " [ %4.1f%% of total] out of " SIZE_FORMAT_W(9) " bytes [%5.1f%% used] at " INTPTR_FORMAT, + tty->print_cr("%-3s space: " SIZE_FORMAT_W(9) " [ %4.1f%% of total] out of " SIZE_FORMAT_W(9) " bytes [%5.1f%% used] at " INTPTR_FORMAT, _name, used(), perc(used(), total_bytes), reserved(), perc(used(), reserved()), p2i(_base)); } void print_out_of_space_msg(const char* failing_region, size_t needed_bytes) { @@ -1405,7 +1405,7 @@ print_heap_region_stats(_string_regions, "st", total_reserved); print_heap_region_stats(_open_archive_heap_regions, "oa", total_reserved); - tty->print_cr("total : " SIZE_FORMAT_W(9) " [100.0%% of total] out of " SIZE_FORMAT_W(9) " bytes [%5.1f%% used]", + tty->print_cr("total : " SIZE_FORMAT_W(9) " [100.0%% of total] out of " SIZE_FORMAT_W(9) " bytes [%5.1f%% used]", total_bytes, total_reserved, total_u_perc); } @@ -1416,7 +1416,7 @@ char* start = (char*)heap_mem->at(i).start(); size_t size = heap_mem->at(i).byte_size(); char* top = start + size; - tty->print_cr("%s%d space: " SIZE_FORMAT_W(9) " [ %4.1f%% of total] out of " SIZE_FORMAT_W(9) " bytes [100%% used] at " INTPTR_FORMAT, + tty->print_cr("%s%d space: " SIZE_FORMAT_W(9) " [ %4.1f%% of total] out of " SIZE_FORMAT_W(9) " bytes [100.0%% used] at " INTPTR_FORMAT, name, i, size, size/double(total_size)*100.0, size, p2i(start)); }
--- a/test/hotspot/jtreg/runtime/SharedArchiveFile/SpaceUtilizationCheck.java Mon Oct 02 18:56:30 2017 -0400 +++ b/test/hotspot/jtreg/runtime/SharedArchiveFile/SpaceUtilizationCheck.java Mon Oct 02 16:00:42 2017 -0700 @@ -64,7 +64,7 @@ static void test(String... extra_options) throws Exception { OutputAnalyzer output = CDSTestUtils.createArchive(extra_options); CDSTestUtils.checkDump(output); - Pattern pattern = Pattern.compile("^(..) space: *([0-9]+).* out of *([0-9]+) bytes .* at 0x([0-9a0-f]+)"); + Pattern pattern = Pattern.compile("^(..) *space: *([0-9]+).* out of *([0-9]+) bytes .* at 0x([0-9a0-f]+)"); WhiteBox wb = WhiteBox.getWhiteBox(); long reserve_alignment = wb.metaspaceReserveAlignment(); System.out.println("Metaspace::reserve_alignment() = " + reserve_alignment);
--- a/test/hotspot/jtreg/runtime/modules/PatchModule/PatchModuleCDS.java Mon Oct 02 18:56:30 2017 -0400 +++ b/test/hotspot/jtreg/runtime/modules/PatchModule/PatchModuleCDS.java Mon Oct 02 16:00:42 2017 -0700 @@ -50,7 +50,7 @@ "-Xlog:class+path=info", "-version"); new OutputAnalyzer(pb.start()) - .shouldContain("ro space:"); // Make sure archive got created. + .shouldContain("ro space:"); // Make sure archive got created. // Case 2: Test that directory in --patch-module is supported for CDS dumping // Create a class file in the module java.base. @@ -73,7 +73,7 @@ "-Xlog:class+path=info", "-version"); new OutputAnalyzer(pb.start()) - .shouldContain("ro space:"); // Make sure archive got created. + .shouldContain("ro space:"); // Make sure archive got created. // Case 3a: Test CDS dumping with jar file in --patch-module BasicJarBuilder.build("javanaming", "javax/naming/spi/NamingManager"); @@ -87,7 +87,7 @@ "-Xlog:class+path=info", "PatchModuleMain", "javax.naming.spi.NamingManager"); new OutputAnalyzer(pb.start()) - .shouldContain("ro space:"); // Make sure archive got created. + .shouldContain("ro space:"); // Make sure archive got created. // Case 3b: Test CDS run with jar file in --patch-module pb = ProcessTools.createJavaProcessBuilder(