OpenJDK / portola / portola
changeset 7986:350f0f3c453b
7003398: NetworkInterface equals() and hashCode() behaviors depend on permissions granted
Reviewed-by: chegar, alanb
author | michaelm |
---|---|
date | Thu, 13 Jan 2011 16:33:07 +0000 |
parents | f106fb65db31 |
children | 04c9822b55c9 |
files | jdk/src/share/classes/java/net/NetworkInterface.java jdk/test/java/net/NetworkInterface/Equals.java |
diffstat | 2 files changed, 94 insertions(+), 45 deletions(-) [+] |
line wrap: on
line diff
--- a/jdk/src/share/classes/java/net/NetworkInterface.java Thu Jan 13 14:41:53 2011 +0000 +++ b/jdk/src/share/classes/java/net/NetworkInterface.java Thu Jan 13 16:33:07 2011 +0000 @@ -493,55 +493,44 @@ * @see java.net.InetAddress#getAddress() */ public boolean equals(Object obj) { - if ((obj == null) || !(obj instanceof NetworkInterface)) { + if (!(obj instanceof NetworkInterface)) { return false; } - NetworkInterface netIF = (NetworkInterface)obj; - if (name != null ) { - if (netIF.getName() != null) { - if (!name.equals(netIF.getName())) { - return false; - } - } else { - return false; - } - } else { - if (netIF.getName() != null) { - return false; - } - } - Enumeration newAddrs = netIF.getInetAddresses(); - int i = 0; - for (i = 0; newAddrs.hasMoreElements();newAddrs.nextElement(), i++); - if (addrs == null) { - if (i != 0) { + NetworkInterface that = (NetworkInterface)obj; + if (this.name != null ) { + if (!this.name.equals(that.name)) { return false; } } else { - /* - * Compare number of addresses (in the checked subset) - */ - int count = 0; - Enumeration e = getInetAddresses(); - for (; e.hasMoreElements(); count++) { - e.nextElement(); - } - if (i != count) { + if (that.name != null) { return false; } } - newAddrs = netIF.getInetAddresses(); - for (; newAddrs.hasMoreElements();) { - boolean equal = false; - Enumeration thisAddrs = getInetAddresses(); - InetAddress newAddr = (InetAddress)newAddrs.nextElement(); - for (; thisAddrs.hasMoreElements();) { - InetAddress thisAddr = (InetAddress)thisAddrs.nextElement(); - if (thisAddr.equals(newAddr)) { - equal = true; + + if (this.addrs == null) { + return that.addrs == null; + } else if (that.addrs == null) { + return false; + } + + /* Both addrs not null. Compare number of addresses */ + + if (this.addrs.length != that.addrs.length) { + return false; + } + + InetAddress[] thatAddrs = that.addrs; + int count = thatAddrs.length; + + for (int i=0; i<count; i++) { + boolean found = false; + for (int j=0; j<count; j++) { + if (addrs[i].equals(thatAddrs[j])) { + found = true; + break; } } - if (!equal) { + if (!found) { return false; } } @@ -549,12 +538,7 @@ } public int hashCode() { - int count = name == null? 0: name.hashCode(); - Enumeration<InetAddress> addrs = getInetAddresses(); - while (addrs.hasMoreElements()) { - count += addrs.nextElement().hashCode(); - } - return count; + return name == null? 0: name.hashCode(); } public String toString() {
--- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/jdk/test/java/net/NetworkInterface/Equals.java Thu Jan 13 16:33:07 2011 +0000 @@ -0,0 +1,65 @@ +/* + * Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* @test + * @bug 7003398 + * @run main/othervm Equals + */ +import java.net.NetworkInterface; +import java.net.InetAddress; +import java.util.Enumeration; +import java.util.HashMap; + +public class Equals { + + public static void main(String args[]) throws Exception { + + Enumeration nifs1 = NetworkInterface.getNetworkInterfaces(); + HashMap<String,Integer> hashes = new HashMap<>(); + HashMap<String,NetworkInterface> nicMap = new HashMap<>(); + + while (nifs1.hasMoreElements()) { + NetworkInterface ni = (NetworkInterface)nifs1.nextElement(); + hashes.put(ni.getName(),ni.hashCode()); + nicMap.put(ni.getName(),ni); + } + + System.setSecurityManager(new SecurityManager()); + + Enumeration nifs2 = NetworkInterface.getNetworkInterfaces(); + while (nifs2.hasMoreElements()) { + NetworkInterface ni = (NetworkInterface)nifs2.nextElement(); + NetworkInterface niOrig = nicMap.get(ni.getName()); + + int h = hashes.get(ni.getName()); + if (h != ni.hashCode()) { + throw new RuntimeException ("Hashcodes different for " + + ni.getName()); + } + if (!ni.equals(niOrig)) { + throw new RuntimeException ("equality different for " + + ni.getName()); + } + } + } +}