OpenJDK / valhalla / valhalla
changeset 57249:483f14c3e0a2
Merge
| author | psadhukhan |
|---|---|
| date | Wed, 25 Sep 2019 13:40:36 +0530 |
| parents | fe46ee1d42ee 88fce7eea1f6 |
| children | de8e08015d51 |
| files | src/hotspot/os/linux/gc/z/zVirtualMemory_linux.cpp src/java.desktop/share/classes/java/awt/Window.java src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/inlining/PolymorphicInliningTest.java src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotClassInitializationPlugin.java src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/NormalizeCompareNode.java src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.test/src/org/graalvm/compiler/test/JLModule.java src/jdk.jcmd/linux/classes/sun/tools/ProcessHelper.java |
| diffstat | 971 files changed, 12808 insertions(+), 9029 deletions(-) [+] |
line wrap: on
line diff
--- a/doc/testing.html Mon Sep 23 17:18:03 2019 +0100 +++ b/doc/testing.html Wed Sep 25 13:40:36 2019 +0530 @@ -5,7 +5,7 @@ <meta name="generator" content="pandoc" /> <meta name="viewport" content="width=device-width, initial-scale=1.0, user-scalable=yes" /> <title>Testing the JDK</title> - <style type="text/css"> + <style> code{white-space: pre-wrap;} span.smallcaps{font-variant: small-caps;} span.underline{text-decoration: underline;} @@ -21,9 +21,9 @@ <header id="title-block-header"> <h1 class="title">Testing the JDK</h1> </header> -<nav id="TOC"> +<nav id="TOC" role="doc-toc"> <ul> -<li><a href="#using-make-test-the-run-test-framework">Using "make test" (the run-test framework)</a><ul> +<li><a href="#using-make-test-the-run-test-framework">Using "make test" (the run-test framework)</a><ul> <li><a href="#configuration">Configuration</a></li> </ul></li> <li><a href="#test-selection">Test selection</a><ul> @@ -42,10 +42,11 @@ <li><a href="#notes-for-specific-tests">Notes for Specific Tests</a><ul> <li><a href="#docker-tests">Docker Tests</a></li> <li><a href="#non-us-locale">Non-US locale</a></li> +<li><a href="#pkcs11-tests">PKCS11 Tests</a></li> </ul></li> </ul> </nav> -<h2 id="using-make-test-the-run-test-framework">Using "make test" (the run-test framework)</h2> +<h2 id="using-make-test-the-run-test-framework">Using "make test" (the run-test framework)</h2> <p>This new way of running tests is developer-centric. It assumes that you have built a JDK locally and want to test it. Running common test targets is simple, and more complex ad-hoc combination of tests is possible. The user interface is forgiving, and clearly report errors it cannot resolve.</p> <p>The main target <code>test</code> uses the jdk-image as the tested product. There is also an alternate target <code>exploded-test</code> that uses the exploded image instead. Not all tests will run successfully on the exploded image, but using this target can greatly improve rebuild times for certain workflows.</p> <p>Previously, <code>make test</code> was used to invoke an old system for running tests, and <code>make run-test</code> was used for the new test framework. For backward compatibility with scripts and muscle memory, <code>run-test</code> (and variants like <code>exploded-run-test</code> or <code>run-test-tier1</code>) are kept as aliases.</p> @@ -63,7 +64,7 @@ <p>To be able to run microbenchmarks, <code>configure</code> needs to know where to find the JMH dependency. Use <code>--with-jmh=<path to JMH jars></code> to point to a directory containing the core JMH and transitive dependencies. The recommended dependencies can be retrieved by running <code>sh make/devkit/createJMHBundle.sh</code>, after which <code>--with-jmh=build/jmh/jars</code> should work.</p> <h2 id="test-selection">Test selection</h2> <p>All functionality is available using the <code>test</code> make target. In this use case, the test or tests to be executed is controlled using the <code>TEST</code> variable. To speed up subsequent test runs with no source code changes, <code>test-only</code> can be used instead, which do not depend on the source and test image build.</p> -<p>For some common top-level tests, direct make targets have been generated. This includes all JTReg test groups, the hotspot gtest, and custom tests (if present). This means that <code>make test-tier1</code> is equivalent to <code>make test TEST="tier1"</code>, but the latter is more tab-completion friendly. For more complex test runs, the <code>test TEST="x"</code> solution needs to be used.</p> +<p>For some common top-level tests, direct make targets have been generated. This includes all JTReg test groups, the hotspot gtest, and custom tests (if present). This means that <code>make test-tier1</code> is equivalent to <code>make test TEST="tier1"</code>, but the latter is more tab-completion friendly. For more complex test runs, the <code>test TEST="x"</code> solution needs to be used.</p> <p>The test specifications given in <code>TEST</code> is parsed into fully qualified test descriptors, which clearly and unambigously show which tests will be run. As an example, <code>:tier1</code> will expand to <code>jtreg:$(TOPDIR)/test/hotspot/jtreg:tier1 jtreg:$(TOPDIR)/test/jdk:tier1 jtreg:$(TOPDIR)/test/langtools:tier1 jtreg:$(TOPDIR)/test/nashorn:tier1 jtreg:$(TOPDIR)/test/jaxp:tier1</code>. You can always submit a list of fully qualified test descriptors in the <code>TEST</code> variable if you want to shortcut the parser.</p> <h3 id="jtreg">JTReg</h3> <p>JTReg tests can be selected either by picking a JTReg test group, or a selection of files or directories containing JTReg tests.</p> @@ -103,8 +104,8 @@ <p>Additional work data is stored in <code>build/$BUILD/test-support/$TEST_ID</code>. For some frameworks, this directory might contain information that is useful in determining the cause of a failed test.</p> <h2 id="test-suite-control">Test suite control</h2> <p>It is possible to control various aspects of the test suites using make control variables.</p> -<p>These variables use a keyword=value approach to allow multiple values to be set. So, for instance, <code>JTREG="JOBS=1;TIMEOUT_FACTOR=8"</code> will set the JTReg concurrency level to 1 and the timeout factor to 8. This is equivalent to setting <code>JTREG_JOBS=1 JTREG_TIMEOUT_FACTOR=8</code>, but using the keyword format means that the <code>JTREG</code> variable is parsed and verified for correctness, so <code>JTREG="TMIEOUT_FACTOR=8"</code> would give an error, while <code>JTREG_TMIEOUT_FACTOR=8</code> would just pass unnoticed.</p> -<p>To separate multiple keyword=value pairs, use <code>;</code> (semicolon). Since the shell normally eats <code>;</code>, the recommended usage is to write the assignment inside qoutes, e.g. <code>JTREG="...;..."</code>. This will also make sure spaces are preserved, as in <code>JTREG="VM_OPTIONS=-XshowSettings -Xlog:gc+ref=debug"</code>.</p> +<p>These variables use a keyword=value approach to allow multiple values to be set. So, for instance, <code>JTREG="JOBS=1;TIMEOUT_FACTOR=8"</code> will set the JTReg concurrency level to 1 and the timeout factor to 8. This is equivalent to setting <code>JTREG_JOBS=1 JTREG_TIMEOUT_FACTOR=8</code>, but using the keyword format means that the <code>JTREG</code> variable is parsed and verified for correctness, so <code>JTREG="TMIEOUT_FACTOR=8"</code> would give an error, while <code>JTREG_TMIEOUT_FACTOR=8</code> would just pass unnoticed.</p> +<p>To separate multiple keyword=value pairs, use <code>;</code> (semicolon). Since the shell normally eats <code>;</code>, the recommended usage is to write the assignment inside qoutes, e.g. <code>JTREG="...;..."</code>. This will also make sure spaces are preserved, as in <code>JTREG="VM_OPTIONS=-XshowSettings -Xlog:gc+ref=debug"</code>.</p> <p>(Other ways are possible, e.g. using backslash: <code>JTREG=JOBS=1\;TIMEOUT_FACTOR=8</code>. Also, as a special technique, the string <code>%20</code> will be replaced with space for certain options, e.g. <code>JTREG=VM_OPTIONS=-XshowSettings%20-Xlog:gc+ref=debug</code>. This can be useful if you have layers of scripts and have trouble getting proper quoting of command line arguments through.)</p> <p>As far as possible, the names of the keywords have been standardized between test suites.</p> <h3 id="general-keywords-test_opts">General keywords (TEST_OPTS)</h3> @@ -159,7 +160,7 @@ <p>Set to <code>true</code> or <code>false</code>. If <code>true</code>, JTReg will use <code>-match:</code> option, otherwise <code>-exclude:</code> will be used. Default is <code>false</code>.</p> <h4 id="options">OPTIONS</h4> <p>Additional options to the JTReg test framework.</p> -<p>Use <code>JTREG="OPTIONS=--help all"</code> to see all available JTReg options.</p> +<p>Use <code>JTREG="OPTIONS=--help all"</code> to see all available JTReg options.</p> <h4 id="java_options-1">JAVA_OPTIONS</h4> <p>Additional Java options to JTReg (<code>-javaoption</code>).</p> <h4 id="vm_options-1">VM_OPTIONS</h4> @@ -172,7 +173,7 @@ <p>Default is 1. Set to -1 to repeat indefinitely. This can be especially useful combined with <code>OPTIONS=--gtest_break_on_failure</code> to reproduce an intermittent problem.</p> <h4 id="options-1">OPTIONS</h4> <p>Additional options to the Gtest test framework.</p> -<p>Use <code>GTEST="OPTIONS=--help"</code> to see all available Gtest options.</p> +<p>Use <code>GTEST="OPTIONS=--help"</code> to see all available Gtest options.</p> <h4 id="aot_modules-2">AOT_MODULES</h4> <p>Generate AOT modules before testing for the specified module, or set of modules. If multiple modules are specified, they should be separated by space (or, to help avoid quoting issues, the special value <code>%20</code>).</p> <h3 id="microbenchmark-keywords">Microbenchmark keywords</h3> @@ -199,8 +200,12 @@ <p>To run these tests correctly, additional parameters for the correct docker image are required on Ubuntu 18.04 by using <code>JAVA_OPTIONS</code>.</p> <pre><code>$ make test TEST="jtreg:test/hotspot/jtreg/containers/docker" JTREG="JAVA_OPTIONS=-Djdk.test.docker.image.name=ubuntu -Djdk.test.docker.image.version=latest"</code></pre> <h3 id="non-us-locale">Non-US locale</h3> -<p>If your locale is non-US, some tests are likely to fail. To work around this you can set the locale to US. On Unix platforms simply setting <code>LANG="en_US"</code> in the environment before running tests should work. On Windows, setting <code>JTREG="VM_OPTIONS=-Duser.language=en -Duser.country=US"</code> helps for most, but not all test cases. For example:</p> +<p>If your locale is non-US, some tests are likely to fail. To work around this you can set the locale to US. On Unix platforms simply setting <code>LANG="en_US"</code> in the environment before running tests should work. On Windows, setting <code>JTREG="VM_OPTIONS=-Duser.language=en -Duser.country=US"</code> helps for most, but not all test cases. For example:</p> <pre><code>$ export LANG="en_US" && make test TEST=... $ make test JTREG="VM_OPTIONS=-Duser.language=en -Duser.country=US" TEST=...</code></pre> +<h3 id="pkcs11-tests">PKCS11 Tests</h3> +<p>It is highly recommended to use the latest NSS version when running PKCS11 tests. Improper NSS version may lead to unexpected failures which are hard to diagnose. For example, sun/security/pkcs11/Secmod/AddTrustedCert.java may fail on Ubuntu 18.04 with the default NSS version in the system. To run these tests correctly, the system property <code>test.nss.lib.paths</code> is required on Ubuntu 18.04 to specify the alternative NSS lib directories. For example:</p> +<pre><code>$ make test TEST="jtreg:sun/security/pkcs11/Secmod/AddTrustedCert.java" JTREG="JAVA_OPTIONS=-Dtest.nss.lib.paths=/path/to/your/latest/NSS-libs"</code></pre> +<p>For more notes about the PKCS11 tests, please refer to test/jdk/sun/security/pkcs11/README.</p> </body> </html>
--- a/doc/testing.md Mon Sep 23 17:18:03 2019 +0100 +++ b/doc/testing.md Wed Sep 25 13:40:36 2019 +0530 @@ -407,6 +407,20 @@ $ export LANG="en_US" && make test TEST=... $ make test JTREG="VM_OPTIONS=-Duser.language=en -Duser.country=US" TEST=... +### PKCS11 Tests + +It is highly recommended to use the latest NSS version when running PKCS11 tests. +Improper NSS version may lead to unexpected failures which are hard to diagnose. +For example, sun/security/pkcs11/Secmod/AddTrustedCert.java may fail on Ubuntu +18.04 with the default NSS version in the system. +To run these tests correctly, the system property `test.nss.lib.paths` is required +on Ubuntu 18.04 to specify the alternative NSS lib directories. +For example: + + $ make test TEST="jtreg:sun/security/pkcs11/Secmod/AddTrustedCert.java" JTREG="JAVA_OPTIONS=-Dtest.nss.lib.paths=/path/to/your/latest/NSS-libs" + +For more notes about the PKCS11 tests, please refer to test/jdk/sun/security/pkcs11/README. + --- # Override some definitions in the global css file that are not optimal for # this document.
--- a/make/Main.gmk Mon Sep 23 17:18:03 2019 +0100 +++ b/make/Main.gmk Wed Sep 25 13:40:36 2019 +0530 @@ -707,6 +707,8 @@ $(foreach m, $(JAVA_MODULES), \ $(eval $m-java: $(addsuffix -java, $(filter $(JAVA_MODULES), \ $(call FindDepsForModule,$m))))) + # Declare dependencies between the module meta targets + $(foreach m, $(ALL_MODULES), $(eval $m: $(call FindDepsForModule,$m))) # Declare dependencies between <module>-rmic to <module>-java $(foreach m, $(RMIC_MODULES), $(eval $m-rmic: $m-java))
--- a/make/autoconf/basics.m4 Mon Sep 23 17:18:03 2019 +0100 +++ b/make/autoconf/basics.m4 Wed Sep 25 13:40:36 2019 +0530 @@ -205,6 +205,32 @@ fi ]) +################################################################################ +# This will make a path absolute. Assumes it's already a unix path. Also +# resolves ~ to homedir. +AC_DEFUN([BASIC_ABSOLUTE_PATH], +[ + if test "x[$]$1" != x; then + new_path="[$]$1" + + if [ [[ "$new_path" = ~* ]] ]; then + # Use eval to expand a potential ~ + eval new_path="$new_path" + if test ! -f "$new_path" && test ! -d "$new_path"; then + AC_MSG_ERROR([The new_path of $1, which resolves as "$new_path", is not found.]) + fi + fi + + if test -d "$new_path"; then + $1="`cd "$new_path"; $THEPWDCMD -L`" + else + dir="`$DIRNAME "$new_path"`" + base="`$BASENAME "$new_path"`" + $1="`cd "$dir"; $THEPWDCMD -L`/$base" + fi + fi +]) + ############################################################################### # This will make sure the given variable points to a full and proper # path. This means: @@ -217,7 +243,6 @@ AC_DEFUN([BASIC_FIXUP_PATH], [ # Only process if variable expands to non-empty - if test "x[$]$1" != x; then if test "x$OPENJDK_BUILD_OS_ENV" = "xwindows.cygwin"; then BASIC_FIXUP_PATH_CYGWIN($1) @@ -234,19 +259,8 @@ AC_MSG_ERROR([Spaces are not allowed in this path.]) fi - # Use eval to expand a potential ~ - eval path="$path" - if test ! -f "$path" && test ! -d "$path"; then - AC_MSG_ERROR([The path of $1, which resolves as "$path", is not found.]) - fi - - if test -d "$path"; then - $1="`cd "$path"; $THEPWDCMD -L`" - else - dir="`$DIRNAME "$path"`" - base="`$BASENAME "$path"`" - $1="`cd "$dir"; $THEPWDCMD -L`/$base" - fi + BASIC_ABSOLUTE_PATH(path) + $1="$path" fi fi ])
--- a/make/autoconf/basics_windows.m4 Mon Sep 23 17:18:03 2019 +0100 +++ b/make/autoconf/basics_windows.m4 Wed Sep 25 13:40:36 2019 +0530 @@ -148,6 +148,8 @@ path="[$]$1" new_path=`$CYGPATH -u "$path"` + BASIC_ABSOLUTE_PATH(new_path) + # Cygwin tries to hide some aspects of the Windows file system, such that binaries are # named .exe but called without that suffix. Therefore, "foo" and "foo.exe" are considered # the same file, most of the time (as in "test -f"). But not when running cygpath -s, then @@ -181,6 +183,8 @@ new_path=`cmd //c echo $path` fi + BASIC_ABSOLUTE_PATH(new_path) + BASIC_MAKE_WINDOWS_SPACE_SAFE_MSYS([$new_path]) BASIC_WINDOWS_REWRITE_AS_UNIX_PATH(new_path) if test "x$path" != "x$new_path"; then @@ -199,6 +203,8 @@ new_path="[$]$1" BASIC_WINDOWS_REWRITE_AS_UNIX_PATH([new_path]) + BASIC_ABSOLUTE_PATH(new_path) + # Call helper function which possibly converts this using DOS-style short mode. # If so, the updated path is stored in $new_path. BASIC_MAKE_WINDOWS_SPACE_SAFE_WSL([$new_path])
--- a/make/common/TestFilesCompilation.gmk Mon Sep 23 17:18:03 2019 +0100 +++ b/make/common/TestFilesCompilation.gmk Wed Sep 25 13:40:36 2019 +0530 @@ -62,7 +62,7 @@ $1_OUTPUT_SUBDIR := lib $1_BASE_CFLAGS := $(CFLAGS_JDKLIB) $1_BASE_CXXFLAGS := $(CXXFLAGS_JDKLIB) - $1_LDFLAGS := $(LDFLAGS_JDKLIB) $(call SET_SHARED_LIBRARY_ORIGIN) + $1_LDFLAGS := $(LDFLAGS_JDKLIB) $$(call SET_SHARED_LIBRARY_ORIGIN) $1_COMPILATION_TYPE := LIBRARY else ifeq ($$($1_TYPE), PROGRAM) $1_PREFIX = exe
--- a/make/data/tzdata/VERSION Mon Sep 23 17:18:03 2019 +0100 +++ b/make/data/tzdata/VERSION Wed Sep 25 13:40:36 2019 +0530 @@ -21,4 +21,4 @@ # or visit www.oracle.com if you need additional information or have any # questions. # -tzdata2019b +tzdata2019c
--- a/make/data/tzdata/asia Mon Sep 23 17:18:03 2019 +0100 +++ b/make/data/tzdata/asia Wed Sep 25 13:40:36 2019 +0530 @@ -31,7 +31,7 @@ # tz@iana.org for general use in the future). For more, please see # the file CONTRIBUTING in the tz distribution. -# From Paul Eggert (2018-06-19): +# From Paul Eggert (2019-07-11): # # Unless otherwise specified, the source for data through 1990 is: # Thomas G. Shanks and Rique Pottenger, The International Atlas (6th edition), @@ -70,13 +70,13 @@ # 7:00 WIB west Indonesia (Waktu Indonesia Barat) # 8:00 WITA central Indonesia (Waktu Indonesia Tengah) # 8:00 CST China -# 8:00 PST PDT* Philippine Standard Time +# 8:00 HKT HKST Hong Kong (HKWT* for Winter Time in late 1941) +# 8:00 PST PDT* Philippines # 8:30 KST KDT Korea when at +0830 # 9:00 WIT east Indonesia (Waktu Indonesia Timur) # 9:00 JST JDT Japan # 9:00 KST KDT Korea when at +09 -# 9:30 ACST Australian Central Standard Time -# *I invented the abbreviation PDT; see "Philippines" below. +# *I invented the abbreviations HKWT and PDT; see below. # Otherwise, these tables typically use numeric abbreviations like +03 # and +0330 for integer hour and minute UT offsets. Although earlier # editions invented alphabetic time zone abbreviations for every @@ -676,6 +676,15 @@ # * 1941-09-30, Hong Kong Daily Press, Winter Time Warning. # https://i.imgur.com/dge4kFJ.png +# From Paul Eggert (2019-07-11): +# "Hong Kong winter time" is considered to be daylight saving. +# "Hong Kong had adopted daylight saving on June 15 as a wartime measure, +# clocks moving forward one hour until October 1, when they would be put back +# by just half an hour for 'Hong Kong Winter time', so that daylight saving +# operated year round." -- Low Z. The longest day: when wartime Hong Kong +# introduced daylight saving. South China Morning Post. 2019-06-28. +# https://www.scmp.com/magazines/post-magazine/short-reads/article/3016281/longest-day-when-wartime-hong-kong-introduced + # From P Chan (2018-12-31): # * According to the Hong Kong Daylight-Saving Regulations, 1941, the # 1941 spring-forward transition was at 03:00. @@ -777,7 +786,7 @@ Zone Asia/Hong_Kong 7:36:42 - LMT 1904 Oct 30 0:36:42 8:00 - HKT 1941 Jun 15 3:00 8:00 1:00 HKST 1941 Oct 1 4:00 - 8:30 - HKT 1941 Dec 25 + 8:00 0:30 HKWT 1941 Dec 25 9:00 - JST 1945 Nov 18 2:00 8:00 HK HK%sT @@ -2442,7 +2451,7 @@ Zone Asia/Seoul 8:27:52 - LMT 1908 Apr 1 8:30 - KST 1912 Jan 1 9:00 - JST 1945 Sep 8 - 9:00 - KST 1954 Mar 21 + 9:00 ROK K%sT 1954 Mar 21 8:30 ROK K%sT 1961 Aug 10 9:00 ROK K%sT Zone Asia/Pyongyang 8:23:00 - LMT 1908 Apr 1 @@ -3627,7 +3636,7 @@ # and in South Vietnam in particular (after 1954): # To 07:00 on 1911-05-01. # To 08:00 on 1942-12-31 at 23:00. -# To 09:00 in 1945-03-14 at 23:00. +# To 09:00 on 1945-03-14 at 23:00. # To 07:00 on 1945-09-02 in Vietnam. # To 08:00 on 1947-04-01 in French-controlled Indochina. # To 07:00 on 1955-07-01 in South Vietnam.
--- a/make/data/tzdata/australasia Mon Sep 23 17:18:03 2019 +0100 +++ b/make/data/tzdata/australasia Wed Sep 25 13:40:36 2019 +0530 @@ -390,13 +390,18 @@ # From Raymond Kumar (2018-07-13): # http://www.fijitimes.com/government-approves-2018-daylight-saving/ # ... The daylight saving period will end at 3am on Sunday January 13, 2019. -# -# From Paul Eggert (2018-07-15): -# For now, guess DST from 02:00 the first Sunday in November to 03:00 -# the first Sunday on or after January 13. January transitions reportedly + +# From Paul Eggert (2019-08-06): +# Today Raymond Kumar reported the Government of Fiji Gazette Supplement No. 27 +# (2019-08-02) said that Fiji observes DST "commencing at 2.00 am on +# Sunday, 10 November 2019 and ending at 3.00 am on Sunday, 12 January 2020." +# For now, guess DST from 02:00 the second Sunday in November to 03:00 +# the first Sunday on or after January 12. January transitions reportedly # depend on when school terms start. Although the guess is ad hoc, it matches -# transitions since late 2014 and seems more likely to match future -# practice than guessing no DST. +# transitions planned this year and seems more likely to match future practice +# than guessing no DST. +# From Michael Deckers (2019-08-06): +# https://www.laws.gov.fj/LawsAsMade/downloadfile/848 # Rule NAME FROM TO TYPE IN ON AT SAVE LETTER/S Rule Fiji 1998 1999 - Nov Sun>=1 2:00 1:00 - @@ -407,8 +412,9 @@ Rule Fiji 2011 only - Mar Sun>=1 3:00 0 - Rule Fiji 2012 2013 - Jan Sun>=18 3:00 0 - Rule Fiji 2014 only - Jan Sun>=18 2:00 0 - -Rule Fiji 2014 max - Nov Sun>=1 2:00 1:00 - -Rule Fiji 2015 max - Jan Sun>=13 3:00 0 - +Rule Fiji 2014 2018 - Nov Sun>=1 2:00 1:00 - +Rule Fiji 2015 max - Jan Sun>=12 3:00 0 - +Rule Fiji 2019 max - Nov Sun>=8 2:00 1:00 - # Zone NAME STDOFF RULES FORMAT [UNTIL] Zone Pacific/Fiji 11:55:44 - LMT 1915 Oct 26 # Suva 12:00 Fiji +12/+13 @@ -627,10 +633,11 @@ # Zone NAME STDOFF RULES FORMAT [UNTIL] Zone Pacific/Norfolk 11:11:52 - LMT 1901 # Kingston 11:12 - +1112 1951 - 11:30 - +1130 1974 Oct 27 02:00 - 11:30 1:00 +1230 1975 Mar 2 02:00 - 11:30 - +1130 2015 Oct 4 02:00 - 11:00 - +11 + 11:30 - +1130 1974 Oct 27 02:00s + 11:30 1:00 +1230 1975 Mar 2 02:00s + 11:30 - +1130 2015 Oct 4 02:00s + 11:00 - +11 2019 Jul + 11:00 AN +11/+12 # Palau (Belau) # Zone NAME STDOFF RULES FORMAT [UNTIL] @@ -1898,12 +1905,21 @@ # ... at 12.30 am (by legal time in New South Wales) on 4 October 2015. # http://www.norfolkisland.gov.nf/nia/MediaRelease/Media%20Release%20Norfolk%20Island%20Standard%20Time%20Change.pdf -# From Paul Eggert (2015-09-23): +# From Paul Eggert (2019-08-28): # Transitions before 2015 are from timeanddate.com, which consulted # the Norfolk Island Museum and the Australian Bureau of Meteorology's # Norfolk Island station, and found no record of Norfolk observing DST # other than in 1974/5. See: # https://www.timeanddate.com/time/australia/norfolk-island.html +# However, disagree with timeanddate about the 1975-03-02 transition; +# timeanddate has 02:00 but 02:00s corresponds to what the NSW law said +# (thanks to Michael Deckers). + +# Norfolk started observing Australian DST in spring 2019. +# From Kyle Czech (2019-08-13): +# https://www.legislation.gov.au/Details/F2018L01702 +# From Michael Deckers (2019-08-14): +# https://www.legislation.gov.au/Details/F2019C00010 # Palau # See commentary for Micronesia.
--- a/make/data/tzdata/europe Mon Sep 23 17:18:03 2019 +0100 +++ b/make/data/tzdata/europe Wed Sep 25 13:40:36 2019 +0530 @@ -844,11 +844,16 @@ # Shanks & Pottenger give 02:00, the BEV 00:00. Go with the BEV, # and guess 02:00 for 1945-04-12. +# From Alois Triendl (2019-07-22): +# In 1946 the end of DST was on Monday, 7 October 1946, at 3:00 am. +# Shanks had this right. Source: Die Weltpresse, 5. Oktober 1946, page 5. + # Rule NAME FROM TO TYPE IN ON AT SAVE LETTER/S Rule Austria 1920 only - Apr 5 2:00s 1:00 S Rule Austria 1920 only - Sep 13 2:00s 0 - Rule Austria 1946 only - Apr 14 2:00s 1:00 S -Rule Austria 1946 1948 - Oct Sun>=1 2:00s 0 - +Rule Austria 1946 only - Oct 7 2:00s 0 - +Rule Austria 1947 1948 - Oct Sun>=1 2:00s 0 - Rule Austria 1947 only - Apr 6 2:00s 1:00 S Rule Austria 1948 only - Apr 18 2:00s 1:00 S Rule Austria 1980 only - Apr 6 0:00 1:00 S @@ -898,15 +903,35 @@ # Belgium # -# From Paul Eggert (1997-07-02): +# From Michael Deckers (2019-08-25): +# The exposition in the web page +# https://www.bestor.be/wiki/index.php/Voyager_dans_le_temps._L%E2%80%99introduction_de_la_norme_de_Greenwich_en_Belgique +# gives several contemporary sources from which one can conclude that +# the switch in Europe/Brussels on 1892-05-01 was from 00:17:30 to 00:00:00. +# +# From Paul Eggert (2019-08-28): +# This quote helps explain the late-1914 situation: +# In early November 1914, the Germans imposed the time zone used in central +# Europe and forced the inhabitants to set their watches and public clocks +# sixty minutes ahead. Many were reluctant to accept "German time" and +# continued to use "Belgian time" among themselves. Reflecting the spirit of +# resistance that arose in the population, a song made fun of this change.... +# The song ended: +# Putting your clock forward +# Will but hasten the happy hour +# When we kick out the Boches! +# See: Pluvinage G. Brussels on German time. Cahiers Bruxellois - +# Brusselse Cahiers. 2014;XLVI(1E):15-38. +# https://www.cairn.info/revue-cahiers-bruxellois-2014-1E-page-15.htm +# +# Entries from 1914 through 1917 are taken from "De tijd in België" +# <https://www.astro.oma.be/GENERAL/INFO/nli001a.html>. # Entries from 1918 through 1991 are taken from: # Annuaire de L'Observatoire Royal de Belgique, # Avenue Circulaire, 3, B-1180 BRUXELLES, CLVIIe année, 1991 # (Imprimerie HAYEZ, s.p.r.l., Rue Fin, 4, 1080 BRUXELLES, MCMXC), # pp 8-9. -# LMT before 1892 was 0:17:30, according to the official journal of Belgium: -# Moniteur Belge, Samedi 30 Avril 1892, N.121. -# Thanks to Pascal Delmoitie for these references. +# Thanks to Pascal Delmoitie for the 1918/1991 references. # The 1918 rules are listed for completeness; they apply to unoccupied Belgium. # Assume Brussels switched to WET in 1918 when the armistice took effect. # @@ -951,7 +976,7 @@ Rule Belgium 1946 only - Oct 7 2:00s 0 - # Zone NAME STDOFF RULES FORMAT [UNTIL] Zone Europe/Brussels 0:17:30 - LMT 1880 - 0:17:30 - BMT 1892 May 1 12:00 # Brussels MT + 0:17:30 - BMT 1892 May 1 00:17:30 0:00 - WET 1914 Nov 8 1:00 - CET 1916 May 1 0:00 1:00 C-Eur CE%sT 1918 Nov 11 11:00u @@ -1650,6 +1675,13 @@ # advanced to sixty minutes later starting at hour two on 1944-04-02; ... # Starting at hour three on the date 1944-09-17 standard time will be resumed. # +# From Alois Triendl (2019-07-02): +# I spent 6 Euros to buy two archive copies of Il Messaggero, a Roman paper, +# for 1 and 2 April 1944. The edition of 2 April has this note: "Tonight at 2 +# am, put forward the clock by one hour. Remember that in the night between +# today and Monday the 'ora legale' will come in force again." That makes it +# clear that in Rome the change was on Monday, 3 April 1944 at 2 am. +# # From Paul Eggert (2016-10-27): # Go with INRiM for DST rules, except as corrected by Inglis for 1944 # for the Kingdom of Italy. This is consistent with Renzo Baldini. @@ -1797,15 +1829,10 @@ # From Paul Eggert (2013-09-09): # Shanks & Pottenger say Vaduz is like Zurich. -# From Alois Treindl (2013-09-18): -# http://www.eliechtensteinensia.li/LIJ/1978/1938-1978/1941.pdf -# ... confirms on p. 6 that Liechtenstein followed Switzerland in 1941 and 1942. -# I ... translate only the last two paragraphs: -# ... during second world war, in the years 1941 and 1942, Liechtenstein -# introduced daylight saving time, adapting to Switzerland. From 1943 on -# central European time was in force throughout the year. -# From a report of the duke's government to the high council, -# regarding the introduction of a time law, of 31 May 1977. +# From Alois Treindl (2019-07-04): +# I was able to access the online archive of the Vaduz paper Vaterland ... +# I could confirm from the paper that Liechtenstein did in fact follow +# the same DST in 1941 and 1942 as Switzerland did. Link Europe/Zurich Europe/Vaduz @@ -2513,6 +2540,12 @@ # Europe/Kaliningrad covers... # 39 RU-KGD Kaliningrad Oblast +# From Paul Eggert (2019-07-25): +# Although Shanks lists 1945-01-01 as the date for transition from +# +01/+02 to +02/+03, more likely this is a placeholder. Guess that +# the transition occurred at 1945-04-10 00:00, which is about when +# Königsberg surrendered to Soviet troops. (Thanks to Alois Triendl.) + # From Paul Eggert (2016-03-18): # The 1989 transition is from USSR act No. 227 (1989-03-14). @@ -2529,8 +2562,8 @@ # Moscow on 1991-11-03, switched to Moscow-1 on 1992-01-19. Zone Europe/Kaliningrad 1:22:00 - LMT 1893 Apr - 1:00 C-Eur CE%sT 1945 - 2:00 Poland CE%sT 1946 + 1:00 C-Eur CE%sT 1945 Apr 10 + 2:00 Poland EE%sT 1946 Apr 7 3:00 Russia MSK/MSD 1989 Mar 26 2:00s 2:00 Russia EE%sT 2011 Mar 27 2:00s 3:00 - +03 2014 Oct 26 2:00s @@ -3673,20 +3706,75 @@ # Turkey +# From Alois Treindl (2019-08-12): +# http://www.astrolojidergisi.com/yazsaati.htm has researched the time zone +# history of Turkey, based on newspaper archives and official documents. +# From Paul Eggert (2019-08-28): +# That source (Oya Vulaş, "Türkiye'de Yaz Saati Uygulamaları") +# is used for 1940/1972, where it seems more reliable than our other +# sources. + +# From Kıvanç Yazan (2019-08-12): +# http://www.resmigazete.gov.tr/arsiv/14539.pdf#page=24 +# 1973-06-03 01:00 -> 02:00, 1973-11-04 02:00 -> 01:00 +# +# http://www.resmigazete.gov.tr/arsiv/14829.pdf#page=1 +# 1974-03-31 02:00 -> 03:00, 1974-11-03 02:00 -> 01:00 +# +# http://www.resmigazete.gov.tr/arsiv/15161.pdf#page=1 +# 1975-03-22 02:00 -> 03:00, 1975-11-02 02:00 -> 01:00 +# +# http://www.resmigazete.gov.tr/arsiv/15535_1.pdf#page=1 +# 1976-03-21 02:00 -> 03:00, 1976-10-31 02:00 -> 01:00 +# +# http://www.resmigazete.gov.tr/arsiv/15778.pdf#page=5 +# 1977-04-03 02:00 -> 03:00, 1977-10-16 02:00 -> 01:00, +# 1978-04-02 02:00 -> 03:00 (not applied, see below) +# 1978-10-15 02:00 -> 01:00 (not applied, see below) +# 1979-04-01 02:00 -> 03:00 (not applied, see below) +# 1979-10-14 02:00 -> 01:00 (not applied, see below) +# +# http://www.resmigazete.gov.tr/arsiv/16245.pdf#page=17 +# This cancels the previous decision, and repeats it only for 1978. +# 1978-04-02 02:00 -> 03:00, 1978-10-15 02:00 -> 01:00 +# (not applied due to standard TZ change below) +# +# http://www.resmigazete.gov.tr/arsiv/16331.pdf#page=3 +# This decision changes the default longitude for Turkish time zone from 30 +# degrees East to 45 degrees East. This means a standard TZ change, from +2 +# to +3. This is published & applied on 1978-06-29. At that time, Turkey was +# already on summer time (already on 45E). Hence, this new law just meant an +# "continuous summer time". Note that this was reversed in a few years. +# +# http://www.resmigazete.gov.tr/arsiv/18119_1.pdf#page=1 +# 1983-07-31 02:00 -> 03:00 (note that this jumps TZ to +4) +# 1983-10-02 02:00 -> 01:00 (back to +3) +# +# http://www.resmigazete.gov.tr/arsiv/18561.pdf (page 1 and 34) +# At this time, Turkey is still on +3 with no spring-forward on early +# 1984. This decision is published on 10/31/1984. Page 1 declares +# the decision of reverting the "default longitude change". So the +# standard time should go back to +3 (30E). And page 34 explains when +# that will happen: 1984-11-01 02:00 -> 01:00. You can think of this +# as "end of continuous summer time, change of standard time zone". +# +# http://www.resmigazete.gov.tr/arsiv/18713.pdf#page=1 +# 1985-04-20 01:00 -> 02:00, 1985-09-28 02:00 -> 01:00 + # From Kıvanç Yazan (2016-09-25): # 1) For 1986-2006, DST started at 01:00 local and ended at 02:00 local, with # no exceptions. # 2) 1994's lastSun was overridden with Mar 20 ... # Here are official papers: -# http://www.resmigazete.gov.tr/arsiv/19032.pdf - page 2 for 1986 -# http://www.resmigazete.gov.tr/arsiv/19400.pdf - page 4 for 1987 -# http://www.resmigazete.gov.tr/arsiv/19752.pdf - page 15 for 1988 -# http://www.resmigazete.gov.tr/arsiv/20102.pdf - page 6 for 1989 -# http://www.resmigazete.gov.tr/arsiv/20464.pdf - page 1 for 1990 - 1992 -# http://www.resmigazete.gov.tr/arsiv/21531.pdf - page 15 for 1993 - 1995 -# http://www.resmigazete.gov.tr/arsiv/21879.pdf - page 1 for overriding 1994 -# http://www.resmigazete.gov.tr/arsiv/22588.pdf - page 1 for 1996, 1997 -# http://www.resmigazete.gov.tr/arsiv/23286.pdf - page 10 for 1998 - 2000 +# http://www.resmigazete.gov.tr/arsiv/19032.pdf#page=2 for 1986 +# http://www.resmigazete.gov.tr/arsiv/19400.pdf#page=4 for 1987 +# http://www.resmigazete.gov.tr/arsiv/19752.pdf#page=15 for 1988 +# http://www.resmigazete.gov.tr/arsiv/20102.pdf#page=6 for 1989 +# http://www.resmigazete.gov.tr/arsiv/20464.pdf#page=1 for 1990 - 1992 +# http://www.resmigazete.gov.tr/arsiv/21531.pdf#page=15 for 1993 - 1995 +# http://www.resmigazete.gov.tr/arsiv/21879.pdf#page=1 for overriding 1994 +# http://www.resmigazete.gov.tr/arsiv/22588.pdf#page=1 for 1996, 1997 +# http://www.resmigazete.gov.tr/arsiv/23286.pdf#page=10 for 1998 - 2000 # http://www.resmigazete.gov.tr/eskiler/2001/03/20010324.htm#2 - for 2001 # http://www.resmigazete.gov.tr/eskiler/2002/03/20020316.htm#2 - for 2002-2006 # From Paul Eggert (2016-09-25): @@ -3770,46 +3858,36 @@ Rule Turkey 1924 only - May 13 0:00 1:00 S Rule Turkey 1924 1925 - Oct 1 0:00 0 - Rule Turkey 1925 only - May 1 0:00 1:00 S -Rule Turkey 1940 only - Jun 30 0:00 1:00 S -Rule Turkey 1940 only - Oct 5 0:00 0 - +Rule Turkey 1940 only - Jul 1 0:00 1:00 S +Rule Turkey 1940 only - Oct 6 0:00 0 - Rule Turkey 1940 only - Dec 1 0:00 1:00 S Rule Turkey 1941 only - Sep 21 0:00 0 - Rule Turkey 1942 only - Apr 1 0:00 1:00 S -# Whitman omits the next two transition and gives 1945 Oct 1; -# go with Shanks & Pottenger. -Rule Turkey 1942 only - Nov 1 0:00 0 - -Rule Turkey 1945 only - Apr 2 0:00 1:00 S Rule Turkey 1945 only - Oct 8 0:00 0 - Rule Turkey 1946 only - Jun 1 0:00 1:00 S Rule Turkey 1946 only - Oct 1 0:00 0 - Rule Turkey 1947 1948 - Apr Sun>=16 0:00 1:00 S -Rule Turkey 1947 1950 - Oct Sun>=2 0:00 0 - +Rule Turkey 1947 1951 - Oct Sun>=2 0:00 0 - Rule Turkey 1949 only - Apr 10 0:00 1:00 S -Rule Turkey 1950 only - Apr 19 0:00 1:00 S +Rule Turkey 1950 only - Apr 16 0:00 1:00 S Rule Turkey 1951 only - Apr 22 0:00 1:00 S -Rule Turkey 1951 only - Oct 8 0:00 0 - +# DST for 15 months; unusual but we'll let it pass. Rule Turkey 1962 only - Jul 15 0:00 1:00 S -Rule Turkey 1962 only - Oct 8 0:00 0 - +Rule Turkey 1963 only - Oct 30 0:00 0 - Rule Turkey 1964 only - May 15 0:00 1:00 S Rule Turkey 1964 only - Oct 1 0:00 0 - -Rule Turkey 1970 1972 - May Sun>=2 0:00 1:00 S -Rule Turkey 1970 1972 - Oct Sun>=2 0:00 0 - Rule Turkey 1973 only - Jun 3 1:00 1:00 S -Rule Turkey 1973 only - Nov 4 3:00 0 - +Rule Turkey 1973 1976 - Oct Sun>=31 2:00 0 - Rule Turkey 1974 only - Mar 31 2:00 1:00 S -Rule Turkey 1974 only - Nov 3 5:00 0 - -Rule Turkey 1975 only - Mar 30 0:00 1:00 S -Rule Turkey 1975 1976 - Oct lastSun 0:00 0 - -Rule Turkey 1976 only - Jun 1 0:00 1:00 S -Rule Turkey 1977 1978 - Apr Sun>=1 0:00 1:00 S -Rule Turkey 1977 only - Oct 16 0:00 0 - -Rule Turkey 1979 1980 - Apr Sun>=1 3:00 1:00 S -Rule Turkey 1979 1982 - Oct Mon>=11 0:00 0 - -Rule Turkey 1981 1982 - Mar lastSun 3:00 1:00 S -Rule Turkey 1983 only - Jul 31 0:00 1:00 S -Rule Turkey 1983 only - Oct 2 0:00 0 - -Rule Turkey 1985 only - Apr 20 0:00 1:00 S -Rule Turkey 1985 only - Sep 28 0:00 0 - +Rule Turkey 1975 only - Mar 22 2:00 1:00 S +Rule Turkey 1976 only - Mar 21 2:00 1:00 S +Rule Turkey 1977 1978 - Apr Sun>=1 2:00 1:00 S +Rule Turkey 1977 1978 - Oct Sun>=15 2:00 0 - +Rule Turkey 1978 only - Jun 29 0:00 0 - +Rule Turkey 1983 only - Jul 31 2:00 1:00 S +Rule Turkey 1983 only - Oct 2 2:00 0 - +Rule Turkey 1985 only - Apr 20 1:00s 1:00 S +Rule Turkey 1985 only - Sep 28 1:00s 0 - Rule Turkey 1986 1993 - Mar lastSun 1:00s 1:00 S Rule Turkey 1986 1995 - Sep lastSun 1:00s 0 - Rule Turkey 1994 only - Mar 20 1:00s 1:00 S @@ -3818,8 +3896,8 @@ # Zone NAME STDOFF RULES FORMAT [UNTIL] Zone Europe/Istanbul 1:55:52 - LMT 1880 1:56:56 - IMT 1910 Oct # Istanbul Mean Time? - 2:00 Turkey EE%sT 1978 Oct 15 - 3:00 Turkey +03/+04 1985 Apr 20 + 2:00 Turkey EE%sT 1978 Jun 29 + 3:00 Turkey +03/+04 1984 Nov 1 2:00 2:00 Turkey EE%sT 2007 2:00 EU EE%sT 2011 Mar 27 1:00u 2:00 - EET 2011 Mar 28 1:00u
--- a/make/data/tzdata/leapseconds Mon Sep 23 17:18:03 2019 +0100 +++ b/make/data/tzdata/leapseconds Wed Sep 25 13:40:36 2019 +0530 @@ -26,36 +26,39 @@ # This file is in the public domain. # This file is generated automatically from the data in the public-domain -# leap-seconds.list file, which can be copied from +# NIST format leap-seconds.list file, which can be copied from # <ftp://ftp.nist.gov/pub/time/leap-seconds.list> -# or <ftp://ftp.boulder.nist.gov/pub/time/leap-seconds.list> -# or <ftp://tycho.usno.navy.mil/pub/ntp/leap-seconds.list>. +# or <ftp://ftp.boulder.nist.gov/pub/time/leap-seconds.list>. # For more about leap-seconds.list, please see # The NTP Timescale and Leap Seconds # <https://www.eecis.udel.edu/~mills/leap.html>. -# The International Earth Rotation and Reference Systems Service +# The rules for leap seconds are specified in Annex 1 (Time scales) of: +# Standard-frequency and time-signal emissions. +# International Telecommunication Union - Radiocommunication Sector +# (ITU-R) Recommendation TF.460-6 (02/2002) +# <https://www.itu.int/rec/R-REC-TF.460-6-200202-I/>. +# The International Earth Rotation and Reference Systems Service (IERS) # periodically uses leap seconds to keep UTC to within 0.9 s of UT1 -# (which measures the true angular orientation of the earth in space) +# (a proxy for Earth's angle in space as measured by astronomers) # and publishes leap second data in a copyrighted file # <https://hpiers.obspm.fr/iers/bul/bulc/Leap_Second.dat>. # See: Levine J. Coordinated Universal Time and the leap second. # URSI Radio Sci Bull. 2016;89(4):30-6. doi:10.23919/URSIRSB.2016.7909995 # <https://ieeexplore.ieee.org/document/7909995>. -# There were no leap seconds before 1972, because the official mechanism -# accounting for the discrepancy between atomic time and the earth's rotation -# did not exist. The first ("1 Jan 1972") data line in leap-seconds.list +# There were no leap seconds before 1972, as no official mechanism +# accounted for the discrepancy between atomic time (TAI) and the earth's +# rotation. The first ("1 Jan 1972") data line in leap-seconds.list # does not denote a leap second; it denotes the start of the current definition # of UTC. -# The correction (+ or -) is made at the given time, so lines -# will typically look like: -# Leap YEAR MON DAY 23:59:60 + R/S -# or -# Leap YEAR MON DAY 23:59:59 - R/S - -# If the leap second is Rolling (R) the given time is local time (unused here). +# All leap-seconds are Stationary (S) at the given UTC time. +# The correction (+ or -) is made at the given time, so in the unlikely +# event of a negative leap second, a line would look like this: +# Leap YEAR MON DAY 23:59:59 - S +# Typical lines look like this: +# Leap YEAR MON DAY 23:59:60 + S Leap 1972 Jun 30 23:59:60 + S Leap 1972 Dec 31 23:59:60 + S Leap 1973 Dec 31 23:59:60 + S @@ -85,8 +88,8 @@ Leap 2016 Dec 31 23:59:60 + S # POSIX timestamps for the data in this file: -#updated 1467936000 -#expires 1577491200 +#updated 1467936000 (2016-07-08 00:00:00 UTC) +#expires 1593302400 (2020-06-28 00:00:00 UTC) -# Updated through IERS Bulletin C57 -# File expires on: 28 December 2019 +# Updated through IERS Bulletin C58 +# File expires on: 28 June 2020
--- a/make/data/tzdata/northamerica Mon Sep 23 17:18:03 2019 +0100 +++ b/make/data/tzdata/northamerica Wed Sep 25 13:40:36 2019 +0530 @@ -429,6 +429,31 @@ # From Paul Eggert (2015-12-25): # Assume this practice predates 1970, so Fort Pierre can use America/Chicago. +# From Paul Eggert (2015-04-06): +# In 1950s Nashville a public clock had dueling faces, one for conservatives +# and the other for liberals; the two sides didn't agree about the time of day. +# I haven't found a photo of this clock, nor have I tracked down the TIME +# magazine report cited below, but here's the story as told by the late +# American journalist John Seigenthaler, who was there: +# +# "The two [newspaper] owners held strongly contrasting political and +# ideological views. Evans was a New South liberal, Stahlman an Old South +# conservative, and their two papers frequently clashed editorially, often on +# the same day.... In the 1950s as the state legislature was grappling with +# the question of whether to approve daylight saving time for the entire state, +# TIME magazine reported: +# +# "'The Nashville Banner and The Nashville Tennessean rarely agree on anything +# but the time of day - and last week they couldn't agree on that.' +# +# "It was all too true. The clock on the front of the building had two faces - +# The Tennessean side of the building facing west, the other, east. When it +# was high noon Banner time, it was 11 a.m. Tennessean time." +# +# Seigenthaler J. For 100 years, Tennessean had it covered. +# The Tennessean 2007-05-11, republished 2015-04-06. +# https://www.tennessean.com/story/insider/extras/2015/04/06/archives-seigenthaler-for-100-years-the-tennessean-had-it-covered/25348545/ + # Rule NAME FROM TO TYPE IN ON AT SAVE LETTER Rule Chicago 1920 only - Jun 13 2:00 1:00 D Rule Chicago 1920 1921 - Oct lastSun 2:00 0 S @@ -968,21 +993,21 @@ -5:00 US E%sT # # Perry County, Indiana, switched from eastern to central time in April 2006. +# From Alois Triendl (2019-07-09): +# The Indianapolis News, Friday 27 October 1967 states that Perry County +# returned to CST. It went again to EST on 27 April 1969, as documented by the +# Indianapolis star of Saturday 26 April. # Rule NAME FROM TO TYPE IN ON AT SAVE LETTER -Rule Perry 1946 only - Apr lastSun 2:00 1:00 D -Rule Perry 1946 only - Sep lastSun 2:00 0 S -Rule Perry 1953 1954 - Apr lastSun 2:00 1:00 D -Rule Perry 1953 1959 - Sep lastSun 2:00 0 S Rule Perry 1955 only - May 1 0:00 1:00 D +Rule Perry 1955 1960 - Sep lastSun 2:00 0 S Rule Perry 1956 1963 - Apr lastSun 2:00 1:00 D -Rule Perry 1960 only - Oct lastSun 2:00 0 S -Rule Perry 1961 only - Sep lastSun 2:00 0 S -Rule Perry 1962 1963 - Oct lastSun 2:00 0 S +Rule Perry 1961 1963 - Oct lastSun 2:00 0 S # Zone NAME STDOFF RULES FORMAT [UNTIL] Zone America/Indiana/Tell_City -5:47:03 - LMT 1883 Nov 18 12:12:57 -6:00 US C%sT 1946 -6:00 Perry C%sT 1964 Apr 26 2:00 - -5:00 - EST 1969 + -5:00 - EST 1967 Oct 29 2:00 + -6:00 US C%sT 1969 Apr 27 2:00 -5:00 US E%sT 1971 -5:00 - EST 2006 Apr 2 2:00 -6:00 US C%sT @@ -1058,16 +1083,27 @@ # clear how this matched civil time in Louisville, so for now continue # to assume Louisville switched at noon new local time, like New York. # +# From Michael Deckers (2019-08-06): +# From the contemporary source given by Alois Treindl, +# the switch in Louisville on 1946-04-28 was on 00:01 +# From Paul Eggert (2019-08-26): +# That source was the Louisville Courier-Journal, 1946-04-27, p 4. +# Shanks gives 02:00 for all 20th-century transition times in Louisville. +# Evidently this is wrong for spring 1946. Although also likely wrong +# for other dates, we have no data. +# # Part of Kentucky left its clocks alone in 1974. # This also includes Clark, Floyd, and Harrison counties in Indiana. # Rule NAME FROM TO TYPE IN ON AT SAVE LETTER Rule Louisville 1921 only - May 1 2:00 1:00 D Rule Louisville 1921 only - Sep 1 2:00 0 S -Rule Louisville 1941 1961 - Apr lastSun 2:00 1:00 D +Rule Louisville 1941 only - Apr lastSun 2:00 1:00 D Rule Louisville 1941 only - Sep lastSun 2:00 0 S +Rule Louisville 1946 only - Apr lastSun 0:01 1:00 D Rule Louisville 1946 only - Jun 2 2:00 0 S +Rule Louisville 1950 1961 - Apr lastSun 2:00 1:00 D Rule Louisville 1950 1955 - Sep lastSun 2:00 0 S -Rule Louisville 1956 1960 - Oct lastSun 2:00 0 S +Rule Louisville 1956 1961 - Oct lastSun 2:00 0 S # Zone NAME STDOFF RULES FORMAT [UNTIL] Zone America/Kentucky/Louisville -5:43:02 - LMT 1883 Nov 18 12:16:58 -6:00 US C%sT 1921 @@ -1157,18 +1193,19 @@ # one hour in 1914." This change is not in Shanks. We have no more # info, so omit this for now. # -# From Paul Eggert (2017-07-26): -# Although Shanks says Detroit observed DST in 1967 from 06-14 00:01 -# until 10-29 00:01, I now see multiple reports that this is incorrect. -# For example, according to a 50-year anniversary report about the 1967 -# Detroit riots and a major-league doubleheader on 1967-07-23, "By the time -# the last fly ball of the doubleheader settled into the glove of leftfielder -# Lenny Green, it was after 7 p.m. Detroit did not observe daylight saving -# time, so light was already starting to fail. Twilight was made even deeper -# by billowing columns of smoke that ascended in an unbroken wall north of the -# ballpark." See: Dow B. Detroit '67: As violence unfolded, Tigers played two -# at home vs. Yankees. Detroit Free Press 2017-07-23. -# https://www.freep.com/story/sports/mlb/tigers/2017/07/23/detroit-tigers-1967-riot-new-york-yankees/499951001/ +# From Paul Eggert (2019-07-06): +# Due to a complicated set of legal maneuvers, in 1967 Michigan did +# not start daylight saving time when the rest of the US did. +# Instead, it began DST on Jun 14 at 00:01. This was big news: +# the Detroit Free Press reported it at the top of Page 1 on +# 1967-06-14, in an article "State Adjusting to Switch to Fast Time" +# by Gary Blonston, above an article about Thurgood Marshall's +# confirmation to the US Supreme Court. Although Shanks says Detroit +# observed DST until 1967-10-29 00:01, that time of day seems to be +# incorrect, as the Free Press later said DST ended in Michigan at the +# same time as the rest of the US. Also, although Shanks reports no DST in +# Detroit in 1968, it did observe DST that year; in the November 1968 +# election Michigan voters narrowly repealed DST, effective 1969. # # Most of Michigan observed DST from 1973 on, but was a bit late in 1975. # Rule NAME FROM TO TYPE IN ON AT SAVE LETTER @@ -1179,7 +1216,9 @@ -6:00 - CST 1915 May 15 2:00 -5:00 - EST 1942 -5:00 US E%sT 1946 - -5:00 Detroit E%sT 1973 + -5:00 Detroit E%sT 1967 Jun 14 0:01 + -5:00 US E%sT 1969 + -5:00 - EST 1973 -5:00 US E%sT 1975 -5:00 - EST 1975 Apr 27 2:00 -5:00 US E%sT @@ -1228,6 +1267,12 @@ # # Other sources occasionally used include: # +# Milne J. Civil time. Geogr J. 1899 Feb;13(2):173-94 +# <https://www.jstor.org/stable/1774359>. +# +# Pearce C. The Great Daylight Saving Time Controversy. +# Australian Ebook Publisher. 2017. ISBN 978-1-925516-96-8. +# # Edward W. Whitman, World Time Differences, # Whitman Publishing Co, 2 Niagara Av, Ealing, London (undated), # which I found in the UCLA library. @@ -1236,9 +1281,6 @@ # <http://cs.ucla.edu/~eggert/The-Waste-of-Daylight-19th.pdf> # [PDF] (1914-03) # -# Milne J. Civil time. Geogr J. 1899 Feb;13(2):173-94 -# <https://www.jstor.org/stable/1774359>. -# # See the 'europe' file for Greenland. # Canada @@ -1880,9 +1922,8 @@ # Willett (1914-03) notes that DST "has been in operation ... in the # City of Moose Jaw, Saskatchewan, for one year." -# From Paul Eggert (2019-04-26): -# Chris Pearce's book "The Great Daylight Saving Time Controversy" (2017) -# says that Regina observed DST in 1914-1917. No dates and times, +# From Paul Eggert (2019-07-25): +# Pearce's book says Regina observed DST in 1914-1917. No dates and times, # unfortunately. It also says that in 1914 Saskatoon observed DST # from 1 June to 6 July, and that DST was also tried out in Davidson, # Melfort, and Prince Albert. @@ -1962,6 +2003,19 @@ # Alberta +# From Alois Triendl (2019-07-19): +# There was no DST in Alberta in 1967... Calgary Herald, 29 April 1967. +# 1969, no DST, from Edmonton Journal 18 April 1969 +# +# From Paul Eggert (2019-07-25): +# Pearce's book says that Alberta's 1948 Daylight Saving Act required +# Mountain Standard Time without DST, and that "anyone who broke that law +# could be fined up to $25 and costs". There seems to be no record of +# anybody paying the fine. The law was not changed until an August 1971 +# plebiscite reinstituted DST in 1972. This story is also mentioned in: +# Boyer JP. Forcing Choice: The Risky Reward of Referendums. Dundum. 2017. +# ISBN 978-1459739123. + # Rule NAME FROM TO TYPE IN ON AT SAVE LETTER/S Rule Edm 1918 1919 - Apr Sun>=8 2:00 1:00 D Rule Edm 1918 only - Oct 27 2:00 0 S @@ -1974,10 +2028,6 @@ Rule Edm 1945 only - Sep lastSun 2:00 0 S Rule Edm 1947 only - Apr lastSun 2:00 1:00 D Rule Edm 1947 only - Sep lastSun 2:00 0 S -Rule Edm 1967 only - Apr lastSun 2:00 1:00 D -Rule Edm 1967 only - Oct lastSun 2:00 0 S -Rule Edm 1969 only - Apr lastSun 2:00 1:00 D -Rule Edm 1969 only - Oct lastSun 2:00 0 S Rule Edm 1972 1986 - Apr lastSun 2:00 1:00 D Rule Edm 1972 2006 - Oct lastSun 2:00 0 S # Zone NAME STDOFF RULES FORMAT [UNTIL] @@ -2060,8 +2110,20 @@ # been on MST (-0700) like Dawson Creek since it advanced its clocks on # 2015-03-08. # -# From Paul Eggert (2015-09-23): +# From Paul Eggert (2019-07-25): # Shanks says Fort Nelson did not observe DST in 1946, unlike Vancouver. +# Alois Triendl confirmed this on 07-22, citing the 1946-04-27 Vancouver Daily +# Province. He also cited the 1946-09-28 Victoria Daily Times, which said +# that Vancouver, Victoria, etc. "change at midnight Saturday"; for now, +# guess they meant 02:00 Sunday since 02:00 was common practice in Vancouver. +# +# Early Vancouver, Volume Four, by Major J.S. Matthews, V.D., 2011 edition +# says that a 1922 plebiscite adopted DST, but a 1923 plebiscite rejected it. +# http://former.vancouver.ca/ctyclerk/archives/digitized/EarlyVan/SearchEarlyVan/Vol4pdf/MatthewsEarlyVancouverVol4_DaylightSavings.pdf +# A catalog entry for a newspaper clipping seems to indicate that Vancouver +# observed DST in 1941 from 07-07 through 09-27; see +# https://searcharchives.vancouver.ca/daylight-saving-1918-starts-again-july-7-1941-start-d-s-sept-27-end-of-d-s-1941 +# We have no further details, so omit them for now. # Rule NAME FROM TO TYPE IN ON AT SAVE LETTER/S Rule Vanc 1918 only - Apr 14 2:00 1:00 D @@ -2070,7 +2132,7 @@ Rule Vanc 1945 only - Aug 14 23:00u 1:00 P # Peace Rule Vanc 1945 only - Sep 30 2:00 0 S Rule Vanc 1946 1986 - Apr lastSun 2:00 1:00 D -Rule Vanc 1946 only - Oct 13 2:00 0 S +Rule Vanc 1946 only - Sep 29 2:00 0 S Rule Vanc 1947 1961 - Sep lastSun 2:00 0 S Rule Vanc 1962 2006 - Oct lastSun 2:00 0 S # Zone NAME STDOFF RULES FORMAT [UNTIL]
--- a/make/data/tzdata/southamerica Mon Sep 23 17:18:03 2019 +0100 +++ b/make/data/tzdata/southamerica Wed Sep 25 13:40:36 2019 +0530 @@ -1253,14 +1253,8 @@ # From Juan Correa (2016-12-04): # Magallanes region ... will keep DST (UTC -3) all year round.... # http://www.soychile.cl/Santiago/Sociedad/2016/12/04/433428/Bachelet-firmo-el-decreto-para-establecer-un-horario-unico-para-la-Region-de-Magallanes.aspx -# # From Deborah Goldsmith (2017-01-19): # http://www.diariooficial.interior.gob.cl/publicaciones/2017/01/17/41660/01/1169626.pdf -# From Paul Eggert (2017-01-19): -# The above says the Magallanes change expires 2019-05-11 at 24:00, -# so in theory, they will revert to -04/-03 after that, which means -# they will switch from -03 to -04 one hour after Santiago does that day. -# For now, assume that they will not revert. # From Juan Correa (2018-08-13): # As of moments ago, the Ministry of Energy in Chile has announced the new @@ -1281,6 +1275,11 @@ # So we extend the new rules on Saturdays at 24:00 mainland time indefinitely. # From Juan Correa (2019-02-04): # http://www.diariooficial.interior.gob.cl/publicaciones/2018/11/23/42212/01/1498738.pdf +# From Paul Eggert (2019-09-01): +# The above says the Magallanes exception expires 2022-04-02 at 24:00, +# so in theory, they will revert to -04/-03 after that. +# For now, assume that they will not revert, +# since they have extended the expiration date once already. # Rule NAME FROM TO TYPE IN ON AT SAVE LETTER/S Rule Chile 1927 1931 - Sep 1 0:00 1:00 -
--- a/src/hotspot/cpu/aarch64/c1_FrameMap_aarch64.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/aarch64/c1_FrameMap_aarch64.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2010, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2019, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2014, Red Hat Inc. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * @@ -45,7 +45,7 @@ Register reg2 = r_2->as_Register(); assert(reg2 == reg, "must be same register"); opr = as_long_opr(reg); - } else if (type == T_OBJECT || type == T_ARRAY) { + } else if (is_reference_type(type)) { opr = as_oop_opr(reg); } else if (type == T_METADATA) { opr = as_metadata_opr(reg);
--- a/src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -728,7 +728,7 @@ move_regs(src->as_register(), dest->as_register()); } else if (dest->is_double_cpu()) { - if (src->type() == T_OBJECT || src->type() == T_ARRAY) { + if (is_reference_type(src->type())) { // Surprising to me but we can see move of a long to t_object __ verify_oop(src->as_register()); move_regs(src->as_register(), dest->as_register_lo()); @@ -756,7 +756,7 @@ void LIR_Assembler::reg2stack(LIR_Opr src, LIR_Opr dest, BasicType type, bool pop_fpu_stack) { if (src->is_single_cpu()) { - if (type == T_ARRAY || type == T_OBJECT) { + if (is_reference_type(type)) { __ str(src->as_register(), frame_map()->address_for_slot(dest->single_stack_ix())); __ verify_oop(src->as_register()); } else if (type == T_METADATA || type == T_DOUBLE) { @@ -794,7 +794,7 @@ return; } - if (type == T_ARRAY || type == T_OBJECT) { + if (is_reference_type(type)) { __ verify_oop(src->as_register()); if (UseCompressedOops && !wide) { @@ -869,7 +869,7 @@ assert(dest->is_register(), "should not call otherwise"); if (dest->is_single_cpu()) { - if (type == T_ARRAY || type == T_OBJECT) { + if (is_reference_type(type)) { __ ldr(dest->as_register(), frame_map()->address_for_slot(src->single_stack_ix())); __ verify_oop(dest->as_register()); } else if (type == T_METADATA) { @@ -1019,7 +1019,7 @@ ShouldNotReachHere(); } - if (type == T_ARRAY || type == T_OBJECT) { + if (is_reference_type(type)) { if (UseCompressedOops && !wide) { __ decode_heap_oop(dest->as_register()); } @@ -1227,8 +1227,8 @@ __ uxtw(len, len); if (UseSlowPath || - (!UseFastNewObjectArray && (op->type() == T_OBJECT || op->type() == T_ARRAY)) || - (!UseFastNewTypeArray && (op->type() != T_OBJECT && op->type() != T_ARRAY))) { + (!UseFastNewObjectArray && is_reference_type(op->type())) || + (!UseFastNewTypeArray && !is_reference_type(op->type()))) { __ b(*op->stub()->entry()); } else { Register tmp1 = op->tmp1()->as_register(); @@ -1948,10 +1948,10 @@ if (opr2->is_single_cpu()) { // cpu register - cpu register Register reg2 = opr2->as_register(); - if (opr1->type() == T_OBJECT || opr1->type() == T_ARRAY) { + if (is_reference_type(opr1->type())) { __ cmpoop(reg1, reg2); } else { - assert(opr2->type() != T_OBJECT && opr2->type() != T_ARRAY, "cmp int, oop?"); + assert(!is_reference_type(opr2->type()), "cmp int, oop?"); __ cmpw(reg1, reg2); } return; @@ -2243,7 +2243,7 @@ CodeStub* stub = op->stub(); int flags = op->flags(); BasicType basic_type = default_type != NULL ? default_type->element_type()->basic_type() : T_ILLEGAL; - if (basic_type == T_ARRAY) basic_type = T_OBJECT; + if (is_reference_type(basic_type)) basic_type = T_OBJECT; // if we don't know anything, just go through the generic arraycopy if (default_type == NULL // || basic_type == T_OBJECT @@ -3131,7 +3131,7 @@ void LIR_Assembler::atomic_op(LIR_Code code, LIR_Opr src, LIR_Opr data, LIR_Opr dest, LIR_Opr tmp_op) { Address addr = as_Address(src->as_address_ptr()); BasicType type = src->type(); - bool is_oop = type == T_OBJECT || type == T_ARRAY; + bool is_oop = is_reference_type(type); void (MacroAssembler::* add)(Register prev, RegisterOrConstant incr, Register addr); void (MacroAssembler::* xchg)(Register prev, Register newv, Register addr);
--- a/src/hotspot/cpu/aarch64/c1_LIRGenerator_aarch64.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/aarch64/c1_LIRGenerator_aarch64.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -733,7 +733,7 @@ new_value.load_item(); cmp_value.load_item(); LIR_Opr result = new_register(T_INT); - if (type == T_OBJECT || type == T_ARRAY) { + if (is_reference_type(type)) { __ cas_obj(addr, cmp_value.result(), new_value.result(), new_register(T_INT), new_register(T_INT), result); } else if (type == T_INT) { __ cas_int(addr->as_address_ptr()->base(), cmp_value.result(), new_value.result(), ill, ill); @@ -748,7 +748,7 @@ } LIR_Opr LIRGenerator::atomic_xchg(BasicType type, LIR_Opr addr, LIRItem& value) { - bool is_oop = type == T_OBJECT || type == T_ARRAY; + bool is_oop = is_reference_type(type); LIR_Opr result = new_register(type); value.load_item(); assert(type == T_INT || is_oop LP64_ONLY( || type == T_LONG ), "unexpected type");
--- a/src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -251,7 +251,7 @@ void G1BarrierSetAssembler::load_at(MacroAssembler* masm, DecoratorSet decorators, BasicType type, Register dst, Address src, Register tmp1, Register tmp_thread) { - bool on_oop = type == T_OBJECT || type == T_ARRAY; + bool on_oop = is_reference_type(type); bool on_weak = (decorators & ON_WEAK_OOP_REF) != 0; bool on_phantom = (decorators & ON_PHANTOM_OOP_REF) != 0; bool on_reference = on_weak || on_phantom;
--- a/src/hotspot/cpu/aarch64/gc/shared/modRefBarrierSetAssembler_aarch64.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/aarch64/gc/shared/modRefBarrierSetAssembler_aarch64.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -46,7 +46,7 @@ void ModRefBarrierSetAssembler::store_at(MacroAssembler* masm, DecoratorSet decorators, BasicType type, Address dst, Register val, Register tmp1, Register tmp2) { - if (type == T_OBJECT || type == T_ARRAY) { + if (is_reference_type(type)) { oop_store_at(masm, decorators, type, dst, val, tmp1, tmp2); } else { BarrierSetAssembler::store_at(masm, decorators, type, dst, val, tmp1, tmp2);
--- a/src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, Red Hat, Inc. All rights reserved. + * Copyright (c) 2018, 2019, Red Hat, Inc. All rights reserved. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as @@ -94,7 +94,7 @@ value_opr = storeval_barrier(access.gen(), value_opr, access.access_emit_info(), access.decorators()); } - assert(type == T_INT || type == T_OBJECT || type == T_ARRAY LP64_ONLY( || type == T_LONG ), "unexpected type"); + assert(type == T_INT || is_reference_type(type) LP64_ONLY( || type == T_LONG ), "unexpected type"); LIR_Opr tmp = gen->new_register(T_INT); __ xchg(access.resolved_addr(), value_opr, result, tmp);
--- a/src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -317,7 +317,7 @@ void ShenandoahBarrierSetAssembler::load_at(MacroAssembler* masm, DecoratorSet decorators, BasicType type, Register dst, Address src, Register tmp1, Register tmp_thread) { - bool on_oop = type == T_OBJECT || type == T_ARRAY; + bool on_oop = is_reference_type(type); bool not_in_heap = (decorators & IN_NATIVE) != 0; bool on_weak = (decorators & ON_WEAK_OOP_REF) != 0; bool on_phantom = (decorators & ON_PHANTOM_OOP_REF) != 0; @@ -352,7 +352,7 @@ void ShenandoahBarrierSetAssembler::store_at(MacroAssembler* masm, DecoratorSet decorators, BasicType type, Address dst, Register val, Register tmp1, Register tmp2) { - bool on_oop = type == T_OBJECT || type == T_ARRAY; + bool on_oop = is_reference_type(type); if (!on_oop) { BarrierSetAssembler::store_at(masm, decorators, type, dst, val, tmp1, tmp2); return;
--- a/src/hotspot/cpu/aarch64/gc/z/zBarrierSetAssembler_aarch64.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/aarch64/gc/z/zBarrierSetAssembler_aarch64.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -127,7 +127,7 @@ Register tmp1, Register tmp2) { // Verify value - if (type == T_OBJECT || type == T_ARRAY) { + if (is_reference_type(type)) { // Note that src could be noreg, which means we // are storing null and can skip verification. if (val != noreg) {
--- a/src/hotspot/cpu/aarch64/gc/z/zGlobals_aarch64.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/aarch64/gc/z/zGlobals_aarch64.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -135,26 +135,6 @@ // * 63-48 Fixed (16-bits, always zero) // -uintptr_t ZPlatformAddressSpaceStart() { - const uintptr_t first_heap_view_address = (uintptr_t)1 << (ZPlatformAddressMetadataShift() + 0); - const size_t min_address_offset = 0; - return first_heap_view_address + min_address_offset; -} - -uintptr_t ZPlatformAddressSpaceEnd() { - const uintptr_t last_heap_view_address = (uintptr_t)1 << (ZPlatformAddressMetadataShift() + 2); - const size_t max_address_offset = (size_t)1 << ZPlatformAddressOffsetBits(); - return last_heap_view_address + max_address_offset; -} - -uintptr_t ZPlatformAddressReservedStart() { - return ZPlatformAddressSpaceStart(); -} - -uintptr_t ZPlatformAddressReservedEnd() { - return ZPlatformAddressSpaceEnd(); -} - uintptr_t ZPlatformAddressBase() { return 0; }
--- a/src/hotspot/cpu/aarch64/gc/z/zGlobals_aarch64.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/aarch64/gc/z/zGlobals_aarch64.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -40,10 +40,6 @@ const size_t ZPlatformNMethodDisarmedOffset = 4; const size_t ZPlatformCacheLineSize = 64; -uintptr_t ZPlatformAddressSpaceStart(); -uintptr_t ZPlatformAddressSpaceEnd(); -uintptr_t ZPlatformAddressReservedStart(); -uintptr_t ZPlatformAddressReservedEnd(); uintptr_t ZPlatformAddressBase(); size_t ZPlatformAddressOffsetBits(); size_t ZPlatformAddressMetadataShift();
--- a/src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1952,7 +1952,7 @@ __ reset_last_Java_frame(false); // Unbox oop result, e.g. JNIHandles::resolve result. - if (ret_type == T_OBJECT || ret_type == T_ARRAY) { + if (is_reference_type(ret_type)) { __ resolve_jobject(r0, rthread, rscratch2); }
--- a/src/hotspot/cpu/sparc/c1_FrameMap_sparc.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/sparc/c1_FrameMap_sparc.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -51,7 +51,7 @@ } if (r_2->is_Register() && (type == T_LONG || type == T_DOUBLE)) { opr = as_long_opr(reg); - } else if (type == T_OBJECT || type == T_ARRAY) { + } else if (is_reference_type(type)) { opr = as_oop_opr(reg); } else if (type == T_METADATA) { opr = as_metadata_opr(reg);
--- a/src/hotspot/cpu/sparc/c1_LIRAssembler_sparc.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/sparc/c1_LIRAssembler_sparc.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2000, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2000, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -107,8 +107,8 @@ } if (UseCompressedOops) { - if (dst->is_address() && !dst->is_stack() && (dst->type() == T_OBJECT || dst->type() == T_ARRAY)) return false; - if (src->is_address() && !src->is_stack() && (src->type() == T_OBJECT || src->type() == T_ARRAY)) return false; + if (dst->is_address() && !dst->is_stack() && is_reference_type(dst->type())) return false; + if (src->is_address() && !src->is_stack() && is_reference_type(src->type())) return false; } if (UseCompressedClassPointers) { @@ -728,7 +728,7 @@ __ set(offset, O7); store_offset = store(from_reg, base, O7, type, wide); } else { - if (type == T_ARRAY || type == T_OBJECT) { + if (is_reference_type(type)) { __ verify_oop(from_reg->as_register()); } store_offset = code_offset(); @@ -789,7 +789,7 @@ int LIR_Assembler::store(LIR_Opr from_reg, Register base, Register disp, BasicType type, bool wide) { - if (type == T_ARRAY || type == T_OBJECT) { + if (is_reference_type(type)) { __ verify_oop(from_reg->as_register()); } int store_offset = code_offset(); @@ -889,7 +889,7 @@ } default : ShouldNotReachHere(); } - if (type == T_ARRAY || type == T_OBJECT) { + if (is_reference_type(type)) { __ verify_oop(to_reg->as_register()); } } @@ -924,7 +924,7 @@ break; default : ShouldNotReachHere(); } - if (type == T_ARRAY || type == T_OBJECT) { + if (is_reference_type(type)) { __ verify_oop(to_reg->as_register()); } return load_offset; @@ -1359,7 +1359,7 @@ } else { ShouldNotReachHere(); } - if (to_reg->type() == T_OBJECT || to_reg->type() == T_ARRAY) { + if (is_reference_type(to_reg->type())) { __ verify_oop(to_reg->as_register()); } } @@ -2295,8 +2295,8 @@ __ signx(op->len()->as_register()); if (UseSlowPath || - (!UseFastNewObjectArray && (op->type() == T_OBJECT || op->type() == T_ARRAY)) || - (!UseFastNewTypeArray && (op->type() != T_OBJECT && op->type() != T_ARRAY))) { + (!UseFastNewObjectArray && is_reference_type(op->type())) || + (!UseFastNewTypeArray && !is_reference_type(op->type()))) { __ br(Assembler::always, false, Assembler::pt, *op->stub()->entry()); __ delayed()->nop(); } else {
--- a/src/hotspot/cpu/sparc/c1_LIRGenerator_sparc.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/sparc/c1_LIRGenerator_sparc.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2005, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2005, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -568,7 +568,7 @@ LIR_Opr t2 = FrameMap::G3_opr; cmp_value.load_item(); new_value.load_item(); - if (type == T_OBJECT || type == T_ARRAY) { + if (is_reference_type(type)) { __ cas_obj(addr->as_address_ptr()->base(), cmp_value.result(), new_value.result(), t1, t2); } else if (type == T_INT) { __ cas_int(addr->as_address_ptr()->base(), cmp_value.result(), new_value.result(), t1, t2); @@ -583,7 +583,7 @@ } LIR_Opr LIRGenerator::atomic_xchg(BasicType type, LIR_Opr addr, LIRItem& value) { - bool is_obj = type == T_OBJECT || type == T_ARRAY; + bool is_obj = is_reference_type(type); LIR_Opr result = new_register(type); LIR_Opr tmp = LIR_OprFact::illegalOpr;
--- a/src/hotspot/cpu/sparc/gc/g1/g1BarrierSetAssembler_sparc.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/sparc/gc/g1/g1BarrierSetAssembler_sparc.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -450,7 +450,7 @@ void G1BarrierSetAssembler::load_at(MacroAssembler* masm, DecoratorSet decorators, BasicType type, Address src, Register dst, Register tmp) { - bool on_oop = type == T_OBJECT || type == T_ARRAY; + bool on_oop = is_reference_type(type); bool on_weak = (decorators & ON_WEAK_OOP_REF) != 0; bool on_phantom = (decorators & ON_PHANTOM_OOP_REF) != 0; bool on_reference = on_weak || on_phantom;
--- a/src/hotspot/cpu/sparc/gc/shared/modRefBarrierSetAssembler_sparc.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/sparc/gc/shared/modRefBarrierSetAssembler_sparc.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,7 +58,7 @@ void ModRefBarrierSetAssembler::store_at(MacroAssembler* masm, DecoratorSet decorators, BasicType type, Register val, Address dst, Register tmp) { - if (type == T_OBJECT || type == T_ARRAY) { + if (is_reference_type(type)) { oop_store_at(masm, decorators, type, val, dst, tmp); } else { BarrierSetAssembler::store_at(masm, decorators, type, val, dst, tmp);
--- a/src/hotspot/cpu/sparc/sharedRuntime_sparc.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/sparc/sharedRuntime_sparc.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -561,7 +561,7 @@ if (r_1->is_Register()) { Register r = r_1->as_Register()->after_restore(); - if (sig_bt[i] == T_OBJECT || sig_bt[i] == T_ARRAY) { + if (is_reference_type(sig_bt[i])) { store_c2i_object(r, base, st_off); } else if (sig_bt[i] == T_LONG || sig_bt[i] == T_DOUBLE) { store_c2i_long(r, base, st_off, r_2->is_stack()); @@ -1637,8 +1637,7 @@ Register temp_reg = G5_method; // not part of any compiled calling seq if (VerifyOops) { for (int i = 0; i < method->size_of_parameters(); i++) { - if (sig_bt[i] == T_OBJECT || - sig_bt[i] == T_ARRAY) { + if (is_reference_type(sig_bt[i])) { VMReg r = regs[i].first(); assert(r->is_valid(), "bad oop arg"); if (r->is_stack()) { @@ -2507,7 +2506,7 @@ __ reset_last_Java_frame(); // Unbox oop result, e.g. JNIHandles::resolve value in I0. - if (ret_type == T_OBJECT || ret_type == T_ARRAY) { + if (is_reference_type(ret_type)) { __ resolve_jobject(I0, G3_scratch); }
--- a/src/hotspot/cpu/x86/c1_FrameMap_x86.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/x86/c1_FrameMap_x86.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -50,7 +50,7 @@ #else opr = as_long_opr(reg2, reg); #endif // _LP64 - } else if (type == T_OBJECT || type == T_ARRAY) { + } else if (is_reference_type(type)) { opr = as_oop_opr(reg); } else if (type == T_METADATA) { opr = as_metadata_opr(reg);
--- a/src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2000, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2000, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -861,7 +861,7 @@ } else if (dest->is_double_cpu()) { #ifdef _LP64 - if (src->type() == T_OBJECT || src->type() == T_ARRAY) { + if (is_reference_type(src->type())) { // Surprising to me but we can see move of a long to t_object __ verify_oop(src->as_register()); move_regs(src->as_register(), dest->as_register_lo()); @@ -932,7 +932,7 @@ if (src->is_single_cpu()) { Address dst = frame_map()->address_for_slot(dest->single_stack_ix()); - if (type == T_OBJECT || type == T_ARRAY) { + if (is_reference_type(type)) { __ verify_oop(src->as_register()); __ movptr (dst, src->as_register()); } else if (type == T_METADATA) { @@ -978,7 +978,7 @@ PatchingStub* patch = NULL; Register compressed_src = rscratch1; - if (type == T_ARRAY || type == T_OBJECT) { + if (is_reference_type(type)) { __ verify_oop(src->as_register()); #ifdef _LP64 if (UseCompressedOops && !wide) { @@ -1113,7 +1113,7 @@ assert(dest->is_register(), "should not call otherwise"); if (dest->is_single_cpu()) { - if (type == T_ARRAY || type == T_OBJECT) { + if (is_reference_type(type)) { __ movptr(dest->as_register(), frame_map()->address_for_slot(src->single_stack_ix())); __ verify_oop(dest->as_register()); } else if (type == T_METADATA) { @@ -1154,7 +1154,7 @@ void LIR_Assembler::stack2stack(LIR_Opr src, LIR_Opr dest, BasicType type) { if (src->is_single_stack()) { - if (type == T_OBJECT || type == T_ARRAY) { + if (is_reference_type(type)) { __ pushptr(frame_map()->address_for_slot(src ->single_stack_ix())); __ popptr (frame_map()->address_for_slot(dest->single_stack_ix())); } else { @@ -1355,7 +1355,7 @@ patching_epilog(patch, patch_code, addr->base()->as_register(), info); } - if (type == T_ARRAY || type == T_OBJECT) { + if (is_reference_type(type)) { #ifdef _LP64 if (UseCompressedOops && !wide) { __ decode_heap_oop(dest->as_register()); @@ -1593,8 +1593,8 @@ LP64_ONLY( __ movslq(len, len); ) if (UseSlowPath || - (!UseFastNewObjectArray && (op->type() == T_OBJECT || op->type() == T_ARRAY)) || - (!UseFastNewTypeArray && (op->type() != T_OBJECT && op->type() != T_ARRAY))) { + (!UseFastNewObjectArray && is_reference_type(op->type())) || + (!UseFastNewTypeArray && !is_reference_type(op->type()))) { __ jmp(*op->stub()->entry()); } else { Register tmp1 = op->tmp1()->as_register(); @@ -2510,7 +2510,7 @@ } else { #ifdef _LP64 Register r_lo; - if (right->type() == T_OBJECT || right->type() == T_ARRAY) { + if (is_reference_type(right->type())) { r_lo = right->as_register(); } else { r_lo = right->as_register_lo(); @@ -2623,15 +2623,15 @@ Register reg1 = opr1->as_register(); if (opr2->is_single_cpu()) { // cpu register - cpu register - if (opr1->type() == T_OBJECT || opr1->type() == T_ARRAY) { + if (is_reference_type(opr1->type())) { __ cmpoop(reg1, opr2->as_register()); } else { - assert(opr2->type() != T_OBJECT && opr2->type() != T_ARRAY, "cmp int, oop?"); + assert(!is_reference_type(opr2->type()), "cmp int, oop?"); __ cmpl(reg1, opr2->as_register()); } } else if (opr2->is_stack()) { // cpu register - stack - if (opr1->type() == T_OBJECT || opr1->type() == T_ARRAY) { + if (is_reference_type(opr1->type())) { __ cmpoop(reg1, frame_map()->address_for_slot(opr2->single_stack_ix())); } else { __ cmpl(reg1, frame_map()->address_for_slot(opr2->single_stack_ix())); @@ -2641,7 +2641,7 @@ LIR_Const* c = opr2->as_constant_ptr(); if (c->type() == T_INT) { __ cmpl(reg1, c->as_jint()); - } else if (c->type() == T_OBJECT || c->type() == T_ARRAY) { + } else if (is_reference_type(c->type())) { // In 64bit oops are single register jobject o = c->as_jobject(); if (o == NULL) { @@ -2741,7 +2741,7 @@ } else if (opr1->is_address() && opr2->is_constant()) { LIR_Const* c = opr2->as_constant_ptr(); #ifdef _LP64 - if (c->type() == T_OBJECT || c->type() == T_ARRAY) { + if (is_reference_type(c->type())) { assert(condition == lir_cond_equal || condition == lir_cond_notEqual, "need to reverse"); __ movoop(rscratch1, c->as_jobject()); } @@ -2753,7 +2753,7 @@ LIR_Address* addr = opr1->as_address_ptr(); if (c->type() == T_INT) { __ cmpl(as_Address(addr), c->as_jint()); - } else if (c->type() == T_OBJECT || c->type() == T_ARRAY) { + } else if (is_reference_type(c->type())) { #ifdef _LP64 // %%% Make this explode if addr isn't reachable until we figure out a // better strategy by giving noreg as the temp for as_Address @@ -3052,7 +3052,7 @@ CodeStub* stub = op->stub(); int flags = op->flags(); BasicType basic_type = default_type != NULL ? default_type->element_type()->basic_type() : T_ILLEGAL; - if (basic_type == T_ARRAY) basic_type = T_OBJECT; + if (is_reference_type(basic_type)) basic_type = T_OBJECT; // if we don't know anything, just go through the generic arraycopy if (default_type == NULL) {
--- a/src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2005, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2005, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -671,7 +671,7 @@ LIR_Opr LIRGenerator::atomic_cmpxchg(BasicType type, LIR_Opr addr, LIRItem& cmp_value, LIRItem& new_value) { LIR_Opr ill = LIR_OprFact::illegalOpr; // for convenience - if (type == T_OBJECT || type == T_ARRAY) { + if (is_reference_type(type)) { cmp_value.load_item_force(FrameMap::rax_oop_opr); new_value.load_item(); __ cas_obj(addr->as_address_ptr()->base(), cmp_value.result(), new_value.result(), ill, ill); @@ -693,7 +693,7 @@ } LIR_Opr LIRGenerator::atomic_xchg(BasicType type, LIR_Opr addr, LIRItem& value) { - bool is_oop = type == T_OBJECT || type == T_ARRAY; + bool is_oop = is_reference_type(type); LIR_Opr result = new_register(type); value.load_item(); // Because we want a 2-arg form of xchg and xadd
--- a/src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -118,7 +118,7 @@ void G1BarrierSetAssembler::load_at(MacroAssembler* masm, DecoratorSet decorators, BasicType type, Register dst, Address src, Register tmp1, Register tmp_thread) { - bool on_oop = type == T_OBJECT || type == T_ARRAY; + bool on_oop = is_reference_type(type); bool on_weak = (decorators & ON_WEAK_OOP_REF) != 0; bool on_phantom = (decorators & ON_PHANTOM_OOP_REF) != 0; bool on_reference = on_weak || on_phantom;
--- a/src/hotspot/cpu/x86/gc/shared/modRefBarrierSetAssembler_x86.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/x86/gc/shared/modRefBarrierSetAssembler_x86.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -34,7 +34,7 @@ bool disjoint = (decorators & ARRAYCOPY_DISJOINT) != 0; bool obj_int = type == T_OBJECT LP64_ONLY(&& UseCompressedOops); - if (type == T_OBJECT || type == T_ARRAY) { + if (is_reference_type(type)) { #ifdef _LP64 if (!checkcast) { if (!obj_int) { @@ -61,7 +61,7 @@ bool obj_int = type == T_OBJECT LP64_ONLY(&& UseCompressedOops); Register tmp = rax; - if (type == T_OBJECT || type == T_ARRAY) { + if (is_reference_type(type)) { #ifdef _LP64 if (!checkcast) { if (!obj_int) { @@ -85,7 +85,7 @@ void ModRefBarrierSetAssembler::store_at(MacroAssembler* masm, DecoratorSet decorators, BasicType type, Address dst, Register val, Register tmp1, Register tmp2) { - if (type == T_OBJECT || type == T_ARRAY) { + if (is_reference_type(type)) { oop_store_at(masm, decorators, type, dst, val, tmp1, tmp2); } else { BarrierSetAssembler::store_at(masm, decorators, type, dst, val, tmp1, tmp2);
--- a/src/hotspot/cpu/x86/gc/shenandoah/c1/shenandoahBarrierSetC1_x86.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/x86/gc/shenandoah/c1/shenandoahBarrierSetC1_x86.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, Red Hat, Inc. All rights reserved. + * Copyright (c) 2018, 2019, Red Hat, Inc. All rights reserved. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as @@ -106,7 +106,7 @@ // Because we want a 2-arg form of xchg and xadd __ move(value_opr, result); - assert(type == T_INT || type == T_OBJECT || type == T_ARRAY LP64_ONLY( || type == T_LONG ), "unexpected type"); + assert(type == T_INT || is_reference_type(type) LP64_ONLY( || type == T_LONG ), "unexpected type"); __ xchg(access.resolved_addr(), result, result, LIR_OprFact::illegalOpr); if (access.is_oop()) {
--- a/src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -49,7 +49,7 @@ bool dest_uninitialized = (decorators & IS_DEST_UNINITIALIZED) != 0; - if (type == T_OBJECT || type == T_ARRAY) { + if (is_reference_type(type)) { if ((ShenandoahSATBBarrier && !dest_uninitialized) || ShenandoahLoadRefBarrier) { #ifdef _LP64 @@ -461,22 +461,18 @@ void ShenandoahBarrierSetAssembler::load_at(MacroAssembler* masm, DecoratorSet decorators, BasicType type, Register dst, Address src, Register tmp1, Register tmp_thread) { - bool on_oop = type == T_OBJECT || type == T_ARRAY; + bool on_oop = is_reference_type(type); bool on_weak = (decorators & ON_WEAK_OOP_REF) != 0; bool on_phantom = (decorators & ON_PHANTOM_OOP_REF) != 0; bool not_in_heap = (decorators & IN_NATIVE) != 0; bool on_reference = on_weak || on_phantom; - bool keep_alive = (decorators & AS_NO_KEEPALIVE) == 0; + bool is_traversal_mode = ShenandoahHeap::heap()->is_traversal_mode(); + bool keep_alive = ((decorators & AS_NO_KEEPALIVE) == 0) || is_traversal_mode; BarrierSetAssembler::load_at(masm, decorators, type, dst, src, tmp1, tmp_thread); if (on_oop) { - if (not_in_heap) { - if (ShenandoahHeap::heap()->is_traversal_mode()) { - load_reference_barrier(masm, dst); - keep_alive = true; - } else { - load_reference_barrier_native(masm, dst); - } + if (not_in_heap && !is_traversal_mode) { + load_reference_barrier_native(masm, dst); } else { load_reference_barrier(masm, dst); } @@ -501,7 +497,7 @@ void ShenandoahBarrierSetAssembler::store_at(MacroAssembler* masm, DecoratorSet decorators, BasicType type, Address dst, Register val, Register tmp1, Register tmp2) { - bool on_oop = type == T_OBJECT || type == T_ARRAY; + bool on_oop = is_reference_type(type); bool in_heap = (decorators & IN_HEAP) != 0; bool as_normal = (decorators & AS_NORMAL) != 0; if (on_oop && in_heap) {
--- a/src/hotspot/cpu/x86/gc/z/zBarrierSetAssembler_x86.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/x86/gc/z/zBarrierSetAssembler_x86.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -198,7 +198,7 @@ BLOCK_COMMENT("ZBarrierSetAssembler::store_at {"); // Verify oop store - if (type == T_OBJECT || type == T_ARRAY) { + if (is_reference_type(type)) { // Note that src could be noreg, which means we // are storing null and can skip verification. if (src != noreg) {
--- a/src/hotspot/cpu/x86/gc/z/zGlobals_x86.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/x86/gc/z/zGlobals_x86.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -135,26 +135,6 @@ // * 63-48 Fixed (16-bits, always zero) // -uintptr_t ZPlatformAddressSpaceStart() { - const uintptr_t first_heap_view_address = (uintptr_t)1 << (ZPlatformAddressMetadataShift() + 0); - const size_t min_address_offset = 0; - return first_heap_view_address + min_address_offset; -} - -uintptr_t ZPlatformAddressSpaceEnd() { - const uintptr_t last_heap_view_address = (uintptr_t)1 << (ZPlatformAddressMetadataShift() + 2); - const size_t max_address_offset = (size_t)1 << ZPlatformAddressOffsetBits(); - return last_heap_view_address + max_address_offset; -} - -uintptr_t ZPlatformAddressReservedStart() { - return ZPlatformAddressSpaceStart(); -} - -uintptr_t ZPlatformAddressReservedEnd() { - return ZPlatformAddressSpaceEnd(); -} - uintptr_t ZPlatformAddressBase() { return 0; }
--- a/src/hotspot/cpu/x86/gc/z/zGlobals_x86.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/x86/gc/z/zGlobals_x86.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -40,10 +40,6 @@ const size_t ZPlatformNMethodDisarmedOffset = 4; const size_t ZPlatformCacheLineSize = 64; -uintptr_t ZPlatformAddressSpaceStart(); -uintptr_t ZPlatformAddressSpaceEnd(); -uintptr_t ZPlatformAddressReservedStart(); -uintptr_t ZPlatformAddressReservedEnd(); uintptr_t ZPlatformAddressBase(); size_t ZPlatformAddressOffsetBits(); size_t ZPlatformAddressMetadataShift();
--- a/src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1416,8 +1416,7 @@ Register temp_reg = rbx; // not part of any compiled calling seq if (VerifyOops) { for (int i = 0; i < method->size_of_parameters(); i++) { - if (sig_bt[i] == T_OBJECT || - sig_bt[i] == T_ARRAY) { + if (is_reference_type(sig_bt[i])) { VMReg r = regs[i].first(); assert(r->is_valid(), "bad oop arg"); if (r->is_stack()) { @@ -2218,7 +2217,7 @@ __ reset_last_Java_frame(thread, false); // Unbox oop result, e.g. JNIHandles::resolve value. - if (ret_type == T_OBJECT || ret_type == T_ARRAY) { + if (is_reference_type(ret_type)) { __ resolve_jobject(rax /* value */, thread /* thread */, rcx /* tmp */);
--- a/src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1816,8 +1816,7 @@ Register temp_reg = rbx; // not part of any compiled calling seq if (VerifyOops) { for (int i = 0; i < method->size_of_parameters(); i++) { - if (sig_bt[i] == T_OBJECT || - sig_bt[i] == T_ARRAY) { + if (is_reference_type(sig_bt[i])) { VMReg r = regs[i].first(); assert(r->is_valid(), "bad oop arg"); if (r->is_stack()) { @@ -2717,7 +2716,7 @@ __ reset_last_Java_frame(false); // Unbox oop result, e.g. JNIHandles::resolve value. - if (ret_type == T_OBJECT || ret_type == T_ARRAY) { + if (is_reference_type(ret_type)) { __ resolve_jobject(rax /* value */, r15_thread /* thread */, rcx /* tmp */);
--- a/src/hotspot/os/aix/os_perf_aix.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/os/aix/os_perf_aix.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -445,9 +445,6 @@ bool CPUPerformanceInterface::CPUPerformance::initialize() { size_t array_entry_count = _counters.nProcs + 1; _counters.cpus = NEW_C_HEAP_ARRAY(CPUPerfTicks, array_entry_count, mtInternal); - if (NULL == _counters.cpus) { - return false; - } memset(_counters.cpus, 0, array_entry_count * sizeof(*_counters.cpus)); // For the CPU load total @@ -535,7 +532,7 @@ bool CPUPerformanceInterface::initialize() { _impl = new CPUPerformanceInterface::CPUPerformance(); - return NULL == _impl ? false : _impl->initialize(); + return _impl->initialize(); } CPUPerformanceInterface::~CPUPerformanceInterface() { @@ -688,19 +685,17 @@ } if (size > 0) { cmdline = NEW_C_HEAP_ARRAY(char, size + 1, mtInternal); - if (cmdline != NULL) { - cmdline[0] = '\0'; - if (fseek(fp, 0, SEEK_SET) == 0) { - if (fread(cmdline, 1, size, fp) == size) { - // the file has the arguments separated by '\0', - // so we translate '\0' to ' ' - for (size_t i = 0; i < size; i++) { - if (cmdline[i] == '\0') { - cmdline[i] = ' '; - } + cmdline[0] = '\0'; + if (fseek(fp, 0, SEEK_SET) == 0) { + if (fread(cmdline, 1, size, fp) == size) { + // the file has the arguments separated by '\0', + // so we translate '\0' to ' ' + for (size_t i = 0; i < size; i++) { + if (cmdline[i] == '\0') { + cmdline[i] = ' '; } - cmdline[size] = '\0'; } + cmdline[size] = '\0'; } } } @@ -790,7 +785,7 @@ bool SystemProcessInterface::SystemProcesses::initialize() { _iterator = new SystemProcessInterface::SystemProcesses::ProcessIterator(); - return NULL == _iterator ? false : _iterator->initialize(); + return _iterator->initialize(); } SystemProcessInterface::SystemProcesses::~SystemProcesses() { @@ -837,7 +832,7 @@ bool SystemProcessInterface::initialize() { _impl = new SystemProcessInterface::SystemProcesses(); - return NULL == _impl ? false : _impl->initialize(); + return _impl->initialize(); } SystemProcessInterface::~SystemProcessInterface() { @@ -852,15 +847,11 @@ bool CPUInformationInterface::initialize() { _cpu_info = new CPUInformation(); - if (NULL == _cpu_info) { - return false; - } _cpu_info->set_number_of_hardware_threads(VM_Version_Ext::number_of_threads()); _cpu_info->set_number_of_cores(VM_Version_Ext::number_of_cores()); _cpu_info->set_number_of_sockets(VM_Version_Ext::number_of_sockets()); _cpu_info->set_cpu_name(VM_Version_Ext::cpu_name()); _cpu_info->set_cpu_description(VM_Version_Ext::cpu_description()); - return true; } @@ -928,7 +919,7 @@ bool NetworkPerformanceInterface::initialize() { _impl = new NetworkPerformanceInterface::NetworkPerformance(); - return _impl != NULL && _impl->initialize(); + return _impl->initialize(); } int NetworkPerformanceInterface::network_utilization(NetworkInterface** network_interfaces) const {
--- a/src/hotspot/os/bsd/os_bsd.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/os/bsd/os_bsd.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -136,8 +136,6 @@ static sigset_t check_signal_done; static bool check_signals = true; -static pid_t _initial_pid = 0; - // Signal number used to suspend/resume a thread // do not use any signal number less than SIGSEGV, see 4355769 @@ -1124,24 +1122,7 @@ } int os::current_process_id() { - - // Under the old bsd thread library, bsd gives each thread - // its own process id. Because of this each thread will return - // a different pid if this method were to return the result - // of getpid(2). Bsd provides no api that returns the pid - // of the launcher thread for the vm. This implementation - // returns a unique pid, the pid of the launcher thread - // that starts the vm 'process'. - - // Under the NPTL, getpid() returns the same pid as the - // launcher thread rather than a unique pid per thread. - // Use gettid() if you want the old pre NPTL behaviour. - - // if you are looking for the result of a call to getpid() that - // returns a unique pid for the calling thread, then look at the - // OSThread::thread_id() method in osThread_bsd.hpp file - - return (int)(_initial_pid ? _initial_pid : getpid()); + return (int)(getpid()); } // DLL functions @@ -3087,16 +3068,6 @@ void os::init(void) { char dummy; // used to get a guess on initial stack address - // With BsdThreads the JavaMain thread pid (primordial thread) - // is different than the pid of the java launcher thread. - // So, on Bsd, the launcher thread pid is passed to the VM - // via the sun.java.launcher.pid property. - // Use this property instead of getpid() if it was correctly passed. - // See bug 6351349. - pid_t java_launcher_pid = (pid_t) Arguments::sun_java_launcher_pid(); - - _initial_pid = (java_launcher_pid > 0) ? java_launcher_pid : getpid(); - clock_tics_per_sec = CLK_TCK; init_random(1234567);
--- a/src/hotspot/os/bsd/os_perf_bsd.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/os/bsd/os_perf_bsd.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2012, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -234,7 +234,7 @@ bool CPUPerformanceInterface::initialize() { _impl = new CPUPerformanceInterface::CPUPerformance(); - return _impl != NULL && _impl->initialize(); + return _impl->initialize(); } CPUPerformanceInterface::~CPUPerformanceInterface() { @@ -355,7 +355,7 @@ bool SystemProcessInterface::initialize() { _impl = new SystemProcessInterface::SystemProcesses(); - return _impl != NULL && _impl->initialize(); + return _impl->initialize(); } SystemProcessInterface::~SystemProcessInterface() { @@ -370,16 +370,11 @@ bool CPUInformationInterface::initialize() { _cpu_info = new CPUInformation(); - - if (NULL == _cpu_info) { - return false; - } _cpu_info->set_number_of_hardware_threads(VM_Version_Ext::number_of_threads()); _cpu_info->set_number_of_cores(VM_Version_Ext::number_of_cores()); _cpu_info->set_number_of_sockets(VM_Version_Ext::number_of_sockets()); _cpu_info->set_cpu_name(VM_Version_Ext::cpu_name()); _cpu_info->set_cpu_description(VM_Version_Ext::cpu_description()); - return true; } @@ -483,7 +478,7 @@ bool NetworkPerformanceInterface::initialize() { _impl = new NetworkPerformanceInterface::NetworkPerformance(); - return _impl != NULL && _impl->initialize(); + return _impl->initialize(); } int NetworkPerformanceInterface::network_utilization(NetworkInterface** network_interfaces) const {
--- a/src/hotspot/os/linux/gc/z/zVirtualMemory_linux.cpp Mon Sep 23 17:18:03 2019 +0100 +++ /dev/null Thu Jan 01 00:00:00 1970 +0000 @@ -1,41 +0,0 @@ -/* - * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved. - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This code is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 only, as - * published by the Free Software Foundation. - * - * This code is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License - * version 2 for more details (a copy is included in the LICENSE file that - * accompanied this code). - * - * You should have received a copy of the GNU General Public License version - * 2 along with this work; if not, write to the Free Software Foundation, - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA - * or visit www.oracle.com if you need additional information or have any - * questions. - */ - -#include "precompiled.hpp" -#include "gc/z/zVirtualMemory.hpp" -#include "logging/log.hpp" - -#include <sys/mman.h> -#include <sys/types.h> - -bool ZVirtualMemoryManager::reserve(uintptr_t start, size_t size) { - // Reserve address space - const uintptr_t actual_start = (uintptr_t)mmap((void*)start, size, PROT_NONE, - MAP_ANONYMOUS|MAP_PRIVATE|MAP_NORESERVE, -1, 0); - if (actual_start != start) { - log_error(gc)("Failed to reserve address space for Java heap"); - return false; - } - - return true; -}
--- a/src/hotspot/os/linux/os_perf_linux.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/os/linux/os_perf_linux.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -505,9 +505,6 @@ bool CPUPerformanceInterface::CPUPerformance::initialize() { size_t array_entry_count = _counters.nProcs + 1; _counters.cpus = NEW_C_HEAP_ARRAY(os::Linux::CPUPerfTicks, array_entry_count, mtInternal); - if (NULL == _counters.cpus) { - return false; - } memset(_counters.cpus, 0, array_entry_count * sizeof(*_counters.cpus)); // For the CPU load total @@ -595,7 +592,7 @@ bool CPUPerformanceInterface::initialize() { _impl = new CPUPerformanceInterface::CPUPerformance(); - return NULL == _impl ? false : _impl->initialize(); + return _impl->initialize(); } CPUPerformanceInterface::~CPUPerformanceInterface() { @@ -748,19 +745,17 @@ } if (size > 0) { cmdline = NEW_C_HEAP_ARRAY(char, size + 1, mtInternal); - if (cmdline != NULL) { - cmdline[0] = '\0'; - if (fseek(fp, 0, SEEK_SET) == 0) { - if (fread(cmdline, 1, size, fp) == size) { - // the file has the arguments separated by '\0', - // so we translate '\0' to ' ' - for (size_t i = 0; i < size; i++) { - if (cmdline[i] == '\0') { - cmdline[i] = ' '; - } + cmdline[0] = '\0'; + if (fseek(fp, 0, SEEK_SET) == 0) { + if (fread(cmdline, 1, size, fp) == size) { + // the file has the arguments separated by '\0', + // so we translate '\0' to ' ' + for (size_t i = 0; i < size; i++) { + if (cmdline[i] == '\0') { + cmdline[i] = ' '; } - cmdline[size] = '\0'; } + cmdline[size] = '\0'; } } } @@ -854,7 +849,7 @@ bool SystemProcessInterface::SystemProcesses::initialize() { _iterator = new SystemProcessInterface::SystemProcesses::ProcessIterator(); - return NULL == _iterator ? false : _iterator->initialize(); + return _iterator->initialize(); } SystemProcessInterface::SystemProcesses::~SystemProcesses() { @@ -901,7 +896,7 @@ bool SystemProcessInterface::initialize() { _impl = new SystemProcessInterface::SystemProcesses(); - return NULL == _impl ? false : _impl->initialize(); + return _impl->initialize(); } SystemProcessInterface::~SystemProcessInterface() { @@ -916,15 +911,11 @@ bool CPUInformationInterface::initialize() { _cpu_info = new CPUInformation(); - if (NULL == _cpu_info) { - return false; - } _cpu_info->set_number_of_hardware_threads(VM_Version_Ext::number_of_threads()); _cpu_info->set_number_of_cores(VM_Version_Ext::number_of_cores()); _cpu_info->set_number_of_sockets(VM_Version_Ext::number_of_sockets()); _cpu_info->set_cpu_name(VM_Version_Ext::cpu_name()); _cpu_info->set_cpu_description(VM_Version_Ext::cpu_description()); - return true; } @@ -1038,7 +1029,7 @@ bool NetworkPerformanceInterface::initialize() { _impl = new NetworkPerformanceInterface::NetworkPerformance(); - return _impl != NULL && _impl->initialize(); + return _impl->initialize(); } int NetworkPerformanceInterface::network_utilization(NetworkInterface** network_interfaces) const {
--- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/src/hotspot/os/posix/gc/z/zVirtualMemory_posix.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -0,0 +1,81 @@ +/* + * Copyright (c) 2015, 2019, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +#include "precompiled.hpp" +#include "gc/z/zAddress.inline.hpp" +#include "gc/z/zVirtualMemory.hpp" +#include "logging/log.hpp" + +#include <sys/mman.h> +#include <sys/types.h> + +static void unmap(uintptr_t start, size_t size) { + const int res = munmap((void*)start, size); + assert(res == 0, "Failed to unmap memory"); +} + +static bool map(uintptr_t start, size_t size) { + const void* const res = mmap((void*)start, size, PROT_NONE, MAP_ANONYMOUS|MAP_PRIVATE|MAP_NORESERVE, -1, 0); + if (res == MAP_FAILED) { + // Failed to reserve memory + return false; + } + + if ((uintptr_t)res != start) { + // Failed to reserve memory at the requested address + unmap(start, size); + return false; + } + + // Success + return true; +} + +bool ZVirtualMemoryManager::reserve_platform(uintptr_t start, size_t size) { + // Reserve address views + const uintptr_t marked0 = ZAddress::marked0(start); + const uintptr_t marked1 = ZAddress::marked1(start); + const uintptr_t remapped = ZAddress::remapped(start); + + if (!map(marked0, size)) { + return false; + } + + if (!map(marked1, size)) { + unmap(marked0, size); + return false; + } + + if (!map(remapped, size)) { + unmap(marked0, size); + unmap(marked1, size); + return false; + } + + // Register address views with native memory tracker + nmt_reserve(marked0, size); + nmt_reserve(marked1, size); + nmt_reserve(remapped, size); + + return true; +}
--- a/src/hotspot/os/solaris/os_perf_solaris.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/os/solaris/os_perf_solaris.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -302,9 +302,6 @@ // Data structure(s) for saving CPU load (one per CPU) size_t array_entry_count = _counters.nProcs; _counters.jvmTicks = NEW_C_HEAP_ARRAY(CPUPerfTicks, array_entry_count, mtInternal); - if (NULL == _counters.jvmTicks) { - return false; - } memset(_counters.jvmTicks, 0, array_entry_count * sizeof(*_counters.jvmTicks)); // Get kstat cpu_stat counters for every CPU @@ -432,7 +429,7 @@ bool CPUPerformanceInterface::initialize() { _impl = new CPUPerformanceInterface::CPUPerformance(); - return _impl != NULL && _impl->initialize(); + return _impl->initialize(); } CPUPerformanceInterface::~CPUPerformanceInterface(void) { @@ -574,10 +571,8 @@ if (path_substring != NULL) { int len = path_substring - psinfo_data.pr_psargs; exe_path = NEW_C_HEAP_ARRAY(char, len+1, mtInternal); - if (exe_path != NULL) { - jio_snprintf(exe_path, len, "%s", psinfo_data.pr_psargs); - exe_path[len] = '\0'; - } + jio_snprintf(exe_path, len, "%s", psinfo_data.pr_psargs); + exe_path[len] = '\0'; } } @@ -642,7 +637,7 @@ bool SystemProcessInterface::SystemProcesses::initialize() { _iterator = new SystemProcessInterface::SystemProcesses::ProcessIterator(); - return _iterator != NULL && _iterator->initialize(); + return _iterator->initialize(); } SystemProcessInterface::SystemProcesses::~SystemProcesses() { @@ -689,7 +684,7 @@ bool SystemProcessInterface::initialize() { _impl = new SystemProcessInterface::SystemProcesses(); - return _impl != NULL && _impl->initialize(); + return _impl->initialize(); } @@ -705,9 +700,6 @@ bool CPUInformationInterface::initialize() { _cpu_info = new CPUInformation(); - if (_cpu_info == NULL) { - return false; - } _cpu_info->set_number_of_hardware_threads(VM_Version_Ext::number_of_threads()); _cpu_info->set_number_of_cores(VM_Version_Ext::number_of_cores()); _cpu_info->set_number_of_sockets(VM_Version_Ext::number_of_sockets()); @@ -820,7 +812,7 @@ bool NetworkPerformanceInterface::initialize() { _impl = new NetworkPerformanceInterface::NetworkPerformance(); - return _impl != NULL && _impl->initialize(); + return _impl->initialize(); } int NetworkPerformanceInterface::network_utilization(NetworkInterface** network_interfaces) const {
--- a/src/hotspot/os/windows/os_perf_windows.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/os/windows/os_perf_windows.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -194,34 +194,27 @@ return open_query(&query->query); } -static int allocate_counters(MultiCounterQueryP query, size_t nofCounters) { +static void allocate_counters(MultiCounterQueryP query, size_t nofCounters) { assert(query != NULL, "invariant"); assert(!query->initialized, "invariant"); assert(0 == query->noOfCounters, "invariant"); assert(query->counters == NULL, "invariant"); query->counters = NEW_C_HEAP_ARRAY(HCOUNTER, nofCounters, mtInternal); - if (query->counters == NULL) { - return OS_ERR; - } memset(query->counters, 0, nofCounters * sizeof(HCOUNTER)); query->noOfCounters = (int)nofCounters; - return OS_OK; } -static int allocate_counters(MultiCounterQuerySetP query_set, size_t nofCounters) { +static void allocate_counters(MultiCounterQuerySetP query_set, size_t nofCounters) { assert(query_set != NULL, "invariant"); assert(!query_set->initialized, "invariant"); for (int i = 0; i < query_set->size; ++i) { - if (allocate_counters(&query_set->queries[i], nofCounters) != OS_OK) { - return OS_ERR; - } + allocate_counters(&query_set->queries[i], nofCounters); } - return OS_OK; } -static int allocate_counters(ProcessQueryP process_query, size_t nofCounters) { +static void allocate_counters(ProcessQueryP process_query, size_t nofCounters) { assert(process_query != NULL, "invariant"); - return allocate_counters(&process_query->set, nofCounters); + allocate_counters(&process_query->set, nofCounters); } static void deallocate_counters(MultiCounterQueryP query) { @@ -600,7 +593,7 @@ static const char* copy_string_to_c_heap(const char* string) { assert(string != NULL, "invariant"); const size_t len = strlen(string); - char* const cheap_allocated_string = NEW_C_HEAP_ARRAY(char, len + 1, mtInternal); + char* const cheap_allocated_string = NEW_C_HEAP_ARRAY_RETURN_NULL(char, len + 1, mtInternal); if (NULL == cheap_allocated_string) { return NULL; } @@ -849,9 +842,7 @@ const int logical_cpu_count = number_of_logical_cpus(); assert(logical_cpu_count >= os::processor_count(), "invariant"); // we also add another counter for instance "_Total" - if (allocate_counters(cpu_query, logical_cpu_count + 1) != OS_OK) { - return OS_ERR; - } + allocate_counters(cpu_query, logical_cpu_count + 1); assert(cpu_query->noOfCounters == logical_cpu_count + 1, "invariant"); return initialize_cpu_query_counters(cpu_query, pdh_counter_idx); } @@ -1017,9 +1008,7 @@ if (_process_cpu_load == NULL) { return true; } - if (allocate_counters(_process_cpu_load, 2) != OS_OK) { - return true; - } + allocate_counters(_process_cpu_load, 2); if (initialize_process_counter(_process_cpu_load, 0, PDH_PROCESSOR_TIME_IDX) != OS_OK) { return true; } @@ -1057,7 +1046,7 @@ bool CPUPerformanceInterface::initialize() { _impl = new CPUPerformanceInterface::CPUPerformance(); - return _impl != NULL && _impl->initialize(); + return _impl->initialize(); } CPUPerformanceInterface::~CPUPerformanceInterface() { @@ -1263,7 +1252,7 @@ bool SystemProcessInterface::SystemProcesses::initialize() { _iterator = new SystemProcessInterface::SystemProcesses::ProcessIterator(); - return _iterator != NULL && _iterator->initialize(); + return _iterator->initialize(); } SystemProcessInterface::SystemProcesses::~SystemProcesses() { @@ -1318,7 +1307,7 @@ bool SystemProcessInterface::initialize() { _impl = new SystemProcessInterface::SystemProcesses(); - return _impl != NULL && _impl->initialize(); + return _impl->initialize(); } SystemProcessInterface::~SystemProcessInterface() { @@ -1333,9 +1322,6 @@ bool CPUInformationInterface::initialize() { _cpu_info = new CPUInformation(); - if (NULL == _cpu_info) { - return false; - } _cpu_info->set_number_of_hardware_threads(VM_Version_Ext::number_of_threads()); _cpu_info->set_number_of_cores(VM_Version_Ext::number_of_cores()); _cpu_info->set_number_of_sockets(VM_Version_Ext::number_of_sockets()); @@ -1431,7 +1417,7 @@ bool NetworkPerformanceInterface::initialize() { _impl = new NetworkPerformanceInterface::NetworkPerformance(); - return _impl != NULL && _impl->initialize(); + return _impl->initialize(); } int NetworkPerformanceInterface::network_utilization(NetworkInterface** network_interfaces) const {
--- a/src/hotspot/os/windows/os_windows.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/os/windows/os_windows.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -224,18 +224,12 @@ } home_path = NEW_C_HEAP_ARRAY(char, strlen(home_dir) + 1, mtInternal); - if (home_path == NULL) { - return; - } strcpy(home_path, home_dir); Arguments::set_java_home(home_path); FREE_C_HEAP_ARRAY(char, home_path); dll_path = NEW_C_HEAP_ARRAY(char, strlen(home_dir) + strlen(bin) + 1, mtInternal); - if (dll_path == NULL) { - return; - } strcpy(dll_path, home_dir); strcat(dll_path, bin); Arguments::set_dll_dir(dll_path);
--- a/src/hotspot/share/aot/aotCodeHeap.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/aot/aotCodeHeap.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -401,9 +401,6 @@ int len = Bytes::get_Java_u2((address)stub_name); stub_name += 2; char* full_name = NEW_C_HEAP_ARRAY(char, len+5, mtCode); - if (full_name == NULL) { // No memory? - break; - } memcpy(full_name, "AOT ", 4); memcpy(full_name+4, stub_name, len); full_name[len+4] = 0;
--- a/src/hotspot/share/aot/aotLoader.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/aot/aotLoader.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -151,17 +151,15 @@ if (AOTLibrary != NULL) { const int len = (int)strlen(AOTLibrary); char* cp = NEW_C_HEAP_ARRAY(char, len+1, mtCode); - if (cp != NULL) { // No memory? - memcpy(cp, AOTLibrary, len); - cp[len] = '\0'; - char* end = cp + len; - while (cp < end) { - const char* name = cp; - while ((*cp) != '\0' && (*cp) != '\n' && (*cp) != ',' && (*cp) != pathSep) cp++; - cp[0] = '\0'; // Terminate name - cp++; - load_library(name, true); - } + memcpy(cp, AOTLibrary, len); + cp[len] = '\0'; + char* end = cp + len; + while (cp < end) { + const char* name = cp; + while ((*cp) != '\0' && (*cp) != '\n' && (*cp) != ',' && (*cp) != pathSep) cp++; + cp[0] = '\0'; // Terminate name + cp++; + load_library(name, true); } }
--- a/src/hotspot/share/asm/codeBuffer.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/asm/codeBuffer.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1104,7 +1104,7 @@ // Convenience for add_comment. CodeString* CodeStrings::find_last(intptr_t offset) const { CodeString* a = _strings_last; - while (a != NULL && !a->is_comment() && a->offset() > offset) { + while (a != NULL && !(a->is_comment() && a->offset() == offset)) { a = a->_prev; } return a;
--- a/src/hotspot/share/c1/c1_GraphBuilder.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/c1/c1_GraphBuilder.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -3168,7 +3168,7 @@ ciType* type = sig->type_at(i); BasicType basic_type = type->basic_type(); // don't allow T_ARRAY to propagate into locals types - if (basic_type == T_ARRAY) basic_type = T_OBJECT; + if (is_reference_type(basic_type)) basic_type = T_OBJECT; ValueType* vt = as_ValueType(basic_type); state->store_local(idx, new Local(type, vt, idx, false)); idx += type->size();
--- a/src/hotspot/share/c1/c1_LIRGenerator.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/c1/c1_LIRGenerator.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1546,7 +1546,7 @@ assert(x->is_pinned(),""); bool needs_range_check = x->compute_needs_range_check(); bool use_length = x->length() != NULL; - bool obj_store = x->elt_type() == T_ARRAY || x->elt_type() == T_OBJECT; + bool obj_store = is_reference_type(x->elt_type()); bool needs_store_check = obj_store && (x->value()->as_Constant() == NULL || !get_jobject_constant(x->value())->is_null_object() || x->should_profile()); @@ -2163,7 +2163,7 @@ if (type == T_BOOLEAN) { decorators |= C1_MASK_BOOLEAN; } - if (type == T_ARRAY || type == T_OBJECT) { + if (is_reference_type(type)) { decorators |= ON_UNKNOWN_OOP_REF; } @@ -2190,7 +2190,7 @@ set_no_result(x); DecoratorSet decorators = IN_HEAP | C1_UNSAFE_ACCESS; - if (type == T_ARRAY || type == T_OBJECT) { + if (is_reference_type(type)) { decorators |= ON_UNKNOWN_OOP_REF; } if (x->is_volatile()) { @@ -2207,7 +2207,7 @@ DecoratorSet decorators = IN_HEAP | C1_UNSAFE_ACCESS | MO_SEQ_CST; - if (type == T_ARRAY || type == T_OBJECT) { + if (is_reference_type(type)) { decorators |= ON_UNKNOWN_OOP_REF; } @@ -2600,7 +2600,7 @@ LIR_Opr src = args->at(i); assert(!src->is_illegal(), "check"); BasicType t = src->type(); - if (t == T_OBJECT || t == T_ARRAY) { + if (is_reference_type(t)) { intptr_t profiled_k = parameters->type(j); Local* local = x->state()->local_at(java_index)->as_Local(); ciKlass* exact = profile_type(md, md->byte_offset_of_slot(parameters_type_data, ParametersTypeData::type_offset(0)),
--- a/src/hotspot/share/c1/c1_Optimizer.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/c1/c1_Optimizer.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -868,7 +868,7 @@ if (field->is_constant()) { ciConstant field_val = field->constant_value(); BasicType field_type = field_val.basic_type(); - if (field_type == T_OBJECT || field_type == T_ARRAY) { + if (is_reference_type(field_type)) { ciObject* obj_val = field_val.as_object(); if (!obj_val->is_null_object()) { if (PrintNullCheckElimination) {
--- a/src/hotspot/share/ci/bcEscapeAnalyzer.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/ci/bcEscapeAnalyzer.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2005, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2005, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -859,7 +859,7 @@ if (s.cur_bc() != Bytecodes::_getstatic) { set_method_escape(state.apop()); } - if (field_type == T_OBJECT || field_type == T_ARRAY) { + if (is_reference_type(field_type)) { state.apush(unknown_obj); } else if (type2size[field_type] == 1) { state.spush(); @@ -873,7 +873,7 @@ { bool will_link; ciField* field = s.get_field(will_link); BasicType field_type = field->type()->basic_type(); - if (field_type == T_OBJECT || field_type == T_ARRAY) { + if (is_reference_type(field_type)) { set_global_escape(state.apop()); } else if (type2size[field_type] == 1) { state.spop();
--- a/src/hotspot/share/ci/ciArray.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/ci/ciArray.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -37,7 +37,7 @@ // This class represents an arrayOop in the HotSpot virtual // machine. static BasicType fixup_element_type(BasicType bt) { - if (bt == T_ARRAY) return T_OBJECT; + if (is_reference_type(bt)) return T_OBJECT; if (bt == T_BOOLEAN) return T_BYTE; return bt; }
--- a/src/hotspot/share/ci/ciConstant.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/ci/ciConstant.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2014, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -56,12 +56,12 @@ case T_DOUBLE: tty->print("%lf", _value._double); break; - case T_OBJECT: - case T_ARRAY: - _value._object->print(); - break; default: - tty->print("ILLEGAL"); + if (is_reference_type(basic_type())) { + _value._object->print(); + } else { + tty->print("ILLEGAL"); + } break; } tty->print(">");
--- a/src/hotspot/share/ci/ciConstant.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/ci/ciConstant.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -106,7 +106,7 @@ return _value._double; } ciObject* as_object() const { - assert(basic_type() == T_OBJECT || basic_type() == T_ARRAY, "wrong type"); + assert(is_reference_type(basic_type()), "wrong type"); return _value._object; }
--- a/src/hotspot/share/ci/ciField.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/ci/ciField.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -90,7 +90,7 @@ // If the field is a pointer type, get the klass of the // field. - if (field_type == T_OBJECT || field_type == T_ARRAY) { + if (is_reference_type(field_type)) { bool ignore; // This is not really a class reference; the index always refers to the // field's type signature, as a symbol. Linkage checks do not apply. @@ -199,7 +199,7 @@ // If the field is a pointer type, get the klass of the // field. - if (field_type == T_OBJECT || field_type == T_ARRAY) { + if (is_reference_type(field_type)) { _type = NULL; // must call compute_type on first access } else { _type = ciType::make(field_type);
--- a/src/hotspot/share/ci/ciMethod.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/ci/ciMethod.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1454,8 +1454,8 @@ // ------------------------------------------------------------------ static BasicType erase_to_word_type(BasicType bt) { - if (is_subword_type(bt)) return T_INT; - if (bt == T_ARRAY) return T_OBJECT; + if (is_subword_type(bt)) return T_INT; + if (is_reference_type(bt)) return T_OBJECT; return bt; }
--- a/src/hotspot/share/ci/ciObjectFactory.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/ci/ciObjectFactory.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -149,7 +149,8 @@ for (int i = T_BOOLEAN; i <= T_CONFLICT; i++) { BasicType t = (BasicType)i; - if (type2name(t) != NULL && t != T_OBJECT && t != T_ARRAY && t != T_NARROWOOP && t != T_NARROWKLASS) { + if (type2name(t) != NULL && !is_reference_type(t) && + t != T_NARROWOOP && t != T_NARROWKLASS) { ciType::_basic_types[t] = new (_arena) ciType(t); init_ident_of(ciType::_basic_types[t]); }
--- a/src/hotspot/share/ci/ciType.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/ci/ciType.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2000, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2000, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -35,8 +35,7 @@ // ciType // -// This class represents either a class (T_OBJECT), array (T_ARRAY), -// or one of the primitive types such as T_INT. +// This class represents a Java reference or primitive type. // ------------------------------------------------------------------ // ciType::ciType
--- a/src/hotspot/share/ci/ciType.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/ci/ciType.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -29,8 +29,8 @@ // ciType // -// This class represents either a class (T_OBJECT), array (T_ARRAY), -// or one of the primitive types such as T_INT. +// This class represents a Java reference or primitive type. + class ciType : public ciMetadata { CI_PACKAGE_ACCESS friend class ciKlass; @@ -67,7 +67,7 @@ ciKlass* box_klass(); // Returns true if this is not a klass or array (i.e., not a reference type). - bool is_primitive_type() const { return basic_type() != T_OBJECT && basic_type() != T_ARRAY; } + bool is_primitive_type() const { return !is_reference_type(basic_type()); } int size() const { return type2size[basic_type()]; } bool is_void() const { return basic_type() == T_VOID; } bool is_one_word() const { return size() == 1; }
--- a/src/hotspot/share/ci/ciTypeFlow.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/ci/ciTypeFlow.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -729,7 +729,7 @@ outer()->record_failure("ldc did not link"); return; } - if (basic_type == T_OBJECT || basic_type == T_ARRAY) { + if (is_reference_type(basic_type)) { ciObject* obj = con.as_object(); if (obj->is_null_object()) { push_null();
--- a/src/hotspot/share/classfile/bytecodeAssembler.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/classfile/bytecodeAssembler.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2012, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -187,9 +187,11 @@ case T_FLOAT: fload(index); break; case T_DOUBLE: dload(index); break; case T_LONG: lload(index); break; - case T_OBJECT: - case T_ARRAY: aload(index); break; default: + if (is_reference_type(bt)) { + aload(index); + break; + } ShouldNotReachHere(); } } @@ -254,10 +256,12 @@ case T_FLOAT: freturn(); break; case T_DOUBLE: dreturn(); break; case T_LONG: lreturn(); break; - case T_OBJECT: - case T_ARRAY: areturn(); break; case T_VOID: _return(); break; default: + if (is_reference_type(bt)) { + areturn(); + break; + } ShouldNotReachHere(); } }
--- a/src/hotspot/share/classfile/classLoaderDataGraph.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/classfile/classLoaderDataGraph.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -285,17 +285,27 @@ } } -// Closure for locking and iterating through classes. -LockedClassesDo::LockedClassesDo(classes_do_func_t f) : _function(f) { - ClassLoaderDataGraph_lock->lock(); +// Closure for locking and iterating through classes. Only lock outside of safepoint. +LockedClassesDo::LockedClassesDo(classes_do_func_t f) : _function(f), + _do_lock(!SafepointSynchronize::is_at_safepoint()) { + if (_do_lock) { + ClassLoaderDataGraph_lock->lock(); + } } -LockedClassesDo::LockedClassesDo() : _function(NULL) { +LockedClassesDo::LockedClassesDo() : _function(NULL), + _do_lock(!SafepointSynchronize::is_at_safepoint()) { // callers provide their own do_klass - ClassLoaderDataGraph_lock->lock(); + if (_do_lock) { + ClassLoaderDataGraph_lock->lock(); + } } -LockedClassesDo::~LockedClassesDo() { ClassLoaderDataGraph_lock->unlock(); } +LockedClassesDo::~LockedClassesDo() { + if (_do_lock) { + ClassLoaderDataGraph_lock->unlock(); + } +} // Iterating over the CLDG needs to be locked because
--- a/src/hotspot/share/classfile/classLoaderDataGraph.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/classfile/classLoaderDataGraph.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -156,6 +156,7 @@ class LockedClassesDo : public KlassClosure { typedef void (*classes_do_func_t)(Klass*); classes_do_func_t _function; + bool _do_lock; public: LockedClassesDo(); // For callers who provide their own do_klass LockedClassesDo(classes_do_func_t function);
--- a/src/hotspot/share/gc/g1/g1CollectedHeap.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/g1/g1CollectedHeap.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -132,7 +132,7 @@ RedirtyLoggedCardTableEntryClosure(G1CollectedHeap* g1h) : G1CardTableEntryClosure(), _num_dirtied(0), _g1h(g1h), _g1_ct(g1h->card_table()) { } - void do_card_ptr(CardValue* card_ptr, uint worker_i) { + void do_card_ptr(CardValue* card_ptr, uint worker_id) { HeapRegion* hr = region_for_card(card_ptr); // Should only dirty cards in regions that won't be freed. @@ -1938,8 +1938,8 @@ return _hrm->total_free_bytes(); } -void G1CollectedHeap::iterate_hcc_closure(G1CardTableEntryClosure* cl, uint worker_i) { - _hot_card_cache->drain(cl, worker_i); +void G1CollectedHeap::iterate_hcc_closure(G1CardTableEntryClosure* cl, uint worker_id) { + _hot_card_cache->drain(cl, worker_id); } // Computes the sum of the storage used by the various regions.
--- a/src/hotspot/share/gc/g1/g1CollectedHeap.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/g1/g1CollectedHeap.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -991,7 +991,7 @@ void scrub_rem_set(); // Apply the given closure on all cards in the Hot Card Cache, emptying it. - void iterate_hcc_closure(G1CardTableEntryClosure* cl, uint worker_i); + void iterate_hcc_closure(G1CardTableEntryClosure* cl, uint worker_id); // The shared block offset table array. G1BlockOffsetTable* bot() const { return _bot; }
--- a/src/hotspot/share/gc/g1/g1ConcurrentRefine.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/g1/g1ConcurrentRefine.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -198,10 +198,10 @@ static Thresholds calc_thresholds(size_t green_zone, size_t yellow_zone, - uint worker_i) { + uint worker_id) { double yellow_size = yellow_zone - green_zone; double step = yellow_size / G1ConcurrentRefine::max_num_threads(); - if (worker_i == 0) { + if (worker_id == 0) { // Potentially activate worker 0 more aggressively, to keep // available buffers near green_zone value. When yellow_size is // large we don't want to allow a full step to accumulate before @@ -209,8 +209,8 @@ // than green_zone buffers to be processed during scanning. step = MIN2(step, ParallelGCThreads / 2.0); } - size_t activate_offset = static_cast<size_t>(ceil(step * (worker_i + 1))); - size_t deactivate_offset = static_cast<size_t>(floor(step * worker_i)); + size_t activate_offset = static_cast<size_t>(ceil(step * (worker_id + 1))); + size_t deactivate_offset = static_cast<size_t>(floor(step * worker_id)); return Thresholds(green_zone + activate_offset, green_zone + deactivate_offset); }
--- a/src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -158,7 +158,7 @@ // Stops processing a buffer if SuspendibleThreadSet::should_yield(), // returning the incompletely processed buffer to the completed buffer // list, for later processing of the remainder. - bool refine_completed_buffer_concurrently(uint worker_i, size_t stop_at); + bool refine_completed_buffer_concurrently(uint worker_id, size_t stop_at); // If a full collection is happening, reset partial logs, and release // completed ones: the full collection will make them all irrelevant.
--- a/src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -62,8 +62,7 @@ _gc_par_phases[JVMTIRoots] = new WorkerDataArray<double>(max_gc_threads, "JVMTI Roots (ms):"); AOT_ONLY(_gc_par_phases[AOTCodeRoots] = new WorkerDataArray<double>(max_gc_threads, "AOT Root Scan (ms):");) _gc_par_phases[CMRefRoots] = new WorkerDataArray<double>(max_gc_threads, "CM RefProcessor Roots (ms):"); - _gc_par_phases[WaitForStrongCLD] = new WorkerDataArray<double>(max_gc_threads, "Wait For Strong CLD (ms):"); - _gc_par_phases[WeakCLDRoots] = new WorkerDataArray<double>(max_gc_threads, "Weak CLD Roots (ms):"); + _gc_par_phases[WaitForStrongRoots] = new WorkerDataArray<double>(max_gc_threads, "Wait For Strong Roots (ms):"); _gc_par_phases[MergeER] = new WorkerDataArray<double>(max_gc_threads, "Eager Reclaim (ms):"); @@ -273,37 +272,37 @@ #undef ASSERT_PHASE_UNINITIALIZED // record the time a phase took in seconds -void G1GCPhaseTimes::record_time_secs(GCParPhases phase, uint worker_i, double secs) { - _gc_par_phases[phase]->set(worker_i, secs); +void G1GCPhaseTimes::record_time_secs(GCParPhases phase, uint worker_id, double secs) { + _gc_par_phases[phase]->set(worker_id, secs); } // add a number of seconds to a phase -void G1GCPhaseTimes::add_time_secs(GCParPhases phase, uint worker_i, double secs) { - _gc_par_phases[phase]->add(worker_i, secs); +void G1GCPhaseTimes::add_time_secs(GCParPhases phase, uint worker_id, double secs) { + _gc_par_phases[phase]->add(worker_id, secs); } -void G1GCPhaseTimes::record_or_add_time_secs(GCParPhases phase, uint worker_i, double secs) { - if (_gc_par_phases[phase]->get(worker_i) == _gc_par_phases[phase]->uninitialized()) { - record_time_secs(phase, worker_i, secs); +void G1GCPhaseTimes::record_or_add_time_secs(GCParPhases phase, uint worker_id, double secs) { + if (_gc_par_phases[phase]->get(worker_id) == _gc_par_phases[phase]->uninitialized()) { + record_time_secs(phase, worker_id, secs); } else { - add_time_secs(phase, worker_i, secs); + add_time_secs(phase, worker_id, secs); } } -double G1GCPhaseTimes::get_time_secs(GCParPhases phase, uint worker_i) { - return _gc_par_phases[phase]->get(worker_i); +double G1GCPhaseTimes::get_time_secs(GCParPhases phase, uint worker_id) { + return _gc_par_phases[phase]->get(worker_id); } -void G1GCPhaseTimes::record_thread_work_item(GCParPhases phase, uint worker_i, size_t count, uint index) { - _gc_par_phases[phase]->set_thread_work_item(worker_i, count, index); +void G1GCPhaseTimes::record_thread_work_item(GCParPhases phase, uint worker_id, size_t count, uint index) { + _gc_par_phases[phase]->set_thread_work_item(worker_id, count, index); } -void G1GCPhaseTimes::record_or_add_thread_work_item(GCParPhases phase, uint worker_i, size_t count, uint index) { - _gc_par_phases[phase]->set_or_add_thread_work_item(worker_i, count, index); +void G1GCPhaseTimes::record_or_add_thread_work_item(GCParPhases phase, uint worker_id, size_t count, uint index) { + _gc_par_phases[phase]->set_or_add_thread_work_item(worker_id, count, index); } -size_t G1GCPhaseTimes::get_thread_work_item(GCParPhases phase, uint worker_i, uint index) { - return _gc_par_phases[phase]->get_thread_work_item(worker_i, index); +size_t G1GCPhaseTimes::get_thread_work_item(GCParPhases phase, uint worker_id, uint index) { + return _gc_par_phases[phase]->get_thread_work_item(worker_id, index); } // return the average time for a phase in milliseconds @@ -567,8 +566,7 @@ "JVMTIRoots", AOT_ONLY("AOTCodeRoots" COMMA) "CMRefRoots", - "WaitForStrongCLD", - "WeakCLDRoots", + "WaitForStrongRoots", "MergeER", "MergeRS", "OptMergeRS",
--- a/src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -57,8 +57,7 @@ JVMTIRoots, AOT_ONLY(AOTCodeRoots COMMA) CMRefRoots, - WaitForStrongCLD, - WeakCLDRoots, + WaitForStrongRoots, MergeER, MergeRS, OptMergeRS, @@ -84,7 +83,7 @@ }; static const GCParPhases ExtRootScanSubPhasesFirst = ThreadRoots; - static const GCParPhases ExtRootScanSubPhasesLast = WeakCLDRoots; + static const GCParPhases ExtRootScanSubPhasesLast = WaitForStrongRoots; enum GCMergeRSWorkTimes { MergeRSMergedSparse, @@ -251,20 +250,20 @@ static const char* phase_name(GCParPhases phase); // record the time a phase took in seconds - void record_time_secs(GCParPhases phase, uint worker_i, double secs); + void record_time_secs(GCParPhases phase, uint worker_id, double secs); // add a number of seconds to a phase - void add_time_secs(GCParPhases phase, uint worker_i, double secs); + void add_time_secs(GCParPhases phase, uint worker_id, double secs); - void record_or_add_time_secs(GCParPhases phase, uint worker_i, double secs); + void record_or_add_time_secs(GCParPhases phase, uint worker_id, double secs); - double get_time_secs(GCParPhases phase, uint worker_i); + double get_time_secs(GCParPhases phase, uint worker_id); - void record_thread_work_item(GCParPhases phase, uint worker_i, size_t count, uint index = 0); + void record_thread_work_item(GCParPhases phase, uint worker_id, size_t count, uint index = 0); - void record_or_add_thread_work_item(GCParPhases phase, uint worker_i, size_t count, uint index = 0); + void record_or_add_thread_work_item(GCParPhases phase, uint worker_id, size_t count, uint index = 0); - size_t get_thread_work_item(GCParPhases phase, uint worker_i, uint index = 0); + size_t get_thread_work_item(GCParPhases phase, uint worker_id, uint index = 0); // return the average time for a phase in milliseconds double average_time_ms(GCParPhases phase);
--- a/src/hotspot/share/gc/g1/g1HotCardCache.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/g1/g1HotCardCache.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -84,7 +84,7 @@ return (previous_ptr == current_ptr) ? previous_ptr : card_ptr; } -void G1HotCardCache::drain(G1CardTableEntryClosure* cl, uint worker_i) { +void G1HotCardCache::drain(G1CardTableEntryClosure* cl, uint worker_id) { assert(default_use_cache(), "Drain only necessary if we use the hot card cache."); assert(_hot_cache != NULL, "Logic"); @@ -99,7 +99,7 @@ for (size_t i = start_idx; i < end_idx; i++) { CardValue* card_ptr = _hot_cache[i]; if (card_ptr != NULL) { - cl->do_card_ptr(card_ptr, worker_i); + cl->do_card_ptr(card_ptr, worker_id); } else { break; }
--- a/src/hotspot/share/gc/g1/g1HotCardCache.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/g1/g1HotCardCache.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -113,7 +113,7 @@ // Refine the cards that have delayed as a result of // being in the cache. - void drain(G1CardTableEntryClosure* cl, uint worker_i); + void drain(G1CardTableEntryClosure* cl, uint worker_id); // Set up for parallel processing of the cards in the hot cache void reset_hot_cache_claimed_index() {
--- a/src/hotspot/share/gc/g1/g1OopClosures.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/g1/g1OopClosures.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -43,16 +43,14 @@ void G1CLDScanClosure::do_cld(ClassLoaderData* cld) { // If the class loader data has not been dirtied we know that there's - // no references into the young gen and we can skip it. + // no references into the young gen and we can skip it. if (!_process_only_dirty || cld->has_modified_oops()) { // Tell the closure that this class loader data is the CLD to scavenge // and is the one to dirty if oops are left pointing into the young gen. _closure->set_scanned_cld(cld); - - // Clean the cld since we're going to scavenge all the metadata. - // Clear modified oops only if this cld is claimed. - cld->oops_do(_closure, _claim, /*clear_modified_oops*/true); + // Clean modified oops since we're going to scavenge all the metadata. + cld->oops_do(_closure, ClassLoaderData::_claim_none, true /*clear_modified_oops*/); _closure->set_scanned_cld(NULL);
--- a/src/hotspot/share/gc/g1/g1OopClosures.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/g1/g1OopClosures.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -175,12 +175,10 @@ class G1CLDScanClosure : public CLDClosure { G1ParCopyHelper* _closure; bool _process_only_dirty; - int _claim; int _count; public: - G1CLDScanClosure(G1ParCopyHelper* closure, - bool process_only_dirty, int claim_value) - : _closure(closure), _process_only_dirty(process_only_dirty), _claim(claim_value), _count(0) {} + G1CLDScanClosure(G1ParCopyHelper* closure, bool process_only_dirty) + : _closure(closure), _process_only_dirty(process_only_dirty), _count(0) {} void do_cld(ClassLoaderData* cld); }; @@ -211,12 +209,12 @@ class G1ConcurrentRefineOopClosure: public BasicOopIterateClosure { G1CollectedHeap* _g1h; - uint _worker_i; + uint _worker_id; public: - G1ConcurrentRefineOopClosure(G1CollectedHeap* g1h, uint worker_i) : + G1ConcurrentRefineOopClosure(G1CollectedHeap* g1h, uint worker_id) : _g1h(g1h), - _worker_i(worker_i) { + _worker_id(worker_id) { } virtual ReferenceIterationMode reference_iteration_mode() { return DO_FIELDS; }
--- a/src/hotspot/share/gc/g1/g1OopClosures.inline.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/g1/g1OopClosures.inline.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -156,7 +156,7 @@ assert(to_rem_set != NULL, "Need per-region 'into' remsets."); if (to_rem_set->is_tracked()) { - to_rem_set->add_reference(p, _worker_i); + to_rem_set->add_reference(p, _worker_id); } }
--- a/src/hotspot/share/gc/g1/g1RemSet.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/g1/g1RemSet.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -830,7 +830,7 @@ G1ScanCardClosure scan_cl(G1CollectedHeap::heap(), _pss); G1ScanRSForOptionalClosure cl(G1CollectedHeap::heap(), &scan_cl); - _opt_refs_scanned += opt_rem_set_list->oops_do(&cl, _pss->closures()->raw_strong_oops()); + _opt_refs_scanned += opt_rem_set_list->oops_do(&cl, _pss->closures()->strong_oops()); _opt_refs_memory_used += opt_rem_set_list->used_memory(); event.commit(GCId::current(), _worker_id, G1GCPhaseTimes::phase_name(_scan_phase)); @@ -839,14 +839,14 @@ public: G1ScanCollectionSetRegionClosure(G1RemSetScanState* scan_state, G1ParScanThreadState* pss, - uint worker_i, + uint worker_id, G1GCPhaseTimes::GCParPhases scan_phase, G1GCPhaseTimes::GCParPhases code_roots_phase) : _pss(pss), _scan_state(scan_state), _scan_phase(scan_phase), _code_roots_phase(code_roots_phase), - _worker_id(worker_i), + _worker_id(worker_id), _opt_refs_scanned(0), _opt_refs_memory_used(0), _strong_code_root_scan_time(), @@ -1061,7 +1061,7 @@ _scan_state(scan_state), _ct(g1h->card_table()), _cards_dirty(0), _cards_skipped(0) {} - void do_card_ptr(CardValue* card_ptr, uint worker_i) { + void do_card_ptr(CardValue* card_ptr, uint worker_id) { // The only time we care about recording cards that // contain references that point into the collection set // is during RSet updating within an evacuation pause. @@ -1263,7 +1263,7 @@ } void G1RemSet::refine_card_concurrently(CardValue* card_ptr, - uint worker_i) { + uint worker_id) { assert(!_g1h->is_gc_active(), "Only call concurrently"); // Construct the region representing the card. @@ -1375,7 +1375,7 @@ MemRegion dirty_region(start, MIN2(scan_limit, end)); assert(!dirty_region.is_empty(), "sanity"); - G1ConcurrentRefineOopClosure conc_refine_cl(_g1h, worker_i); + G1ConcurrentRefineOopClosure conc_refine_cl(_g1h, worker_id); if (r->oops_on_memregion_seq_iterate_careful<false>(dirty_region, &conc_refine_cl) != NULL) { _num_conc_refined_cards++; // Unsynchronized update, only used for logging. return;
--- a/src/hotspot/share/gc/g1/g1RemSet.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/g1/g1RemSet.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -117,7 +117,7 @@ // Refine the card corresponding to "card_ptr". Safe to be called concurrently // to the mutator. void refine_card_concurrently(CardValue* card_ptr, - uint worker_i); + uint worker_id); // Print accumulated summary info from the start of the VM. void print_summary_info();
--- a/src/hotspot/share/gc/g1/g1RootClosures.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/g1/g1RootClosures.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -35,20 +35,17 @@ G1EvacuationClosures(G1CollectedHeap* g1h, G1ParScanThreadState* pss, bool in_young_gc) : - _closures(g1h, pss, in_young_gc, /* cld_claim */ ClassLoaderData::_claim_none) {} + _closures(g1h, pss, in_young_gc) {} OopClosure* weak_oops() { return &_closures._oops; } OopClosure* strong_oops() { return &_closures._oops; } CLDClosure* weak_clds() { return &_closures._clds; } CLDClosure* strong_clds() { return &_closures._clds; } - CLDClosure* second_pass_weak_clds() { return NULL; } CodeBlobClosure* strong_codeblobs() { return &_closures._codeblobs; } CodeBlobClosure* weak_codeblobs() { return &_closures._codeblobs; } - OopClosure* raw_strong_oops() { return &_closures._oops; } - bool trace_metadata() { return false; } }; @@ -60,38 +57,21 @@ G1SharedClosures<G1MarkFromRoot> _strong; G1SharedClosures<MarkWeak> _weak; - // Filter method to help with returning the appropriate closures - // depending on the class template parameter. - template <G1Mark Mark, typename T> - T* null_if(T* t) { - if (Mark == MarkWeak) { - return NULL; - } - return t; - } - public: G1InitialMarkClosures(G1CollectedHeap* g1h, G1ParScanThreadState* pss) : - _strong(g1h, pss, /* process_only_dirty_klasses */ false, /* cld_claim */ ClassLoaderData::_claim_strong), - _weak(g1h, pss, /* process_only_dirty_klasses */ false, /* cld_claim */ ClassLoaderData::_claim_strong) {} + _strong(g1h, pss, /* process_only_dirty_klasses */ false), + _weak(g1h, pss, /* process_only_dirty_klasses */ false) {} OopClosure* weak_oops() { return &_weak._oops; } OopClosure* strong_oops() { return &_strong._oops; } - // If MarkWeak is G1MarkPromotedFromRoot then the weak CLDs must be processed in a second pass. - CLDClosure* weak_clds() { return null_if<G1MarkPromotedFromRoot>(&_weak._clds); } + CLDClosure* weak_clds() { return &_weak._clds; } CLDClosure* strong_clds() { return &_strong._clds; } - // If MarkWeak is G1MarkFromRoot then all CLDs are processed by the weak and strong variants - // return a NULL closure for the following specialized versions in that case. - CLDClosure* second_pass_weak_clds() { return null_if<G1MarkFromRoot>(&_weak._clds); } - CodeBlobClosure* strong_codeblobs() { return &_strong._codeblobs; } CodeBlobClosure* weak_codeblobs() { return &_weak._codeblobs; } - OopClosure* raw_strong_oops() { return &_strong._oops; } - // If we are not marking all weak roots then we are tracing // which metadata is alive. bool trace_metadata() { return MarkWeak == G1MarkPromotedFromRoot; }
--- a/src/hotspot/share/gc/g1/g1RootClosures.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/g1/g1RootClosures.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -49,13 +49,6 @@ class G1EvacuationRootClosures : public G1RootClosures { public: - // Applied to the weakly reachable CLDs when all strongly reachable - // CLDs are guaranteed to have been processed. - virtual CLDClosure* second_pass_weak_clds() = 0; - - // Get a raw oop closure for processing oops, bypassing the flushing above. - virtual OopClosure* raw_strong_oops() = 0; - // Applied to code blobs treated as weak roots. virtual CodeBlobClosure* weak_codeblobs() = 0;
--- a/src/hotspot/share/gc/g1/g1RootProcessor.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/g1/g1RootProcessor.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -45,7 +45,7 @@ #include "services/management.hpp" #include "utilities/macros.hpp" -void G1RootProcessor::worker_has_discovered_all_strong_classes() { +void G1RootProcessor::worker_has_discovered_all_strong_nmethods() { assert(ClassUnloadingWithConcurrentMark, "Currently only needed when doing G1 Class Unloading"); uint new_value = (uint)Atomic::add(1, &_n_workers_discovered_strong_classes); @@ -56,7 +56,7 @@ } } -void G1RootProcessor::wait_until_all_strong_classes_discovered() { +void G1RootProcessor::wait_until_all_strong_nmethods_discovered() { assert(ClassUnloadingWithConcurrentMark, "Currently only needed when doing G1 Class Unloading"); if ((uint)_n_workers_discovered_strong_classes != n_workers()) { @@ -71,28 +71,22 @@ _g1h(g1h), _process_strong_tasks(G1RP_PS_NumElements), _srs(n_workers), - _lock(Mutex::leaf, "G1 Root Scanning barrier lock", false, Monitor::_safepoint_check_never), + _lock(Mutex::leaf, "G1 Root Scan barrier lock", false, Monitor::_safepoint_check_never), _n_workers_discovered_strong_classes(0) {} -void G1RootProcessor::evacuate_roots(G1ParScanThreadState* pss, uint worker_i) { +void G1RootProcessor::evacuate_roots(G1ParScanThreadState* pss, uint worker_id) { G1GCPhaseTimes* phase_times = _g1h->phase_times(); - G1EvacPhaseTimesTracker timer(phase_times, pss, G1GCPhaseTimes::ExtRootScan, worker_i); + G1EvacPhaseTimesTracker timer(phase_times, pss, G1GCPhaseTimes::ExtRootScan, worker_id); G1EvacuationRootClosures* closures = pss->closures(); - process_java_roots(closures, phase_times, worker_i); + process_java_roots(closures, phase_times, worker_id, closures->trace_metadata() /* notify_claimed_nmethods_done */); - // This is the point where this worker thread will not find more strong CLDs/nmethods. - // Report this so G1 can synchronize the strong and weak CLDs/nmethods processing. - if (closures->trace_metadata()) { - worker_has_discovered_all_strong_classes(); - } - - process_vm_roots(closures, phase_times, worker_i); + process_vm_roots(closures, phase_times, worker_id); { // Now the CM ref_processor roots. - G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::CMRefRoots, worker_i); + G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::CMRefRoots, worker_id); if (_process_strong_tasks.try_claim_task(G1RP_PS_refProcessor_oops_do)) { // We need to treat the discovered reference lists of the // concurrent mark ref processor as roots and keep entries @@ -103,21 +97,9 @@ } if (closures->trace_metadata()) { - { - G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::WaitForStrongCLD, worker_i); - // Barrier to make sure all workers passed - // the strong CLD and strong nmethods phases. - wait_until_all_strong_classes_discovered(); - } - - // Now take the complement of the strong CLDs. - G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::WeakCLDRoots, worker_i); - assert(closures->second_pass_weak_clds() != NULL, "Should be non-null if we are tracing metadata."); - ClassLoaderDataGraph::roots_cld_do(NULL, closures->second_pass_weak_clds()); - } else { - phase_times->record_time_secs(G1GCPhaseTimes::WaitForStrongCLD, worker_i, 0.0); - phase_times->record_time_secs(G1GCPhaseTimes::WeakCLDRoots, worker_i, 0.0); - assert(closures->second_pass_weak_clds() == NULL, "Should be null if not tracing metadata."); + G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::WaitForStrongRoots, worker_id); + // Wait to make sure all workers passed the strong nmethods phase. + wait_until_all_strong_nmethods_discovered(); } _process_strong_tasks.all_tasks_completed(n_workers()); @@ -189,61 +171,81 @@ void G1RootProcessor::process_java_roots(G1RootClosures* closures, G1GCPhaseTimes* phase_times, - uint worker_i) { - // Iterating over the CLDG and the Threads are done early to allow us to - // first process the strong CLDs and nmethods and then, after a barrier, - // let the thread process the weak CLDs and nmethods. + uint worker_id, + bool notify_claimed_nmethods_done) { + // We need to make make sure that the "strong" nmethods are processed first + // using the strong closure. Only after that we process the weakly reachable + // nmethods. + // We need to strictly separate the strong and weak nmethod processing because + // any processing claims that nmethod, i.e. will not be iterated again. + // Which means if an nmethod is processed first and claimed, the strong processing + // will not happen, and the oops reachable by that nmethod will not be marked + // properly. + // + // That is why we process strong nmethods first, synchronize all threads via a + // barrier, and only then allow weak processing. To minimize the wait time at + // that barrier we do the strong nmethod processing first, and immediately after- + // wards indicate that that thread is done. Hopefully other root processing after + // nmethod processing is enough so there is no need to wait. + // + // This is only required in the concurrent start pause with class unloading enabled. { - G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::CLDGRoots, worker_i); - if (_process_strong_tasks.try_claim_task(G1RP_PS_ClassLoaderDataGraph_oops_do)) { - ClassLoaderDataGraph::roots_cld_do(closures->strong_clds(), closures->weak_clds()); - } - } - - { - G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::ThreadRoots, worker_i); + G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::ThreadRoots, worker_id); bool is_par = n_workers() > 1; Threads::possibly_parallel_oops_do(is_par, closures->strong_oops(), closures->strong_codeblobs()); } + + // This is the point where this worker thread will not find more strong nmethods. + // Report this so G1 can synchronize the strong and weak CLDs/nmethods processing. + if (notify_claimed_nmethods_done) { + worker_has_discovered_all_strong_nmethods(); + } + + { + G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::CLDGRoots, worker_id); + if (_process_strong_tasks.try_claim_task(G1RP_PS_ClassLoaderDataGraph_oops_do)) { + ClassLoaderDataGraph::roots_cld_do(closures->strong_clds(), closures->weak_clds()); + } + } } void G1RootProcessor::process_vm_roots(G1RootClosures* closures, G1GCPhaseTimes* phase_times, - uint worker_i) { + uint worker_id) { OopClosure* strong_roots = closures->strong_oops(); { - G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::UniverseRoots, worker_i); + G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::UniverseRoots, worker_id); if (_process_strong_tasks.try_claim_task(G1RP_PS_Universe_oops_do)) { Universe::oops_do(strong_roots); } } { - G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::JNIRoots, worker_i); + G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::JNIRoots, worker_id); if (_process_strong_tasks.try_claim_task(G1RP_PS_JNIHandles_oops_do)) { JNIHandles::oops_do(strong_roots); } } { - G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::ObjectSynchronizerRoots, worker_i); + G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::ObjectSynchronizerRoots, worker_id); if (_process_strong_tasks.try_claim_task(G1RP_PS_ObjectSynchronizer_oops_do)) { ObjectSynchronizer::oops_do(strong_roots); } } { - G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::ManagementRoots, worker_i); + G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::ManagementRoots, worker_id); if (_process_strong_tasks.try_claim_task(G1RP_PS_Management_oops_do)) { Management::oops_do(strong_roots); } } { - G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::JVMTIRoots, worker_i); + G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::JVMTIRoots, worker_id); if (_process_strong_tasks.try_claim_task(G1RP_PS_jvmti_oops_do)) { JvmtiExport::oops_do(strong_roots); } @@ -251,7 +253,7 @@ #if INCLUDE_AOT if (UseAOT) { - G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::AOTCodeRoots, worker_i); + G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::AOTCodeRoots, worker_id); if (_process_strong_tasks.try_claim_task(G1RP_PS_aot_oops_do)) { AOTLoader::oops_do(strong_roots); } @@ -259,7 +261,7 @@ #endif { - G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::SystemDictionaryRoots, worker_i); + G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::SystemDictionaryRoots, worker_id); if (_process_strong_tasks.try_claim_task(G1RP_PS_SystemDictionary_oops_do)) { SystemDictionary::oops_do(strong_roots); } @@ -268,7 +270,7 @@ void G1RootProcessor::process_code_cache_roots(CodeBlobClosure* code_closure, G1GCPhaseTimes* phase_times, - uint worker_i) { + uint worker_id) { if (_process_strong_tasks.try_claim_task(G1RP_PS_CodeCache_oops_do)) { CodeCache::blobs_do(code_closure); }
--- a/src/hotspot/share/gc/g1/g1RootProcessor.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/g1/g1RootProcessor.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -69,20 +69,21 @@ G1RP_PS_NumElements }; - void worker_has_discovered_all_strong_classes(); - void wait_until_all_strong_classes_discovered(); + void worker_has_discovered_all_strong_nmethods(); + void wait_until_all_strong_nmethods_discovered(); void process_java_roots(G1RootClosures* closures, G1GCPhaseTimes* phase_times, - uint worker_i); + uint worker_id, + bool notify_claimed_nmethods_done = false); void process_vm_roots(G1RootClosures* closures, G1GCPhaseTimes* phase_times, - uint worker_i); + uint worker_id); void process_code_cache_roots(CodeBlobClosure* code_closure, G1GCPhaseTimes* phase_times, - uint worker_i); + uint worker_id); public: G1RootProcessor(G1CollectedHeap* g1h, uint n_workers);
--- a/src/hotspot/share/gc/g1/g1SharedClosures.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/g1/g1SharedClosures.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -39,9 +39,9 @@ G1CLDScanClosure _clds; G1CodeBlobClosure _codeblobs; - G1SharedClosures(G1CollectedHeap* g1h, G1ParScanThreadState* pss, bool process_only_dirty, int cld_claim) : + G1SharedClosures(G1CollectedHeap* g1h, G1ParScanThreadState* pss, bool process_only_dirty) : _oops(g1h, pss), _oops_in_cld(g1h, pss), - _clds(&_oops_in_cld, process_only_dirty, cld_claim), + _clds(&_oops_in_cld, process_only_dirty), _codeblobs(&_oops) {} };
--- a/src/hotspot/share/gc/shared/c1/barrierSetC1.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/shared/c1/barrierSetC1.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -100,7 +100,7 @@ BasicType type() const { return _type; } LIR_Opr resolved_addr() const { return _resolved_addr; } void set_resolved_addr(LIR_Opr addr) { _resolved_addr = addr; } - bool is_oop() const { return _type == T_ARRAY || _type == T_OBJECT; } + bool is_oop() const { return is_reference_type(_type); } DecoratorSet decorators() const { return _decorators; } void clear_decorators(DecoratorSet ds) { _decorators &= ~ds; } bool is_raw() const { return (_decorators & AS_RAW) != 0; }
--- a/src/hotspot/share/gc/shared/c2/barrierSetC2.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/shared/c2/barrierSetC2.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -120,7 +120,7 @@ Node* base() const { return _base; } C2AccessValuePtr& addr() const { return _addr; } BasicType type() const { return _type; } - bool is_oop() const { return _type == T_OBJECT || _type == T_ARRAY; } + bool is_oop() const { return is_reference_type(_type); } bool is_raw() const { return (_decorators & AS_RAW) != 0; } Node* raw_access() const { return _raw_access; }
--- a/src/hotspot/share/gc/shared/c2/cardTableBarrierSetC2.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/shared/c2/cardTableBarrierSetC2.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -187,6 +187,6 @@ } bool CardTableBarrierSetC2::array_copy_requires_gc_barriers(bool tightly_coupled_alloc, BasicType type, bool is_clone, ArrayCopyPhase phase) const { - bool is_oop = type == T_OBJECT || type == T_ARRAY; + bool is_oop = is_reference_type(type); return is_oop && (!tightly_coupled_alloc || !use_ReduceInitialCardMarks()); }
--- a/src/hotspot/share/gc/shared/memAllocator.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/shared/memAllocator.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -171,9 +171,8 @@ // This is a VM policy failure, so how do we exhaustively test it? assert(!_thread->has_pending_exception(), "shouldn't be allocating with pending exception"); - // Allocation of an oop can always invoke a safepoint, - // hence, the true argument. - _thread->check_for_valid_safepoint_state(true); + // Allocation of an oop can always invoke a safepoint. + _thread->check_for_valid_safepoint_state(); } #endif
--- a/src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -754,7 +754,7 @@ } bool ShenandoahBarrierSetC2::array_copy_requires_gc_barriers(bool tightly_coupled_alloc, BasicType type, bool is_clone, ArrayCopyPhase phase) const { - bool is_oop = type == T_OBJECT || type == T_ARRAY; + bool is_oop = is_reference_type(type); if (!is_oop) { return false; } @@ -787,7 +787,7 @@ } } else if (src_type->isa_aryptr()) { BasicType src_elem = src_type->klass()->as_array_klass()->element_type()->basic_type(); - if (src_elem == T_OBJECT || src_elem == T_ARRAY) { + if (is_reference_type(src_elem)) { return true; } } else {
--- a/src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -266,9 +266,19 @@ return NULL; } - if (_heap->is_evacuation_in_progress() && - !_heap->complete_marking_context()->is_marked(obj)) { - return NULL; + ShenandoahMarkingContext* const marking_context = _heap->marking_context(); + + if (_heap->is_evacuation_in_progress()) { + // Normal GC + if (!marking_context->is_marked(obj)) { + return NULL; + } + } else if (_heap->is_concurrent_traversal_in_progress()) { + // Traversal GC + if (marking_context->is_complete() && + !marking_context->is_marked(resolve_forwarded_not_null(obj))) { + return NULL; + } } return load_reference_barrier_not_null(obj);
--- a/src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -594,11 +594,6 @@ } if (!_heap->cancelled_gc()) { - fixup_roots(); - _heap->parallel_cleaning(false); - } - - if (!_heap->cancelled_gc()) { assert(_task_queues->is_empty(), "queues must be empty after traversal GC"); TASKQUEUE_STATS_ONLY(_task_queues->print_taskqueue_stats()); TASKQUEUE_STATS_ONLY(_task_queues->reset_taskqueue_stats()); @@ -606,6 +601,9 @@ // No more marking expected _heap->mark_complete_marking_context(); + fixup_roots(); + _heap->parallel_cleaning(false); + // Resize metaspace MetaspaceGC::compute_new_size();
--- a/src/hotspot/share/gc/z/c2/zBarrierSetC2.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/z/c2/zBarrierSetC2.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -660,7 +660,7 @@ } bool ZBarrierSetC2::array_copy_requires_gc_barriers(bool tightly_coupled_alloc, BasicType type, bool is_clone, ArrayCopyPhase phase) const { - return type == T_OBJECT || type == T_ARRAY; + return is_reference_type(type); } bool ZBarrierSetC2::final_graph_reshaping(Compile* compile, Node* n, uint opcode) const { @@ -1367,7 +1367,7 @@ LoadStoreNode* lsn = n->as_LoadStore(); if (lsn->has_barrier()) { BasicType bt = lsn->in(MemNode::Address)->bottom_type()->basic_type(); - assert ((bt == T_OBJECT || bt == T_ARRAY), "Sanity test"); + assert (is_reference_type(bt), "Sanity test"); insert_barrier_before_unsafe(phase, lsn); } }
--- a/src/hotspot/share/gc/z/vmStructs_z.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/z/vmStructs_z.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -104,8 +104,7 @@ declare_constant(ZAddressOffsetShift) \ declare_constant(ZAddressOffsetBits) \ declare_constant(ZAddressOffsetMask) \ - declare_constant(ZAddressOffsetMax) \ - declare_constant(ZAddressSpaceStart) + declare_constant(ZAddressOffsetMax) #define VM_TYPES_ZGC(declare_type, declare_toplevel_type, declare_integer_type) \ declare_toplevel_type(ZGlobalsForVMStructs) \
--- a/src/hotspot/share/gc/z/zAddress.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/z/zAddress.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -32,14 +32,6 @@ } void ZAddress::initialize() { - ZAddressSpaceStart = ZPlatformAddressSpaceStart(); - ZAddressSpaceEnd = ZPlatformAddressSpaceEnd(); - ZAddressSpaceSize = ZAddressSpaceEnd - ZAddressSpaceStart; - - ZAddressReservedStart = ZPlatformAddressReservedStart(); - ZAddressReservedEnd = ZPlatformAddressReservedEnd(); - ZAddressReservedSize = ZAddressReservedEnd - ZAddressReservedStart; - ZAddressBase = ZPlatformAddressBase(); ZAddressOffsetBits = ZPlatformAddressOffsetBits();
--- a/src/hotspot/share/gc/z/zBarrierSet.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/z/zBarrierSet.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -66,7 +66,7 @@ assert((decorators & AS_NO_KEEPALIVE) == 0, "Unexpected decorator"); //assert((decorators & ON_UNKNOWN_OOP_REF) == 0, "Unexpected decorator"); - if (type == T_OBJECT || type == T_ARRAY) { + if (is_reference_type(type)) { assert((decorators & (IN_HEAP | IN_NATIVE)) != 0, "Where is reference?"); // Barrier needed even when IN_NATIVE, to allow concurrent scanning. return true;
--- a/src/hotspot/share/gc/z/zCollectedHeap.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/z/zCollectedHeap.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -23,13 +23,13 @@ #include "precompiled.hpp" #include "gc/shared/gcHeapSummary.hpp" -#include "gc/shared/locationPrinter.hpp" #include "gc/shared/suspendibleThreadSet.hpp" #include "gc/z/zCollectedHeap.hpp" #include "gc/z/zGlobals.hpp" #include "gc/z/zHeap.inline.hpp" #include "gc/z/zNMethod.hpp" #include "gc/z/zObjArrayAllocator.hpp" +#include "gc/z/zOop.inline.hpp" #include "gc/z/zServiceability.hpp" #include "gc/z/zStat.hpp" #include "gc/z/zUtils.inline.hpp" @@ -68,8 +68,7 @@ return JNI_ENOMEM; } - Universe::calculate_verify_data((HeapWord*)ZAddressReservedStart, - (HeapWord*)ZAddressReservedEnd); + Universe::calculate_verify_data((HeapWord*)0, (HeapWord*)UINTPTR_MAX); return JNI_OK; } @@ -116,7 +115,7 @@ } uint32_t ZCollectedHeap::hash_oop(oop obj) const { - return _heap.hash_oop(obj); + return _heap.hash_oop(ZOop::to_address(obj)); } HeapWord* ZCollectedHeap::allocate_new_tlab(size_t min_size, size_t requested_size, size_t* actual_size) { @@ -285,12 +284,7 @@ } VirtualSpaceSummary ZCollectedHeap::create_heap_space_summary() { - const size_t capacity_in_words = capacity() / HeapWordSize; - const size_t max_capacity_in_words = max_capacity() / HeapWordSize; - HeapWord* const heap_start = (HeapWord*)ZAddressReservedStart; - return VirtualSpaceSummary(heap_start, - heap_start + capacity_in_words, - heap_start + max_capacity_in_words); + return VirtualSpaceSummary((HeapWord*)0, (HeapWord*)capacity(), (HeapWord*)max_capacity()); } void ZCollectedHeap::safepoint_synchronize_begin() { @@ -312,10 +306,6 @@ void ZCollectedHeap::print_on_error(outputStream* st) const { CollectedHeap::print_on_error(st); - st->print_cr("Address Space"); - st->print_cr( " Start: " PTR_FORMAT, ZAddressSpaceStart); - st->print_cr( " End: " PTR_FORMAT, ZAddressSpaceEnd); - st->print_cr( " Size: " SIZE_FORMAT_W(-15) " (" PTR_FORMAT ")", ZAddressSpaceSize, ZAddressSpaceSize); st->print_cr( "Heap"); st->print_cr( " GlobalPhase: %u", ZGlobalPhase); st->print_cr( " GlobalSeqNum: %u", ZGlobalSeqNum); @@ -352,13 +342,7 @@ } bool ZCollectedHeap::print_location(outputStream* st, void* addr) const { - if (LocationPrinter::is_valid_obj(addr)) { - st->print(INTPTR_FORMAT " is a %s oop: ", p2i(addr), - ZAddress::is_good(reinterpret_cast<uintptr_t>(addr)) ? "good" : "bad"); - cast_to_oop(addr)->print_on(st); - return true; - } - return false; + return _heap.print_location(st, (uintptr_t)addr); } void ZCollectedHeap::verify(VerifyOption option /* ignored */) { @@ -366,5 +350,5 @@ } bool ZCollectedHeap::is_oop(oop object) const { - return CollectedHeap::is_oop(object) && _heap.is_oop(object); + return _heap.is_oop(ZOop::to_address(object)); }
--- a/src/hotspot/share/gc/z/zDebug.gdb Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/z/zDebug.gdb Wed Sep 25 13:40:36 2019 +0530 @@ -126,10 +126,6 @@ # Print heap information define zph - printf "Address Space\n" - printf " Start: 0x%llx\n", ZAddressSpaceStart - printf " End: 0x%llx\n", ZAddressSpaceEnd - printf " Size: %-15llu (0x%llx)\n", ZAddressSpaceSize, ZAddressSpaceSize printf "Heap\n" printf " GlobalPhase: %u\n", ZGlobalPhase printf " GlobalSeqNum: %u\n", ZGlobalSeqNum
--- a/src/hotspot/share/gc/z/zGlobals.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/z/zGlobals.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -48,11 +48,3 @@ uintptr_t ZAddressMetadataMarked1; uintptr_t ZAddressMetadataRemapped; uintptr_t ZAddressMetadataFinalizable; - -uintptr_t ZAddressSpaceStart; -uintptr_t ZAddressSpaceEnd; -size_t ZAddressSpaceSize; - -uintptr_t ZAddressReservedStart; -uintptr_t ZAddressReservedEnd; -size_t ZAddressReservedSize;
--- a/src/hotspot/share/gc/z/zGlobals.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/z/zGlobals.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -112,16 +112,6 @@ extern uintptr_t ZAddressMetadataRemapped; extern uintptr_t ZAddressMetadataFinalizable; -// Address space start/end/size -extern uintptr_t ZAddressSpaceStart; -extern uintptr_t ZAddressSpaceEnd; -extern size_t ZAddressSpaceSize; - -// Reserved space start/end -extern uintptr_t ZAddressReservedStart; -extern uintptr_t ZAddressReservedEnd; -extern size_t ZAddressReservedSize; - // NMethod entry barrier const size_t ZNMethodDisarmedOffset = ZPlatformNMethodDisarmedOffset;
--- a/src/hotspot/share/gc/z/zHeap.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/z/zHeap.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -22,35 +22,26 @@ */ #include "precompiled.hpp" -#include "gc/shared/gcArguments.hpp" -#include "gc/shared/oopStorage.hpp" -#include "gc/z/zAddress.hpp" +#include "gc/shared/locationPrinter.hpp" +#include "gc/z/zAddress.inline.hpp" #include "gc/z/zGlobals.hpp" #include "gc/z/zHeap.inline.hpp" #include "gc/z/zHeapIterator.hpp" -#include "gc/z/zList.inline.hpp" -#include "gc/z/zLock.inline.hpp" #include "gc/z/zMark.inline.hpp" -#include "gc/z/zOopClosures.inline.hpp" #include "gc/z/zPage.inline.hpp" #include "gc/z/zPageTable.inline.hpp" #include "gc/z/zRelocationSet.inline.hpp" +#include "gc/z/zRelocationSetSelector.hpp" #include "gc/z/zResurrection.hpp" -#include "gc/z/zRootsIterator.hpp" #include "gc/z/zStat.hpp" -#include "gc/z/zTask.hpp" #include "gc/z/zThread.hpp" -#include "gc/z/zTracer.inline.hpp" #include "gc/z/zVerify.hpp" -#include "gc/z/zVirtualMemory.inline.hpp" #include "gc/z/zWorkers.inline.hpp" #include "logging/log.hpp" +#include "memory/iterator.hpp" #include "memory/resourceArea.hpp" -#include "oops/oop.inline.hpp" -#include "runtime/arguments.hpp" #include "runtime/safepoint.hpp" #include "runtime/thread.hpp" -#include "utilities/align.hpp" #include "utilities/debug.hpp" static const ZStatSampler ZSamplerHeapUsedBeforeMark("Memory", "Heap Used Before Mark", ZStatUnitBytes); @@ -179,7 +170,7 @@ bool ZHeap::is_in(uintptr_t addr) const { // An address is considered to be "in the heap" if it points into - // the allocated part of a pages, regardless of which heap view is + // the allocated part of a page, regardless of which heap view is // used. Note that an address with the finalizable metadata bit set // is not pointing into a heap view, and therefore not considered // to be "in the heap". @@ -512,6 +503,16 @@ st->cr(); } +bool ZHeap::print_location(outputStream* st, uintptr_t addr) const { + if (LocationPrinter::is_valid_obj((void*)addr)) { + st->print(PTR_FORMAT " is a %s oop: ", addr, ZAddress::is_good(addr) ? "good" : "bad"); + ZOop::from_address(addr)->print_on(st); + return true; + } + + return false; +} + void ZHeap::verify() { // Heap verification can only be done between mark end and // relocate start. This is the only window where all oop are
--- a/src/hotspot/share/gc/z/zHeap.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/z/zHeap.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -24,12 +24,8 @@ #ifndef SHARE_GC_Z_ZHEAP_HPP #define SHARE_GC_Z_ZHEAP_HPP -#include "gc/shared/gcTimer.hpp" #include "gc/z/zAllocationFlags.hpp" -#include "gc/z/zArray.hpp" #include "gc/z/zForwardingTable.hpp" -#include "gc/z/zList.hpp" -#include "gc/z/zLock.hpp" #include "gc/z/zMark.hpp" #include "gc/z/zObjectAllocator.hpp" #include "gc/z/zPage.hpp" @@ -38,13 +34,10 @@ #include "gc/z/zReferenceProcessor.hpp" #include "gc/z/zRelocate.hpp" #include "gc/z/zRelocationSet.hpp" -#include "gc/z/zRelocationSetSelector.hpp" -#include "gc/z/zRootsIterator.hpp" #include "gc/z/zWeakRootsProcessor.hpp" #include "gc/z/zServiceability.hpp" #include "gc/z/zUnload.hpp" #include "gc/z/zWorkers.hpp" -#include "memory/allocation.hpp" class ZHeap { friend class VMStructs; @@ -105,7 +98,7 @@ size_t unsafe_max_tlab_alloc() const; bool is_in(uintptr_t addr) const; - uint32_t hash_oop(oop obj) const; + uint32_t hash_oop(uintptr_t addr) const; // Workers uint nconcurrent_worker_threads() const; @@ -168,9 +161,10 @@ // Printing void print_on(outputStream* st) const; void print_extended_on(outputStream* st) const; + bool print_location(outputStream* st, uintptr_t addr) const; // Verification - bool is_oop(oop object) const; + bool is_oop(uintptr_t addr) const; void verify(); };
--- a/src/hotspot/share/gc/z/zHeap.inline.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/z/zHeap.inline.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -33,7 +33,6 @@ #include "gc/z/zOop.inline.hpp" #include "gc/z/zPage.inline.hpp" #include "gc/z/zPageTable.inline.hpp" -#include "gc/z/zUtils.inline.hpp" #include "utilities/debug.hpp" inline ZHeap* ZHeap::heap() { @@ -45,8 +44,8 @@ return &_reference_processor; } -inline uint32_t ZHeap::hash_oop(oop obj) const { - const uintptr_t offset = ZAddress::offset(ZOop::to_address(obj)); +inline uint32_t ZHeap::hash_oop(uintptr_t addr) const { + const uintptr_t offset = ZAddress::offset(addr); return ZHash::address_to_uint32(offset); } @@ -134,12 +133,8 @@ _page_allocator.check_out_of_memory(); } -inline bool ZHeap::is_oop(oop object) const { - // Verify that we have a good address. Note that ZAddress::is_good() - // would not be a strong enough verification, since it only verifies - // that the metadata bits are good. - const uintptr_t addr = ZOop::to_address(object); - return ZAddress::good(addr) == addr; +inline bool ZHeap::is_oop(uintptr_t addr) const { + return ZAddress::is_good(addr) && is_object_aligned(addr) && is_in(addr); } #endif // SHARE_GC_Z_ZHEAP_INLINE_HPP
--- a/src/hotspot/share/gc/z/zPageAllocator.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/z/zPageAllocator.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -94,7 +94,7 @@ size_t max_capacity, size_t max_reserve) : _lock(), - _virtual(), + _virtual(max_capacity), _physical(), _cache(), _min_capacity(min_capacity),
--- a/src/hotspot/share/gc/z/zVirtualMemory.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/z/zVirtualMemory.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -27,28 +27,39 @@ #include "logging/log.hpp" #include "services/memTracker.hpp" -ZVirtualMemoryManager::ZVirtualMemoryManager() : +ZVirtualMemoryManager::ZVirtualMemoryManager(size_t max_capacity) : _manager(), _initialized(false) { - log_info(gc, init)("Address Space: " PTR_FORMAT " - " PTR_FORMAT " (" SIZE_FORMAT "T)", - ZAddressSpaceStart, ZAddressSpaceEnd, ZAddressSpaceSize / K / G); + log_info(gc, init)("Address Space: " SIZE_FORMAT "T", ZAddressOffsetMax / K / G); // Reserve address space - if (!reserve(ZAddressSpaceStart, ZAddressSpaceSize)) { + if (reserve(0, ZAddressOffsetMax) < max_capacity) { + log_error(gc)("Failed to reserve address space for Java heap"); return; } - // Make the complete address view free - _manager.free(0, ZAddressOffsetMax); - - // Register address space with native memory tracker - nmt_reserve(ZAddressSpaceStart, ZAddressSpaceSize); - // Successfully initialized _initialized = true; } +size_t ZVirtualMemoryManager::reserve(uintptr_t start, size_t size) { + if (size < ZGranuleSize) { + // Too small + return 0; + } + + if (!reserve_platform(start, size)) { + const size_t half = size / 2; + return reserve(start, half) + reserve(start + half, half); + } + + // Make the address range free + _manager.free(start, size); + + return size; +} + void ZVirtualMemoryManager::nmt_reserve(uintptr_t start, size_t size) { MemTracker::record_virtual_memory_reserve((void*)start, size, CALLER_PC); MemTracker::record_virtual_memory_type((void*)start, mtJavaHeap);
--- a/src/hotspot/share/gc/z/zVirtualMemory.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/gc/z/zVirtualMemory.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -50,11 +50,12 @@ ZMemoryManager _manager; bool _initialized; - bool reserve(uintptr_t start, size_t size); + bool reserve_platform(uintptr_t start, size_t size); + size_t reserve(uintptr_t start, size_t size); void nmt_reserve(uintptr_t start, size_t size); public: - ZVirtualMemoryManager(); + ZVirtualMemoryManager(size_t max_capacity); bool is_initialized() const;
--- a/src/hotspot/share/interpreter/bytecodeTracer.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/interpreter/bytecodeTracer.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -449,7 +449,7 @@ case Bytecodes::_newarray: { BasicType atype = (BasicType)get_index_u1(); const char* str = type2name(atype); - if (str == NULL || atype == T_OBJECT || atype == T_ARRAY) { + if (str == NULL || is_reference_type(atype)) { assert(false, "Unidentified basic type"); } st->print_cr(" %s", str);
--- a/src/hotspot/share/jvmci/jvmciCompilerToVM.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/jvmci/jvmciCompilerToVM.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1034,7 +1034,7 @@ if (jap.get_ret_type() == T_VOID) { return NULL; - } else if (jap.get_ret_type() == T_OBJECT || jap.get_ret_type() == T_ARRAY) { + } else if (is_reference_type(jap.get_ret_type())) { return JNIHandles::make_local((oop) result.get_jobject()); } else { jvalue *value = (jvalue *) result.get_value_addr(); @@ -1149,8 +1149,8 @@ return (jint) JVMCICounterSize; C2V_END -C2V_VMENTRY_0(jboolean, setCountersSize, (JNIEnv* env, jobject, jint new_size)) - return JavaThread::resize_all_jvmci_counters(new_size); +C2V_VMENTRY(void, setCountersSize, (JNIEnv* env, jobject, jint new_size)) + JavaThread::resize_all_jvmci_counters(new_size); C2V_END C2V_VMENTRY_0(jint, allocateCompileId, (JNIEnv* env, jobject, jobject jvmci_method, int entry_bci)) @@ -2696,7 +2696,7 @@ {CC "readUncompressedOop", CC "(J)" OBJECTCONSTANT, FN_PTR(readUncompressedOop)}, {CC "collectCounters", CC "()[J", FN_PTR(collectCounters)}, {CC "getCountersSize", CC "()I", FN_PTR(getCountersSize)}, - {CC "setCountersSize", CC "(I)Z", FN_PTR(setCountersSize)}, + {CC "setCountersSize", CC "(I)V", FN_PTR(setCountersSize)}, {CC "allocateCompileId", CC "(" HS_RESOLVED_METHOD "I)I", FN_PTR(allocateCompileId)}, {CC "isMature", CC "(" METASPACE_METHOD_DATA ")Z", FN_PTR(isMature)}, {CC "hasCompiledCodeForOSR", CC "(" HS_RESOLVED_METHOD "II)Z", FN_PTR(hasCompiledCodeForOSR)},
--- a/src/hotspot/share/memory/dynamicArchive.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/memory/dynamicArchive.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -470,7 +470,8 @@ void sort_methods(InstanceKlass* ik) const; void set_symbols_permanent(); void relocate_buffer_to_target(); - void write_archive(char* read_only_tables_start); + void write_archive(char* serialized_data_start); + void write_regions(FileMapInfo* dynamic_info); void init_first_dump_space(address reserved_bottom) { address first_space_base = reserved_bottom; @@ -595,7 +596,7 @@ verify_estimate_size(_estimated_metsapceobj_bytes, "MetaspaceObjs"); - char* read_only_tables_start; + char* serialized_data_start; { set_symbols_permanent(); @@ -608,7 +609,7 @@ SymbolTable::write_to_archive(false); SystemDictionaryShared::write_to_archive(false); - read_only_tables_start = ro_space->top(); + serialized_data_start = ro_space->top(); WriteClosure wc(ro_space); SymbolTable::serialize_shared_table_header(&wc, false); SystemDictionaryShared::serialize_dictionary_headers(&wc, false); @@ -634,7 +635,7 @@ relocate_buffer_to_target(); } - write_archive(read_only_tables_start); + write_archive(serialized_data_start); assert(_num_dump_regions_used == _total_dump_regions, "must be"); verify_universe("After CDS dynamic dump"); @@ -911,9 +912,7 @@ _header->relocate_shared_path_table(table); } -static void write_archive_info(FileMapInfo* dynamic_info, DynamicArchiveHeader *header) { - dynamic_info->write_header(); - dynamic_info->align_file_position(); +void DynamicArchiveBuilder::write_regions(FileMapInfo* dynamic_info) { dynamic_info->write_region(MetaspaceShared::rw, MetaspaceShared::read_write_dump_space()->base(), MetaspaceShared::read_write_dump_space()->used(), @@ -928,28 +927,23 @@ /*read_only=*/false,/*allow_exec=*/true); } -void DynamicArchiveBuilder::write_archive(char* read_only_tables_start) { +void DynamicArchiveBuilder::write_archive(char* serialized_data_start) { int num_klasses = _klasses->length(); int num_symbols = _symbols->length(); - _header->set_read_only_tables_start(to_target(read_only_tables_start)); + _header->set_serialized_data_start(to_target(serialized_data_start)); FileMapInfo* dynamic_info = FileMapInfo::dynamic_info(); assert(dynamic_info != NULL, "Sanity"); - // Populate the file offsets, region crcs, etc. No data is written out. - write_archive_info(dynamic_info, _header); - - // the header will no longer change. Compute its crc. - dynamic_info->set_header_crc(dynamic_info->compute_header_crc()); - // Now write the archived data including the file offsets. const char* archive_name = Arguments::GetSharedDynamicArchivePath(); dynamic_info->open_for_write(archive_name); - write_archive_info(dynamic_info, _header); + write_regions(dynamic_info); + dynamic_info->set_header_crc(dynamic_info->compute_header_crc()); + dynamic_info->write_header(); dynamic_info->close(); - address base = to_target(_alloc_bottom); address top = address(current_dump_space()->top()) + _buffer_to_target_delta; size_t file_size = pointer_delta(top, base, sizeof(char)); @@ -1108,7 +1102,7 @@ return NULL; } - intptr_t* buffer = (intptr_t*)_dynamic_header->read_only_tables_start(); + intptr_t* buffer = (intptr_t*)_dynamic_header->serialized_data_start(); ReadClosure rc(&buffer); SymbolTable::serialize_shared_table_header(&rc, false); SystemDictionaryShared::serialize_dictionary_headers(&rc, false);
--- a/src/hotspot/share/memory/filemap.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/memory/filemap.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1033,6 +1033,11 @@ return true; } +void FileMapInfo::seek_to_position(size_t pos) { + if (lseek(_fd, (long)pos, SEEK_SET) < 0) { + fail_stop("Unable to seek to position " SIZE_FORMAT, pos); + } +} // Read the FileMapInfo information from the file. bool FileMapInfo::open_for_read(const char* path) { @@ -1088,14 +1093,26 @@ os::strerror(errno)); } _fd = fd; - _file_offset = 0; _file_open = true; + + // Seek past the header. We will write the header after all regions are written + // and their CRCs computed. + size_t header_bytes = header()->header_size(); + if (header()->magic() == CDS_DYNAMIC_ARCHIVE_MAGIC) { + header_bytes += strlen(Arguments::GetSharedArchivePath()) + 1; + } + + header_bytes = align_up(header_bytes, os::vm_allocation_granularity()); + _file_offset = header_bytes; + seek_to_position(_file_offset); } // Write the header to the file, seek to the next allocation boundary. void FileMapInfo::write_header() { + _file_offset = 0; + seek_to_position(_file_offset); char* base_archive_name = NULL; if (header()->magic() == CDS_DYNAMIC_ARCHIVE_MAGIC) { base_archive_name = (char*)Arguments::GetSharedArchivePath(); @@ -1108,7 +1125,6 @@ if (base_archive_name != NULL) { write_bytes(base_archive_name, header()->base_archive_name_size()); } - align_file_position(); } void FileMapRegion::init(bool is_heap_region, char* base, size_t size, bool read_only, @@ -1132,9 +1148,6 @@ _crc = crc; } -// Dump region to file. -// This is called twice for each region during archiving, once before -// the archive file is open (_file_open is false) and once after. void FileMapInfo::write_region(int region, char* base, size_t size, bool read_only, bool allow_exec) { assert(DumpSharedSpaces || DynamicDumpSharedSpaces, "Dump time only"); @@ -1146,14 +1159,10 @@ target_base = DynamicArchive::buffer_to_target(base); } - if (_file_open) { - guarantee(si->file_offset() == _file_offset, "file offset mismatch."); - log_info(cds)("Shared file region %d: " SIZE_FORMAT_HEX_W(08) - " bytes, addr " INTPTR_FORMAT " file offset " SIZE_FORMAT_HEX_W(08), - region, size, p2i(target_base), _file_offset); - } else { - si->set_file_offset(_file_offset); - } + si->set_file_offset(_file_offset); + log_info(cds)("Shared file region %d: " SIZE_FORMAT_HEX_W(08) + " bytes, addr " INTPTR_FORMAT " file offset " SIZE_FORMAT_HEX_W(08), + region, size, p2i(target_base), _file_offset); int crc = ClassLoader::crc32(0, base, (jint)size); si->init(HeapShared::is_heap_region(region), target_base, size, read_only, allow_exec, crc); @@ -1196,8 +1205,7 @@ // +-- gap size_t FileMapInfo::write_archive_heap_regions(GrowableArray<MemRegion> *heap_mem, GrowableArray<ArchiveHeapOopmapInfo> *oopmaps, - int first_region_id, int max_num_regions, - bool print_log) { + int first_region_id, int max_num_regions) { assert(max_num_regions <= 2, "Only support maximum 2 memory regions"); int arr_len = heap_mem == NULL ? 0 : heap_mem->length(); @@ -1221,10 +1229,8 @@ total_size += size; } - if (print_log) { - log_info(cds)("Archive heap region %d " INTPTR_FORMAT " - " INTPTR_FORMAT " = " SIZE_FORMAT_W(8) " bytes", - i, p2i(start), p2i(start + size), size); - } + log_info(cds)("Archive heap region %d " INTPTR_FORMAT " - " INTPTR_FORMAT " = " SIZE_FORMAT_W(8) " bytes", + i, p2i(start), p2i(start + size), size); write_region(i, start, size, false, false); if (size > 0) { space_at(i)->init_oopmap(oopmaps->at(arr_idx)._oopmap, @@ -1237,14 +1243,13 @@ // Dump bytes to file -- at the current file position. void FileMapInfo::write_bytes(const void* buffer, size_t nbytes) { - if (_file_open) { - size_t n = os::write(_fd, buffer, (unsigned int)nbytes); - if (n != nbytes) { - // If the shared archive is corrupted, close it and remove it. - close(); - remove(_full_path); - fail_stop("Unable to write to shared archive file."); - } + assert(_file_open, "must be"); + size_t n = os::write(_fd, buffer, (unsigned int)nbytes); + if (n != nbytes) { + // If the shared archive is corrupted, close it and remove it. + close(); + remove(_full_path); + fail_stop("Unable to write to shared archive file."); } _file_offset += nbytes; } @@ -1257,20 +1262,17 @@ // Align file position to an allocation unit boundary. void FileMapInfo::align_file_position() { + assert(_file_open, "must be"); size_t new_file_offset = align_up(_file_offset, - os::vm_allocation_granularity()); + os::vm_allocation_granularity()); if (new_file_offset != _file_offset) { _file_offset = new_file_offset; - if (_file_open) { - // Seek one byte back from the target and write a byte to insure - // that the written file is the correct length. - _file_offset -= 1; - if (lseek(_fd, (long)_file_offset, SEEK_SET) < 0) { - fail_stop("Unable to seek."); - } - char zero = 0; - write_bytes(&zero, 1); - } + // Seek one byte back from the target and write a byte to insure + // that the written file is the correct length. + _file_offset -= 1; + seek_to_position(_file_offset); + char zero = 0; + write_bytes(&zero, 1); } }
--- a/src/hotspot/share/memory/filemap.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/memory/filemap.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -179,10 +179,8 @@ CompressedOops::Mode _narrow_oop_mode; // compressed oop encoding mode int _narrow_klass_shift; // save narrow klass base and shift address _narrow_klass_base; - - char* _misc_data_patching_start; - char* _read_only_tables_start; + char* _serialized_data_start; // Data accessed using {ReadClosure,WriteClosure}::serialize() address _i2i_entry_code_buffers; size_t _i2i_entry_code_buffers_size; size_t _core_spaces_size; // number of bytes allocated by the core spaces @@ -238,7 +236,7 @@ int narrow_klass_shift() const { return _narrow_klass_shift; } address narrow_klass_base() const { return _narrow_klass_base; } char* misc_data_patching_start() const { return _misc_data_patching_start; } - char* read_only_tables_start() const { return _read_only_tables_start; } + char* serialized_data_start() const { return _serialized_data_start; } address i2i_entry_code_buffers() const { return _i2i_entry_code_buffers; } size_t i2i_entry_code_buffers_size() const { return _i2i_entry_code_buffers_size; } size_t core_spaces_size() const { return _core_spaces_size; } @@ -259,7 +257,7 @@ void set_core_spaces_size(size_t s) { _core_spaces_size = s; } void set_has_platform_or_app_classes(bool v) { _has_platform_or_app_classes = v; } void set_misc_data_patching_start(char* p) { _misc_data_patching_start = p; } - void set_read_only_tables_start(char* p) { _read_only_tables_start = p; } + void set_serialized_data_start(char* p) { _serialized_data_start = p; } void set_base_archive_name_size(size_t s) { _base_archive_name_size = s; } void set_base_archive_is_default(bool b) { _base_archive_is_default = b; } void set_header_size(size_t s) { _header_size = s; } @@ -360,8 +358,8 @@ char* misc_data_patching_start() const { return header()->misc_data_patching_start(); } void set_misc_data_patching_start(char* p) const { header()->set_misc_data_patching_start(p); } - char* read_only_tables_start() const { return header()->read_only_tables_start(); } - void set_read_only_tables_start(char* p) const { header()->set_read_only_tables_start(p); } + char* serialized_data_start() const { return header()->serialized_data_start(); } + void set_serialized_data_start(char* p) const { header()->set_serialized_data_start(p); } bool is_file_position_aligned() const; void align_file_position(); @@ -412,8 +410,7 @@ bool read_only, bool allow_exec); size_t write_archive_heap_regions(GrowableArray<MemRegion> *heap_mem, GrowableArray<ArchiveHeapOopmapInfo> *oopmaps, - int first_region_id, int max_num_regions, - bool print_log); + int first_region_id, int max_num_regions); void write_bytes(const void* buffer, size_t count); void write_bytes_aligned(const void* buffer, size_t count); size_t read_bytes(void* buffer, size_t count); @@ -479,6 +476,7 @@ char* region_addr(int idx); private: + void seek_to_position(size_t pos); char* skip_first_path_entry(const char* path) NOT_CDS_RETURN_(NULL); int num_paths(const char* path) NOT_CDS_RETURN_(0); GrowableArray<const char*>* create_path_array(const char* path) NOT_CDS_RETURN_(NULL);
--- a/src/hotspot/share/memory/heapShared.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/memory/heapShared.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -583,7 +583,7 @@ for (JavaFieldStream fs(k); !fs.done(); fs.next()) { if (!fs.access_flags().is_static()) { BasicType ft = fs.field_descriptor().field_type(); - if (!fs.access_flags().is_final() && (ft == T_ARRAY || ft == T_OBJECT)) { + if (!fs.access_flags().is_final() && is_reference_type(ft)) { ResourceMark rm(THREAD); log_warning(cds, heap)( "Please check reference field in %s instance in closed archive heap region: %s %s", @@ -871,7 +871,7 @@ virtual void do_field(fieldDescriptor* fd) { if (fd->name() == _field_name) { assert(!_found, "fields cannot be overloaded"); - assert(fd->field_type() == T_OBJECT || fd->field_type() == T_ARRAY, "can archive only obj or array fields"); + assert(is_reference_type(fd->field_type()), "can archive only fields that are references"); _found = true; _offset = fd->offset(); }
--- a/src/hotspot/share/memory/metaspaceShared.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/memory/metaspaceShared.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1137,7 +1137,9 @@ VMOp_Type type() const { return VMOp_PopulateDumpSharedSpace; } void doit(); // outline because gdb sucks - static void write_region(FileMapInfo* mapinfo, int region, DumpRegion* space, bool read_only, bool allow_exec); + static void write_region(FileMapInfo* mapinfo, int region_idx, DumpRegion* dump_region, bool read_only, bool allow_exec) { + mapinfo->write_region(region_idx, dump_region->base(), dump_region->used(), read_only, allow_exec); + } bool allow_nested_vm_operations() const { return true; } }; // class VM_PopulateDumpSharedSpace @@ -1406,11 +1408,6 @@ SortedSymbolClosure* ArchiveCompactor::_ssc; ArchiveCompactor::RelocationTable* ArchiveCompactor::_new_loc_table; -void VM_PopulateDumpSharedSpace::write_region(FileMapInfo* mapinfo, int region_idx, - DumpRegion* dump_region, bool read_only, bool allow_exec) { - mapinfo->write_region(region_idx, dump_region->base(), dump_region->used(), read_only, allow_exec); -} - void VM_PopulateDumpSharedSpace::dump_symbols() { tty->print_cr("Dumping symbol table ..."); @@ -1430,12 +1427,11 @@ SystemDictionaryShared::write_to_archive(); - char* start = _ro_region.top(); - size_t vtptrs_bytes = _num_cloned_vtable_kinds * sizeof(intptr_t*); _cloned_cpp_vtptrs = (intptr_t**)_ro_region.allocate(vtptrs_bytes, sizeof(intptr_t*)); // Write the other data to the output array. + char* start = _ro_region.top(); WriteClosure wc(&_ro_region); MetaspaceShared::serialize(&wc); @@ -1518,7 +1514,7 @@ ArchiveCompactor::relocate_well_known_klasses(); - char* read_only_tables_start = dump_read_only_tables(); + char* serialized_data_start = dump_read_only_tables(); _ro_region.pack(&_md_region); char* vtbl_list = _md_region.top(); @@ -1543,47 +1539,33 @@ FileMapInfo* mapinfo = new FileMapInfo(true); mapinfo->populate_header(os::vm_allocation_granularity()); - mapinfo->set_read_only_tables_start(read_only_tables_start); + mapinfo->set_serialized_data_start(serialized_data_start); mapinfo->set_misc_data_patching_start(vtbl_list); mapinfo->set_i2i_entry_code_buffers(MetaspaceShared::i2i_entry_code_buffers(), - MetaspaceShared::i2i_entry_code_buffers_size()); + MetaspaceShared::i2i_entry_code_buffers_size()); mapinfo->set_core_spaces_size(core_spaces_size); + mapinfo->open_for_write(); - for (int pass=1; pass<=2; pass++) { - bool print_archive_log = (pass==1); - if (pass == 1) { - // The first pass doesn't actually write the data to disk. All it - // does is to update the fields in the mapinfo->_header. - } else { - // After the first pass, the contents of mapinfo->_header are finalized, - // so we can compute the header's CRC, and write the contents of the header - // and the regions into disk. - mapinfo->open_for_write(); - mapinfo->set_header_crc(mapinfo->compute_header_crc()); - } - mapinfo->write_header(); + // NOTE: md contains the trampoline code for method entries, which are patched at run time, + // so it needs to be read/write. + write_region(mapinfo, MetaspaceShared::mc, &_mc_region, /*read_only=*/false,/*allow_exec=*/true); + write_region(mapinfo, MetaspaceShared::rw, &_rw_region, /*read_only=*/false,/*allow_exec=*/false); + write_region(mapinfo, MetaspaceShared::ro, &_ro_region, /*read_only=*/true, /*allow_exec=*/false); + write_region(mapinfo, MetaspaceShared::md, &_md_region, /*read_only=*/false,/*allow_exec=*/false); - // NOTE: md contains the trampoline code for method entries, which are patched at run time, - // so it needs to be read/write. - write_region(mapinfo, MetaspaceShared::mc, &_mc_region, /*read_only=*/false,/*allow_exec=*/true); - write_region(mapinfo, MetaspaceShared::rw, &_rw_region, /*read_only=*/false,/*allow_exec=*/false); - write_region(mapinfo, MetaspaceShared::ro, &_ro_region, /*read_only=*/true, /*allow_exec=*/false); - write_region(mapinfo, MetaspaceShared::md, &_md_region, /*read_only=*/false,/*allow_exec=*/false); - - _total_closed_archive_region_size = mapinfo->write_archive_heap_regions( + _total_closed_archive_region_size = mapinfo->write_archive_heap_regions( _closed_archive_heap_regions, _closed_archive_heap_oopmaps, MetaspaceShared::first_closed_archive_heap_region, - MetaspaceShared::max_closed_archive_heap_region, - print_archive_log); - _total_open_archive_region_size = mapinfo->write_archive_heap_regions( + MetaspaceShared::max_closed_archive_heap_region); + _total_open_archive_region_size = mapinfo->write_archive_heap_regions( _open_archive_heap_regions, _open_archive_heap_oopmaps, MetaspaceShared::first_open_archive_heap_region, - MetaspaceShared::max_open_archive_heap_region, - print_archive_log); - } + MetaspaceShared::max_open_archive_heap_region); + mapinfo->set_header_crc(mapinfo->compute_header_crc()); + mapinfo->write_header(); mapinfo->close(); // Restore the vtable in case we invoke any virtual methods. @@ -2050,14 +2032,9 @@ char* buffer = mapinfo->misc_data_patching_start(); clone_cpp_vtables((intptr_t*)buffer); - // The rest of the data is now stored in the RW region - buffer = mapinfo->read_only_tables_start(); - - // Skip over _cloned_cpp_vtptrs; - buffer += _num_cloned_vtable_kinds * sizeof(intptr_t*); - // Verify various attributes of the archive, plus initialize the // shared string/symbol tables + buffer = mapinfo->serialized_data_start(); intptr_t* array = (intptr_t*)buffer; ReadClosure rc(&array); serialize(&rc);
--- a/src/hotspot/share/oops/constantPool.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/oops/constantPool.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -556,7 +556,8 @@ Handle h_loader (thread, loader); Klass* k = SystemDictionary::find(name, h_loader, h_prot, thread); - if (k != NULL) { + // Avoid constant pool verification at a safepoint, which takes the Module_lock. + if (k != NULL && !SafepointSynchronize::is_at_safepoint()) { // Make sure that resolving is legal EXCEPTION_MARK; // return NULL if verification fails
--- a/src/hotspot/share/oops/method.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/oops/method.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -603,7 +603,7 @@ void compute_size_of_parameters(Thread *thread); // word size of parameters (receiver if any + arguments) Symbol* klass_name() const; // returns the name of the method holder BasicType result_type() const; // type of the method result - bool is_returning_oop() const { BasicType r = result_type(); return (r == T_OBJECT || r == T_ARRAY); } + bool is_returning_oop() const { BasicType r = result_type(); return is_reference_type(r); } bool is_returning_fp() const { BasicType r = result_type(); return (r == T_FLOAT || r == T_DOUBLE); } // Checked exceptions thrown by this method (resolved to mirrors)
--- a/src/hotspot/share/oops/methodData.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/oops/methodData.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -216,7 +216,7 @@ args_cell = TypeStackSlotEntries::compute_cell_count(inv.signature(), false, TypeProfileArgsLimit); } int ret_cell = 0; - if (MethodData::profile_return_for_invoke(m, bci) && (inv.result_type() == T_OBJECT || inv.result_type() == T_ARRAY)) { + if (MethodData::profile_return_for_invoke(m, bci) && is_reference_type(inv.result_type())) { ret_cell = ReturnTypeEntry::static_cell_count(); } int header_cell = 0; @@ -289,7 +289,7 @@ } if (has_return()) { - assert(inv.result_type() == T_OBJECT || inv.result_type() == T_ARRAY, "room for a ret type but doesn't return obj?"); + assert(is_reference_type(inv.result_type()), "room for a ret type but doesn't return obj?"); _ret.post_initialize(); } } @@ -310,7 +310,7 @@ } if (has_return()) { - assert(inv.result_type() == T_OBJECT || inv.result_type() == T_ARRAY, "room for a ret type but doesn't return obj?"); + assert(is_reference_type(inv.result_type()), "room for a ret type but doesn't return obj?"); _ret.post_initialize(); } }
--- a/src/hotspot/share/opto/arraycopynode.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/opto/arraycopynode.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -268,8 +268,8 @@ BasicType src_elem = ary_src->klass()->as_array_klass()->element_type()->basic_type(); BasicType dest_elem = ary_dest->klass()->as_array_klass()->element_type()->basic_type(); - if (src_elem == T_ARRAY) src_elem = T_OBJECT; - if (dest_elem == T_ARRAY) dest_elem = T_OBJECT; + if (is_reference_type(src_elem)) src_elem = T_OBJECT; + if (is_reference_type(dest_elem)) dest_elem = T_OBJECT; if (src_elem != dest_elem || dest_elem == T_VOID) { // We don't know if arguments are arrays of the same type @@ -328,7 +328,7 @@ assert(phase->type(src->in(AddPNode::Offset))->is_intptr_t()->get_con() == phase->type(dest->in(AddPNode::Offset))->is_intptr_t()->get_con(), "same start offset?"); BasicType elem = ary_src->klass()->as_array_klass()->element_type()->basic_type(); - if (elem == T_ARRAY) elem = T_OBJECT; + if (is_reference_type(elem)) elem = T_OBJECT; BarrierSetC2* bs = BarrierSet::barrier_set()->barrier_set_c2(); if (bs->array_copy_requires_gc_barriers(true, elem, true, BarrierSetC2::Optimization)) {
--- a/src/hotspot/share/opto/doCall.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/opto/doCall.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 1998, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1998, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -702,8 +702,8 @@ } else if (rt == T_INT || is_subword_type(rt)) { // Nothing. These cases are handled in lambda form bytecode. assert(ct == T_INT || is_subword_type(ct), "must match: rt=%s, ct=%s", type2name(rt), type2name(ct)); - } else if (rt == T_OBJECT || rt == T_ARRAY) { - assert(ct == T_OBJECT || ct == T_ARRAY, "rt=%s, ct=%s", type2name(rt), type2name(ct)); + } else if (is_reference_type(rt)) { + assert(is_reference_type(ct), "rt=%s, ct=%s", type2name(rt), type2name(ct)); if (ctype->is_loaded()) { const TypeOopPtr* arg_type = TypeOopPtr::make_from_klass(rtype->as_klass()); const Type* sig_type = TypeOopPtr::make_from_klass(ctype->as_klass()); @@ -750,7 +750,7 @@ set_bci(iter().cur_bci()); // put it back } BasicType ct = ctype->basic_type(); - if (ct == T_OBJECT || ct == T_ARRAY) { + if (is_reference_type(ct)) { record_profiled_return_for_speculation(); } }
--- a/src/hotspot/share/opto/escape.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/opto/escape.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -2113,7 +2113,8 @@ } } } - return (bt == T_OBJECT || bt == T_NARROWOOP || bt == T_ARRAY); + // Note: T_NARROWOOP is not classed as a real reference type + return (is_reference_type(bt) || bt == T_NARROWOOP); } // Returns unique pointed java object or NULL.
--- a/src/hotspot/share/opto/graphKit.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/opto/graphKit.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -2276,7 +2276,7 @@ int skip = Bytecodes::has_receiver(bc) ? 1 : 0; for (int j = skip, i = 0; j < nargs && i < TypeProfileArgsLimit; j++) { const Type *targ = tf->domain()->field_at(j + TypeFunc::Parms); - if (targ->basic_type() == T_OBJECT || targ->basic_type() == T_ARRAY) { + if (is_reference_type(targ->basic_type())) { ProfilePtrKind ptr_kind = ProfileMaybeNull; ciKlass* better_type = NULL; if (method()->argument_profiled_type(bci(), i, better_type, ptr_kind)) {
--- a/src/hotspot/share/opto/library_call.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/opto/library_call.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -2382,7 +2382,7 @@ guarantee( is_store || kind != Release, "Release accesses can be produced only for stores"); assert(type != T_OBJECT || !unaligned, "unaligned access not supported with object type"); - if (type == T_OBJECT || type == T_ARRAY) { + if (is_reference_type(type)) { decorators |= ON_UNKNOWN_OOP_REF; } @@ -2730,7 +2730,7 @@ Compile::AliasType* alias_type = C->alias_type(adr_type); BasicType bt = alias_type->basic_type(); if (bt != T_ILLEGAL && - ((bt == T_OBJECT || bt == T_ARRAY) != (type == T_OBJECT))) { + (is_reference_type(bt) != (type == T_OBJECT))) { // Don't intrinsify mismatched object accesses. return false; } @@ -2767,7 +2767,7 @@ int alias_idx = C->get_alias_index(adr_type); - if (type == T_OBJECT || type == T_ARRAY) { + if (is_reference_type(type)) { decorators |= IN_HEAP | ON_UNKNOWN_OOP_REF; // Transformation of a value which could be NULL pointer (CastPP #NULL) @@ -4817,8 +4817,8 @@ if (has_src && has_dest && can_emit_guards) { BasicType src_elem = top_src->klass()->as_array_klass()->element_type()->basic_type(); BasicType dest_elem = top_dest->klass()->as_array_klass()->element_type()->basic_type(); - if (src_elem == T_ARRAY) src_elem = T_OBJECT; - if (dest_elem == T_ARRAY) dest_elem = T_OBJECT; + if (is_reference_type(src_elem)) src_elem = T_OBJECT; + if (is_reference_type(dest_elem)) dest_elem = T_OBJECT; if (src_elem == dest_elem && src_elem == T_OBJECT) { // If both arrays are object arrays then having the exact types
--- a/src/hotspot/share/opto/loopopts.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/opto/loopopts.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1443,6 +1443,20 @@ // Such nodes should only have ProjNodes as outs, e.g. IfNode // should only have IfTrueNode and IfFalseNode (4985384). x_ctrl = find_non_split_ctrl(x_ctrl); + + IdealLoopTree* x_loop = get_loop(x_ctrl); + Node* x_head = x_loop->_head; + if (x_head->is_Loop() && (x_head->is_OuterStripMinedLoop() || x_head->as_Loop()->is_strip_mined()) && is_dominator(n_ctrl, x_head)) { + // Anti dependence analysis is sometimes too + // conservative: a store in the outer strip mined loop + // can prevent a load from floating out of the outer + // strip mined loop but the load may not be referenced + // from the safepoint: loop strip mining verification + // code reports a problem in that case. Make sure the + // load is not moved in the outer strip mined loop in + // that case. + x_ctrl = x_head->as_Loop()->skip_strip_mined()->in(LoopNode::EntryControl); + } assert(dom_depth(n_ctrl) <= dom_depth(x_ctrl), "n is later than its clone"); x->set_req(0, x_ctrl); @@ -1718,7 +1732,7 @@ #ifdef ASSERT if (loop->_head->as_Loop()->is_strip_mined() && outer_loop->is_member(use_loop) && !loop->is_member(use_loop) && old_new[use->_idx] == NULL) { Node* sfpt = loop->_head->as_CountedLoop()->outer_safepoint(); - assert(mode == ControlAroundStripMined && use == sfpt, "missed a node"); + assert(mode == ControlAroundStripMined && (use == sfpt || !use->is_reachable_from_root()), "missed a node"); } #endif if (!loop->is_member(use_loop) && !outer_loop->is_member(use_loop) && (!old->is_CFG() || !use->is_CFG())) {
--- a/src/hotspot/share/opto/macro.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/opto/macro.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2005, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2005, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -791,7 +791,7 @@ const Type *field_type; // The next code is taken from Parse::do_get_xxx(). - if (basic_elem_type == T_OBJECT || basic_elem_type == T_ARRAY) { + if (is_reference_type(basic_elem_type)) { if (!elem_type->is_loaded()) { field_type = TypeInstPtr::BOTTOM; } else if (field != NULL && field->is_static_constant()) {
--- a/src/hotspot/share/opto/macroArrayCopy.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/opto/macroArrayCopy.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012, 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2012, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -1149,8 +1149,8 @@ if (top_src != NULL && top_src->klass() != NULL) { src_elem = top_src->klass()->as_array_klass()->element_type()->basic_type(); } - if (src_elem == T_ARRAY) src_elem = T_OBJECT; - if (dest_elem == T_ARRAY) dest_elem = T_OBJECT; + if (is_reference_type(src_elem)) src_elem = T_OBJECT; + if (is_reference_type(dest_elem)) dest_elem = T_OBJECT; if (ac->is_arraycopy_validated() && dest_elem != T_CONFLICT &&
--- a/src/hotspot/share/opto/node.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/opto/node.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -704,9 +704,26 @@ dump(); return true; } + +bool Node::is_reachable_from_root() const { + ResourceMark rm; + Unique_Node_List wq; + wq.push((Node*)this); + RootNode* root = Compile::current()->root(); + for (uint i = 0; i < wq.size(); i++) { + Node* m = wq.at(i); + if (m == root) { + return true; + } + for (DUIterator_Fast jmax, j = m->fast_outs(jmax); j < jmax; j++) { + Node* u = m->fast_out(j); + wq.push(u); + } + } + return false; +} #endif - //------------------------------is_unreachable--------------------------------- bool Node::is_unreachable(PhaseIterGVN &igvn) const { assert(!is_Mach(), "doesn't work with MachNodes");
--- a/src/hotspot/share/opto/node.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/opto/node.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -394,6 +394,7 @@ #ifdef ASSERT bool is_dead() const; #define is_not_dead(n) ((n) == NULL || !VerifyIterativeGVN || !((n)->is_dead())) + bool is_reachable_from_root() const; #endif // Check whether node has become unreachable bool is_unreachable(PhaseIterGVN &igvn) const;
--- a/src/hotspot/share/opto/parse3.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/opto/parse3.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 1998, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1998, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -139,7 +139,7 @@ DecoratorSet decorators = IN_HEAP; decorators |= is_vol ? MO_SEQ_CST : MO_UNORDERED; - bool is_obj = bt == T_OBJECT || bt == T_ARRAY; + bool is_obj = is_reference_type(bt); if (is_obj) { if (!field->type()->is_loaded()) { @@ -210,7 +210,7 @@ DecoratorSet decorators = IN_HEAP; decorators |= is_vol ? MO_SEQ_CST : MO_UNORDERED; - bool is_obj = bt == T_OBJECT || bt == T_ARRAY; + bool is_obj = is_reference_type(bt); // Store the value. const Type* field_type;
--- a/src/hotspot/share/opto/type.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/opto/type.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -3004,15 +3004,13 @@ ciField* field = k->get_field_by_offset(_offset, true); assert(field != NULL, "missing field"); BasicType basic_elem_type = field->layout_type(); - _is_ptr_to_narrowoop = UseCompressedOops && (basic_elem_type == T_OBJECT || - basic_elem_type == T_ARRAY); + _is_ptr_to_narrowoop = UseCompressedOops && is_reference_type(basic_elem_type); } else { // Instance fields which contains a compressed oop references. field = ik->get_field_by_offset(_offset, false); if (field != NULL) { BasicType basic_elem_type = field->layout_type(); - _is_ptr_to_narrowoop = UseCompressedOops && (basic_elem_type == T_OBJECT || - basic_elem_type == T_ARRAY); + _is_ptr_to_narrowoop = UseCompressedOops && is_reference_type(basic_elem_type); } else if (klass()->equals(ciEnv::current()->Object_klass())) { // Compile::find_alias_type() cast exactness on all types to verify // that it does not affect alias type.
--- a/src/hotspot/share/prims/jni.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/prims/jni.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1104,7 +1104,7 @@ JavaCalls::call(result, method, &java_args, CHECK); // Convert result - if (result->get_type() == T_OBJECT || result->get_type() == T_ARRAY) { + if (is_reference_type(result->get_type())) { result->set_jobject(JNIHandles::make_local(env, (oop) result->get_jobject())); } } @@ -1167,7 +1167,7 @@ JavaCalls::call(result, method, &java_args, CHECK); // Convert result - if (result->get_type() == T_OBJECT || result->get_type() == T_ARRAY) { + if (is_reference_type(result->get_type())) { result->set_jobject(JNIHandles::make_local(env, (oop) result->get_jobject())); } }
--- a/src/hotspot/share/prims/jvm.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/prims/jvm.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -773,7 +773,7 @@ JVMWrapper("JVM_FindPrimitiveClass"); oop mirror = NULL; BasicType t = name2type(utf); - if (t != T_ILLEGAL && t != T_OBJECT && t != T_ARRAY) { + if (t != T_ILLEGAL && !is_reference_type(t)) { mirror = Universe::java_mirror(t); } if (mirror == NULL) {
--- a/src/hotspot/share/prims/jvmtiExport.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/prims/jvmtiExport.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1589,7 +1589,7 @@ if (!exception_exit) { oop oop_result; BasicType type = current_frame.interpreter_frame_result(&oop_result, &value); - if (type == T_OBJECT || type == T_ARRAY) { + if (is_reference_type(type)) { result = Handle(thread, oop_result); } }
--- a/src/hotspot/share/prims/methodHandles.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/prims/methodHandles.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -573,7 +573,7 @@ if (is_subword_type(bt)) { bsig = vmSymbols::int_signature(); } else { - assert(bt == T_OBJECT || bt == T_ARRAY, "is_basic_type_signature was false"); + assert(is_reference_type(bt), "is_basic_type_signature was false"); bsig = vmSymbols::object_signature(); } } else { @@ -592,7 +592,7 @@ if (arg_pos == keep_arg_pos) { buffer.write((char*) ss.raw_bytes(), (int) ss.raw_length()); - } else if (bt == T_OBJECT || bt == T_ARRAY) { + } else if (is_reference_type(bt)) { buffer.write(OBJ_SIG, OBJ_SIG_LEN); } else { if (is_subword_type(bt))
--- a/src/hotspot/share/prims/unsafe.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/prims/unsafe.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -669,7 +669,7 @@ ClassLoader::unsafe_defineClassCallCounter()->inc(); } - body = NEW_C_HEAP_ARRAY(jbyte, length, mtInternal); + body = NEW_C_HEAP_ARRAY_RETURN_NULL(jbyte, length, mtInternal); if (body == NULL) { throw_new(env, "java/lang/OutOfMemoryError"); return 0; @@ -685,7 +685,7 @@ int unicode_len = env->GetStringLength(name); if (len >= sizeof(buf)) { - utfName = NEW_C_HEAP_ARRAY(char, len + 1, mtInternal); + utfName = NEW_C_HEAP_ARRAY_RETURN_NULL(char, len + 1, mtInternal); if (utfName == NULL) { throw_new(env, "java/lang/OutOfMemoryError"); goto free_body; @@ -790,7 +790,7 @@ int class_bytes_length = (int) length; - u1* class_bytes = NEW_C_HEAP_ARRAY(u1, length, mtInternal); + u1* class_bytes = NEW_C_HEAP_ARRAY_RETURN_NULL(u1, length, mtInternal); if (class_bytes == NULL) { THROW_0(vmSymbols::java_lang_OutOfMemoryError()); }
--- a/src/hotspot/share/runtime/arguments.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/runtime/arguments.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -82,7 +82,6 @@ bool Arguments::_xdebug_mode = false; const char* Arguments::_java_vendor_url_bug = DEFAULT_VENDOR_URL_BUG; const char* Arguments::_sun_java_launcher = DEFAULT_JAVA_LAUNCHER; -int Arguments::_sun_java_launcher_pid = -1; bool Arguments::_sun_java_launcher_is_altjvm = false; // These parameters are reset in method parse_vm_init_args() @@ -361,8 +360,7 @@ // Process java launcher properties. void Arguments::process_sun_java_launcher_properties(JavaVMInitArgs* args) { - // See if sun.java.launcher, sun.java.launcher.is_altjvm or - // sun.java.launcher.pid is defined. + // See if sun.java.launcher or sun.java.launcher.is_altjvm is defined. // Must do this before setting up other system properties, // as some of them may depend on launcher type. for (int index = 0; index < args->nOptions; index++) { @@ -379,10 +377,6 @@ } continue; } - if (match_option(option, "-Dsun.java.launcher.pid=", &tail)) { - _sun_java_launcher_pid = atoi(tail); - continue; - } } } @@ -1411,10 +1405,9 @@ if (strcmp(key, "java.compiler") == 0) { process_java_compiler_argument(value); // Record value in Arguments, but let it get passed to Java. - } else if (strcmp(key, "sun.java.launcher.is_altjvm") == 0 || - strcmp(key, "sun.java.launcher.pid") == 0) { - // sun.java.launcher.is_altjvm and sun.java.launcher.pid property are - // private and are processed in process_sun_java_launcher_properties(); + } else if (strcmp(key, "sun.java.launcher.is_altjvm") == 0) { + // sun.java.launcher.is_altjvm property is + // private and is processed in process_sun_java_launcher_properties(); // the sun.java.launcher property is passed on to the java application } else if (strcmp(key, "sun.boot.library.path") == 0) { // append is true, writable is true, internal is false @@ -3479,10 +3472,8 @@ size_t file_sep_len = strlen(os::file_separator()); const size_t len = jvm_path_len + file_sep_len + 20; default_archive_path = NEW_C_HEAP_ARRAY(char, len, mtArguments); - if (default_archive_path != NULL) { - jio_snprintf(default_archive_path, len, "%s%sclasses.jsa", - jvm_path, os::file_separator()); - } + jio_snprintf(default_archive_path, len, "%s%sclasses.jsa", + jvm_path, os::file_separator()); return default_archive_path; }
--- a/src/hotspot/share/runtime/arguments.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/runtime/arguments.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -322,9 +322,6 @@ // java launcher static const char* _sun_java_launcher; - // sun.java.launcher.pid, private property - static int _sun_java_launcher_pid; - // was this VM created via the -XXaltjvm=<path> option static bool _sun_java_launcher_is_altjvm; @@ -548,8 +545,6 @@ static bool created_by_java_launcher(); // -Dsun.java.launcher.is_altjvm static bool sun_java_launcher_is_altjvm(); - // -Dsun.java.launcher.pid - static int sun_java_launcher_pid() { return _sun_java_launcher_pid; } // -Xrun static AgentLibrary* libraries() { return _libraryList.first(); }
--- a/src/hotspot/share/runtime/fieldDescriptor.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/runtime/fieldDescriptor.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -212,7 +212,7 @@ // Print a hint as to the underlying integer representation. This can be wrong for // pointers on an LP64 machine #ifdef _LP64 - if ((ft == T_OBJECT || ft == T_ARRAY) && UseCompressedOops) { + if (is_reference_type(ft) && UseCompressedOops) { st->print(" (%x)", obj->int_field(offset())); } else // <- intended
--- a/src/hotspot/share/runtime/frame.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/runtime/frame.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -723,7 +723,7 @@ void set(int size, BasicType type) { _offset -= size; - if (type == T_OBJECT || type == T_ARRAY) oop_offset_do(); + if (is_reference_type(type)) oop_offset_do(); } void oop_offset_do() { @@ -776,7 +776,7 @@ void set(int size, BasicType type) { assert (_offset >= 0, "illegal offset"); - if (type == T_OBJECT || type == T_ARRAY) oop_at_offset_do(_offset); + if (is_reference_type(type)) oop_at_offset_do(_offset); _offset -= size; } @@ -927,7 +927,7 @@ VMRegPair* _regs; // VMReg list of arguments void set(int size, BasicType type) { - if (type == T_OBJECT || type == T_ARRAY) handle_oop_offset(); + if (is_reference_type(type)) handle_oop_offset(); _offset += size; }
--- a/src/hotspot/share/runtime/javaCalls.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/runtime/javaCalls.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -390,7 +390,7 @@ // Figure out if the result value is an oop or not (Note: This is a different value // than result_type. result_type will be T_INT of oops. (it is about size) BasicType result_type = runtime_type_from(result); - bool oop_result_flag = (result->get_type() == T_OBJECT || result->get_type() == T_ARRAY); + bool oop_result_flag = is_reference_type(result->get_type()); // Find receiver Handle receiver = (!method->is_static()) ? args->receiver() : Handle(); @@ -619,7 +619,7 @@ guarantee(method->size_of_parameters() == size_of_parameters(), "wrong no. of arguments pushed"); // Treat T_OBJECT and T_ARRAY as the same - if (return_type == T_ARRAY) return_type = T_OBJECT; + if (is_reference_type(return_type)) return_type = T_OBJECT; // Check that oop information is correct Symbol* signature = method->signature();
--- a/src/hotspot/share/runtime/mutex.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/runtime/mutex.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -33,24 +33,46 @@ #include "utilities/macros.hpp" #ifdef ASSERT -void Mutex::check_safepoint_state(Thread* thread, bool do_safepoint_check) { +void Mutex::check_block_state(Thread* thread) { + if (!_allow_vm_block && thread->is_VM_thread()) { + // JavaThreads are checked to make sure that they do not hold _allow_vm_block locks during operations + // that could safepoint. Make sure the vm thread never uses locks with _allow_vm_block == false. + fatal("VM thread could block on lock that may be held by a JavaThread during safepoint: %s", name()); + } + + assert(!os::ThreadCrashProtection::is_crash_protected(thread), + "locking not allowed when crash protection is set"); +} + +void Mutex::check_safepoint_state(Thread* thread) { + check_block_state(thread); + // If the JavaThread checks for safepoint, verify that the lock wasn't created with safepoint_check_never. - SafepointCheckRequired not_allowed = do_safepoint_check ? Mutex::_safepoint_check_never : - Mutex::_safepoint_check_always; - assert(!thread->is_active_Java_thread() || _safepoint_check_required != not_allowed, + if (thread->is_active_Java_thread()) { + assert(_safepoint_check_required != _safepoint_check_never, + "This lock should %s have a safepoint check for Java threads: %s", + _safepoint_check_required ? "always" : "never", name()); + + // Also check NoSafepointVerifier, and thread state is _thread_in_vm + thread->check_for_valid_safepoint_state(); + } else { + // If initialized with safepoint_check_never, a NonJavaThread should never ask to safepoint check either. + assert(_safepoint_check_required != _safepoint_check_never, + "NonJavaThread should not check for safepoint"); + } +} + +void Mutex::check_no_safepoint_state(Thread* thread) { + check_block_state(thread); + assert(!thread->is_active_Java_thread() || _safepoint_check_required != _safepoint_check_always, "This lock should %s have a safepoint check for Java threads: %s", _safepoint_check_required ? "always" : "never", name()); - - // If defined with safepoint_check_never, a NonJavaThread should never ask to safepoint check either. - assert(thread->is_Java_thread() || !do_safepoint_check || _safepoint_check_required != Mutex::_safepoint_check_never, - "NonJavaThread should not check for safepoint"); } #endif // ASSERT -void Mutex::lock(Thread * self) { - check_safepoint_state(self, true); +void Mutex::lock(Thread* self) { + check_safepoint_state(self); - DEBUG_ONLY(check_prelock_state(self, true)); assert(_owner != self, "invariant"); Mutex* in_flight_mutex = NULL; @@ -60,7 +82,6 @@ // The lock is contended #ifdef ASSERT - check_block_state(self); if (retry_cnt++ > 3) { log_trace(vmmutex)("JavaThread " INTPTR_FORMAT " on %d attempt trying to acquire vmmutex %s", p2i(self), retry_cnt, _name); } @@ -98,7 +119,7 @@ // in the wrong way this can lead to a deadlock with the safepoint code. void Mutex::lock_without_safepoint_check(Thread * self) { - check_safepoint_state(self, false); + check_no_safepoint_state(self); assert(_owner != self, "invariant"); _lock.lock(); assert_owner(NULL); @@ -114,8 +135,9 @@ bool Mutex::try_lock() { Thread * const self = Thread::current(); - DEBUG_ONLY(check_prelock_state(self, false);) - + // Some safepoint_check_always locks use try_lock, so cannot check + // safepoint state, but can check blocking state. + check_block_state(self); if (_lock.try_lock()) { assert_owner(NULL); set_owner(self); @@ -160,7 +182,6 @@ bool Monitor::wait_without_safepoint_check(long timeout) { Thread* const self = Thread::current(); - check_safepoint_state(self, false); // timeout is in milliseconds - with zero meaning never timeout assert(timeout >= 0, "negative timeout"); @@ -171,6 +192,9 @@ // conceptually set the owner to NULL in anticipation of // abdicating the lock in wait set_owner(NULL); + // Check safepoint state after resetting owner and possible NSV. + check_no_safepoint_state(self); + int wait_status = _lock.wait(timeout); set_owner(self); return wait_status != 0; // return true IFF timeout @@ -178,7 +202,6 @@ bool Monitor::wait(long timeout, bool as_suspend_equivalent) { Thread* const self = Thread::current(); - check_safepoint_state(self, true); // timeout is in milliseconds - with zero meaning never timeout assert(timeout >= 0, "negative timeout"); @@ -193,6 +216,8 @@ // conceptually set the owner to NULL in anticipation of // abdicating the lock in wait set_owner(NULL); + // Check safepoint state after resetting owner and possible NSV. + check_safepoint_state(self); JavaThread *jt = (JavaThread *)self; Mutex* in_flight_mutex = NULL; @@ -255,7 +280,7 @@ _rank = Rank; _safepoint_check_required = safepoint_check_required; - assert(_safepoint_check_required != Mutex::_safepoint_check_sometimes || is_sometimes_ok(name), + assert(_safepoint_check_required != _safepoint_check_sometimes || is_sometimes_ok(name), "Lock has _safepoint_check_sometimes %s", name); #endif } @@ -278,15 +303,27 @@ // Non-product code #ifndef PRODUCT +const char* print_safepoint_check(Mutex::SafepointCheckRequired safepoint_check) { + switch (safepoint_check) { + case Mutex::_safepoint_check_never: return "safepoint_check_never"; + case Mutex::_safepoint_check_sometimes: return "safepoint_check_sometimes"; + case Mutex::_safepoint_check_always: return "safepoint_check_always"; + default: return ""; + } +} + void Mutex::print_on(outputStream* st) const { - st->print_cr("Mutex: [" PTR_FORMAT "] %s - owner: " PTR_FORMAT, - p2i(this), _name, p2i(_owner)); + st->print("Mutex: [" PTR_FORMAT "] %s - owner: " PTR_FORMAT, + p2i(this), _name, p2i(_owner)); + if (_allow_vm_block) { + st->print("%s", " allow_vm_block"); + } + st->print(" %s", print_safepoint_check(_safepoint_check_required)); + st->cr(); } #endif -#ifndef PRODUCT #ifdef ASSERT - void Mutex::assert_owner(Thread * expected) { const char* msg = "invalid owner"; if (expected == NULL) { @@ -340,7 +377,6 @@ return res; } - bool Mutex::contains(Mutex* locks, Mutex* lock) { for (; locks != NULL; locks = locks->next()) { if (locks == lock) { @@ -349,7 +385,27 @@ } return false; } -#endif + +// NSV implied with locking allow_vm_block or !safepoint_check locks. +void Mutex::no_safepoint_verifier(Thread* thread, bool enable) { + // Threads_lock is special, since the safepoint synchronization will not start before this is + // acquired. Hence, a JavaThread cannot be holding it at a safepoint. So is VMOperationRequest_lock, + // since it is used to transfer control between JavaThreads and the VMThread + // Do not *exclude* any locks unless you are absolutely sure it is correct. Ask someone else first! + if ((_allow_vm_block && + this != Threads_lock && + this != Compile_lock && // Temporary: should not be necessary when we get separate compilation + this != tty_lock && // The tty_lock is released for the safepoint. + this != VMOperationRequest_lock && + this != VMOperationQueue_lock) || + rank() == Mutex::special) { + if (enable) { + thread->_no_safepoint_count++; + } else { + thread->_no_safepoint_count--; + } + } +} // Called immediately after lock acquisition or release as a diagnostic // to track the lock-set of the thread and test for rank violations that @@ -376,7 +432,6 @@ // link "this" into the owned locks list -#ifdef ASSERT // Thread::_owned_locks is under the same ifdef Mutex* locks = get_least_ranked_lock(new_owner->owned_locks()); // Mutex::set_owner_implementation is a friend of Thread @@ -401,20 +456,21 @@ this->_next = new_owner->_owned_locks; new_owner->_owned_locks = this; -#endif + + // NSV implied with locking allow_vm_block flag. + no_safepoint_verifier(new_owner, true); } else { // the thread is releasing this lock Thread* old_owner = _owner; - DEBUG_ONLY(_last_owner = old_owner;) + _last_owner = old_owner; assert(old_owner != NULL, "removing the owner thread of an unowned mutex"); assert(old_owner == Thread::current(), "removing the owner thread of an unowned mutex"); _owner = NULL; // set the owner -#ifdef ASSERT Mutex* locks = old_owner->owned_locks(); // remove "this" from the owned locks list @@ -434,33 +490,9 @@ prev->_next = _next; } _next = NULL; -#endif + + // ~NSV implied with locking allow_vm_block flag. + no_safepoint_verifier(old_owner, false); } } - - -// Factored out common sanity checks for locking mutex'es. Used by lock() and try_lock() -void Mutex::check_prelock_state(Thread *thread, bool safepoint_check) { - if (safepoint_check) { - assert((!thread->is_active_Java_thread() || ((JavaThread *)thread)->thread_state() == _thread_in_vm) - || rank() == Mutex::special, "wrong thread state for using locks"); - if (thread->is_VM_thread() && !allow_vm_block()) { - fatal("VM thread using lock %s (not allowed to block on)", name()); - } - DEBUG_ONLY(if (rank() != Mutex::special) \ - thread->check_for_valid_safepoint_state(false);) - } - assert(!os::ThreadCrashProtection::is_crash_protected(thread), - "locking not allowed when crash protection is set"); -} - -void Mutex::check_block_state(Thread *thread) { - if (!_allow_vm_block && thread->is_VM_thread()) { - warning("VM thread blocked on lock"); - print(); - BREAKPOINT; - } - assert(_owner != thread, "deadlock: blocking on mutex owned by current thread"); -} - -#endif // PRODUCT +#endif // ASSERT
--- a/src/hotspot/share/runtime/mutex.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/runtime/mutex.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -81,21 +81,22 @@ char _name[MUTEX_NAME_LEN]; // Name of mutex/monitor // Debugging fields for naming, deadlock detection, etc. (some only used in debug mode) -#ifndef PRODUCT - bool _allow_vm_block; - DEBUG_ONLY(int _rank;) // rank (to avoid/detect potential deadlocks) - DEBUG_ONLY(Mutex* _next;) // Used by a Thread to link up owned locks - DEBUG_ONLY(Thread* _last_owner;) // the last thread to own the lock - DEBUG_ONLY(static bool contains(Mutex* locks, Mutex* lock);) - DEBUG_ONLY(static Mutex* get_least_ranked_lock(Mutex* locks);) - DEBUG_ONLY(Mutex* get_least_ranked_lock_besides_this(Mutex* locks);) -#endif +#ifdef ASSERT + bool _allow_vm_block; + int _rank; // rank (to avoid/detect potential deadlocks) + Mutex* _next; // Used by a Thread to link up owned locks + Thread* _last_owner; // the last thread to own the lock + static bool contains(Mutex* locks, Mutex* lock); + static Mutex* get_least_ranked_lock(Mutex* locks); + Mutex* get_least_ranked_lock_besides_this(Mutex* locks); +#endif // ASSERT - void set_owner_implementation(Thread* owner) PRODUCT_RETURN; - void check_prelock_state (Thread* thread, bool safepoint_check) PRODUCT_RETURN; - void check_block_state (Thread* thread) PRODUCT_RETURN; - void check_safepoint_state (Thread* thread, bool safepoint_check) NOT_DEBUG_RETURN; + void set_owner_implementation(Thread* owner) NOT_DEBUG({ _owner = owner;}); + void check_block_state (Thread* thread) NOT_DEBUG_RETURN; + void check_safepoint_state (Thread* thread) NOT_DEBUG_RETURN; + void check_no_safepoint_state(Thread* thread) NOT_DEBUG_RETURN; void assert_owner (Thread* expected) NOT_DEBUG_RETURN; + void no_safepoint_verifier (Thread* thread, bool enable) NOT_DEBUG_RETURN; public: enum { @@ -171,21 +172,16 @@ #ifndef PRODUCT void print_on(outputStream* st) const; void print() const { print_on(::tty); } - DEBUG_ONLY(int rank() const { return _rank; }) - bool allow_vm_block() { return _allow_vm_block; } - - DEBUG_ONLY(Mutex *next() const { return _next; }) - DEBUG_ONLY(void set_next(Mutex *next) { _next = next; }) #endif + #ifdef ASSERT + int rank() const { return _rank; } + bool allow_vm_block() { return _allow_vm_block; } - void set_owner(Thread* owner) { - #ifndef PRODUCT - set_owner_implementation(owner); - DEBUG_ONLY(void verify_mutex(Thread* thr);) - #else - _owner = owner; - #endif - } + Mutex *next() const { return _next; } + void set_next(Mutex *next) { _next = next; } + #endif // ASSERT + + void set_owner(Thread* owner) { set_owner_implementation(owner); } }; class Monitor : public Mutex {
--- a/src/hotspot/share/runtime/mutexLocker.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/runtime/mutexLocker.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -230,7 +230,7 @@ def(OopMapCacheAlloc_lock , PaddedMutex , leaf, true, Monitor::_safepoint_check_always); // used for oop_map_cache allocation. def(MetaspaceExpand_lock , PaddedMutex , leaf-1, true, Monitor::_safepoint_check_never); - def(ClassLoaderDataGraph_lock , PaddedMutex , nonleaf, true, Monitor::_safepoint_check_always); + def(ClassLoaderDataGraph_lock , PaddedMutex , nonleaf, false, Monitor::_safepoint_check_always); def(Patching_lock , PaddedMutex , special, true, Monitor::_safepoint_check_never); // used for safepointing and code patching. def(CompiledMethod_lock , PaddedMutex , special-1, true, Monitor::_safepoint_check_never); @@ -240,7 +240,7 @@ def(SystemDictionary_lock , PaddedMonitor, leaf, true, Monitor::_safepoint_check_always); def(ProtectionDomainSet_lock , PaddedMutex , leaf-1, true, Monitor::_safepoint_check_never); def(SharedDictionary_lock , PaddedMutex , leaf, true, Monitor::_safepoint_check_always); - def(Module_lock , PaddedMutex , leaf+2, true, Monitor::_safepoint_check_always); + def(Module_lock , PaddedMutex , leaf+2, false, Monitor::_safepoint_check_always); def(InlineCacheBuffer_lock , PaddedMutex , leaf, true, Monitor::_safepoint_check_never); def(VMStatistic_lock , PaddedMutex , leaf, false, Monitor::_safepoint_check_always); def(ExpandHeap_lock , PaddedMutex , leaf, true, Monitor::_safepoint_check_always); // Used during compilation by VM thread @@ -291,7 +291,7 @@ def(MethodData_lock , PaddedMutex , nonleaf+3, false, Monitor::_safepoint_check_always); def(TouchedMethodLog_lock , PaddedMutex , nonleaf+3, false, Monitor::_safepoint_check_always); - def(MethodCompileQueue_lock , PaddedMonitor, nonleaf+4, true, Monitor::_safepoint_check_always); + def(MethodCompileQueue_lock , PaddedMonitor, nonleaf+4, false, Monitor::_safepoint_check_always); def(Debug2_lock , PaddedMutex , nonleaf+4, true, Monitor::_safepoint_check_never); def(Debug3_lock , PaddedMutex , nonleaf+4, true, Monitor::_safepoint_check_never); def(CompileThread_lock , PaddedMonitor, nonleaf+5, false, Monitor::_safepoint_check_always); @@ -316,7 +316,7 @@ def(CodeHeapStateAnalytics_lock , PaddedMutex , leaf, true, Monitor::_safepoint_check_never); def(NMethodSweeperStats_lock , PaddedMutex , special, true, Monitor::_safepoint_check_never); - def(ThreadsSMRDelete_lock , PaddedMonitor, special, false, Monitor::_safepoint_check_never); + def(ThreadsSMRDelete_lock , PaddedMonitor, special, true, Monitor::_safepoint_check_never); def(SharedDecoder_lock , PaddedMutex , native, false, Monitor::_safepoint_check_never); def(DCmdFactory_lock , PaddedMutex , leaf, true, Monitor::_safepoint_check_never); #if INCLUDE_NMT
--- a/src/hotspot/share/runtime/mutexLocker.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/runtime/mutexLocker.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -149,6 +149,8 @@ extern Monitor* JVMCI_lock; // Monitor to control initialization of JVMCI #endif +extern Mutex* tty_lock; // lock to synchronize output. + // A MutexLocker provides mutual exclusion with respect to a given mutex // for the scope which contains the locker. The lock is an OS lock, not // an object lock, and the two do not interoperate. Do not use Mutex-based
--- a/src/hotspot/share/runtime/os.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/runtime/os.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -1224,9 +1224,6 @@ } char* formatted_path = NEW_C_HEAP_ARRAY(char, formatted_path_len + 1, mtInternal); - if (formatted_path == NULL) { - return NULL; - } // Create boot classpath from format, substituting separator chars and // java home directory. @@ -1330,9 +1327,6 @@ } const char psepchar = *os::path_separator(); char* inpath = NEW_C_HEAP_ARRAY(char, strlen(path) + 1, mtInternal); - if (inpath == NULL) { - return NULL; - } strcpy(inpath, path); size_t count = 1; char* p = strchr(inpath, psepchar); @@ -1357,13 +1351,7 @@ "sun.boot.library.path, to identify potential sources for this path."); } // allocate the string and add terminator storage - char* s = NEW_C_HEAP_ARRAY_RETURN_NULL(char, len + 1, mtInternal); - - if (s == NULL) { - // release allocated storage before returning null - free_array_of_char_arrays(opath, i++); - return NULL; - } + char* s = NEW_C_HEAP_ARRAY(char, len + 1, mtInternal); strncpy(s, p, len); s[len] = '\0'; opath[i] = s;
--- a/src/hotspot/share/runtime/reflection.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/runtime/reflection.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -92,7 +92,7 @@ if (type == T_VOID) { return NULL; } - if (type == T_OBJECT || type == T_ARRAY) { + if (is_reference_type(type)) { // regular objects are not boxed return (oop) value->l; } @@ -756,7 +756,7 @@ TRAPS) { - if (T_OBJECT == ss->type() || T_ARRAY == ss->type()) { + if (is_reference_type(ss->type())) { Symbol* name = ss->as_symbol(); oop loader = method->method_holder()->class_loader(); oop protection_domain = method->method_holder()->protection_domain();
--- a/src/hotspot/share/runtime/synchronizer.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/runtime/synchronizer.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -419,7 +419,7 @@ ObjectLocker::ObjectLocker(Handle obj, Thread* thread, bool do_lock) { _dolock = do_lock; _thread = thread; - _thread->check_for_valid_safepoint_state(false); + _thread->check_for_valid_safepoint_state(); _obj = obj; if (_dolock) {
--- a/src/hotspot/share/runtime/thread.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/runtime/thread.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -973,6 +973,7 @@ if (!is_Java_thread()) return; if (_no_safepoint_count > 0) { + print_owned_locks(); fatal("Possible safepoint reached by thread that does not allow it"); } #ifdef CHECK_UNHANDLED_OOPS @@ -981,37 +982,18 @@ #endif // CHECK_UNHANDLED_OOPS } -// The flag: potential_vm_operation notifies if this particular safepoint state could potentially -// invoke the vm-thread (e.g., an oop allocation). In that case, we also have to make sure that -// no locks which allow_vm_block's are held -void Thread::check_for_valid_safepoint_state(bool potential_vm_operation) { +void Thread::check_for_valid_safepoint_state() { if (!is_Java_thread()) return; + // Check NoSafepointVerifier, which is implied by locks taken that can be + // shared with the VM thread. This makes sure that no locks with allow_vm_block + // are held. check_possible_safepoint(); if (((JavaThread*)this)->thread_state() != _thread_in_vm) { fatal("LEAF method calling lock?"); } - if (potential_vm_operation && !Universe::is_bootstrapping()) { - // Make sure we do not hold any locks that the VM thread also uses. - // This could potentially lead to deadlocks - for (Mutex* cur = _owned_locks; cur; cur = cur->next()) { - // Threads_lock is special, since the safepoint synchronization will not start before this is - // acquired. Hence, a JavaThread cannot be holding it at a safepoint. So is VMOperationRequest_lock, - // since it is used to transfer control between JavaThreads and the VMThread - // Do not *exclude* any locks unless you are absolutely sure it is correct. Ask someone else first! - if ((cur->allow_vm_block() && - cur != Threads_lock && - cur != Compile_lock && // Temporary: should not be necessary when we get separate compilation - cur != VMOperationRequest_lock && - cur != VMOperationQueue_lock) || - cur->rank() == Mutex::special) { - fatal("Thread holding lock at safepoint that vm can block on: %s", cur->name()); - } - } - } - if (GCALotAtAllSafepoints) { // We could enter a safepoint here and thus have a gc InterfaceSupport::check_gc_alot(); @@ -1553,9 +1535,6 @@ // Attempt to enlarge the array for per thread counters. jlong* resize_counters_array(jlong* old_counters, int current_size, int new_size) { jlong* new_counters = NEW_C_HEAP_ARRAY(jlong, new_size, mtJVMCI); - if (new_counters == NULL) { - return NULL; - } if (old_counters == NULL) { old_counters = new_counters; memset(old_counters, 0, sizeof(jlong) * new_size); @@ -1572,54 +1551,34 @@ } // Attempt to enlarge the array for per thread counters. -bool JavaThread::resize_counters(int current_size, int new_size) { - jlong* new_counters = resize_counters_array(_jvmci_counters, current_size, new_size); - if (new_counters == NULL) { - return false; - } else { - _jvmci_counters = new_counters; - return true; - } +void JavaThread::resize_counters(int current_size, int new_size) { + _jvmci_counters = resize_counters_array(_jvmci_counters, current_size, new_size); } class VM_JVMCIResizeCounters : public VM_Operation { private: int _new_size; - bool _failed; public: - VM_JVMCIResizeCounters(int new_size) : _new_size(new_size), _failed(false) { } + VM_JVMCIResizeCounters(int new_size) : _new_size(new_size) { } VMOp_Type type() const { return VMOp_JVMCIResizeCounters; } bool allow_nested_vm_operations() const { return true; } void doit() { // Resize the old thread counters array jlong* new_counters = resize_counters_array(JavaThread::_jvmci_old_thread_counters, JVMCICounterSize, _new_size); - if (new_counters == NULL) { - _failed = true; - return; - } else { - JavaThread::_jvmci_old_thread_counters = new_counters; - } + JavaThread::_jvmci_old_thread_counters = new_counters; // Now resize each threads array for (JavaThreadIteratorWithHandle jtiwh; JavaThread *tp = jtiwh.next(); ) { - if (!tp->resize_counters(JVMCICounterSize, _new_size)) { - _failed = true; - break; - } + tp->resize_counters(JVMCICounterSize, _new_size); } - if (!_failed) { - JVMCICounterSize = _new_size; - } - } - - bool failed() { return _failed; } + JVMCICounterSize = _new_size; + } }; -bool JavaThread::resize_all_jvmci_counters(int new_size) { +void JavaThread::resize_all_jvmci_counters(int new_size) { VM_JVMCIResizeCounters op(new_size); VMThread::execute(&op); - return !op.failed(); } #endif // INCLUDE_JVMCI @@ -1803,7 +1762,10 @@ void JavaThread::block_if_vm_exited() { if (_terminated == _vm_exited) { // _vm_exited is set at safepoint, and Threads_lock is never released - // we will block here forever + // we will block here forever. + // Here we can be doing a jump from a safe state to an unsafe state without + // proper transition, but it happens after the final safepoint has begun. + set_thread_state(_thread_in_vm); Threads_lock->lock(); ShouldNotReachHere(); }
--- a/src/hotspot/share/runtime/thread.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/runtime/thread.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -753,7 +753,7 @@ // These functions check conditions on a JavaThread before possibly going to a safepoint, // including NoSafepointVerifier. - void check_for_valid_safepoint_state(bool potential_vm_operation) NOT_DEBUG_RETURN; + void check_for_valid_safepoint_state() NOT_DEBUG_RETURN; void check_possible_safepoint() NOT_DEBUG_RETURN; private: @@ -1143,10 +1143,8 @@ public: static jlong* _jvmci_old_thread_counters; static void collect_counters(jlong* array, int length); - - bool resize_counters(int current_size, int new_size); - - static bool resize_all_jvmci_counters(int new_size); + void resize_counters(int current_size, int new_size); + static void resize_all_jvmci_counters(int new_size); private: #endif // INCLUDE_JVMCI
--- a/src/hotspot/share/runtime/vmThread.cpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/runtime/vmThread.cpp Wed Sep 25 13:40:36 2019 +0530 @@ -669,7 +669,7 @@ bool concurrent = op->evaluate_concurrently(); // only blocking VM operations need to verify the caller's safepoint state: if (!concurrent) { - t->check_for_valid_safepoint_state(true); + t->check_for_valid_safepoint_state(); } // New request from Java thread, evaluate prologue
--- a/src/hotspot/share/utilities/concurrentHashTable.inline.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/utilities/concurrentHashTable.inline.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -999,8 +999,8 @@ { _stats_rate = TableRateStatistics(); _resize_lock = - new Mutex(Mutex::leaf, "ConcurrentHashTable", false, - Monitor::_safepoint_check_never); + new Mutex(Mutex::leaf, "ConcurrentHashTable", true, + Mutex::_safepoint_check_never); _table = new InternalTable(log2size); assert(log2size_limit >= log2size, "bad ergo"); _size_limit_reached = _table->_log2_size == _log2_size_limit;
--- a/src/hotspot/share/utilities/events.hpp Mon Sep 23 17:18:03 2019 +0100 +++ b/src/hotspot/share/utilities/events.hpp Wed Sep 25 13:40:36 2019 +0530 @@ -100,7 +100,7 @@ public: EventLogBase<T>(const char* name, const char* handle, int length = LogEventsBufferEntries): - _mutex(Mutex::event, name, false, Monitor::_safepoint_check_never), + _mutex(Mutex::event, name, true, Mutex::_safepoint_check_never), _name(name), _handle(handle), _length(length),
--- a/src/java.base/macosx/classes/sun/nio/ch/KQueueSelectorProvider.java Mon Sep 23 17:18:03 2019 +0100 +++ b/src/java.base/macosx/classes/sun/nio/ch/KQueueSelectorProvider.java Wed Sep 25 13:40:36 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2011, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2011, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -27,6 +27,7 @@ import java.io.IOException; import java.nio.channels.spi.AbstractSelector; +import java.nio.channels.*; public class KQueueSelectorProvider extends SelectorProviderImpl @@ -34,4 +35,8 @@ public AbstractSelector openSelector() throws IOException { return new KQueueSelectorImpl(this); } + + public Channel inheritedChannel() throws IOException { + return InheritedChannel.getChannel(); + } }
--- a/src/java.base/macosx/native/libjli/java_md_macosx.m Mon Sep 23 17:18:03 2019 +0100 +++ b/src/java.base/macosx/native/libjli/java_md_macosx.m Wed Sep 25 13:40:36 2019 +0530 @@ -757,10 +757,6 @@ return rslt; } -void SetJavaLauncherPlatformProps() { - /* Linux only */ -} - static JavaVM* jvmInstance = NULL; static jboolean sameThread = JNI_FALSE; /* start VM in current thread */
--- a/src/java.base/share/classes/java/io/BufferedInputStream.java Mon Sep 23 17:18:03 2019 +0100 +++ b/src/java.base/share/classes/java/io/BufferedInputStream.java Wed Sep 25 13:40:36 2019 +0530 @@ -29,20 +29,20 @@ import jdk.internal.util.ArraysSupport; /** - * A <code>BufferedInputStream</code> adds + * A {@code BufferedInputStream} adds * functionality to another input stream-namely, * the ability to buffer the input and to - * support the <code>mark</code> and <code>reset</code> - * methods. When the <code>BufferedInputStream</code> + * support the {@code mark} and {@code reset} + * methods. When the {@code BufferedInputStream} * is created, an internal buffer array is * created. As bytes from the stream are read * or skipped, the internal buffer is refilled * as necessary from the contained input stream, - * many bytes at a time. The <code>mark</code> + * many bytes at a time. The {@code mark} * operation remembers a point in the input - * stream and the <code>reset</code> operation + * stream and the {@code reset} operation * causes all the bytes read since the most - * recent <code>mark</code> operation to be + * recent {@code mark} operation to be * reread before new bytes are taken from * the contained input stream. * @@ -81,23 +81,23 @@ * The index one greater than the index of the last valid byte in * the buffer. * This value is always - * in the range <code>0</code> through <code>buf.length</code>; - * elements <code>buf[0]</code> through <code>buf[count-1] - * </code>contain buffered input data obtained + * in the range {@code 0} through {@code buf.length}; + * elements {@code buf[0]} through {@code buf[count-1]} + * contain buffered input data obtained * from the underlying input stream. */ protected int count; /** * The current position in the buffer. This is the index of the next - * character to be read from the <code>buf</code> array. + * character to be read from the {@code buf} array. * <p> - * This value is always in the range <code>0</code> - * through <code>count</code>. If it is less - * than <code>count</code>, then <code>buf[pos]</code> + * This value is always in the range {@code 0} + * through {@code count}. If it is less + * than {@code count}, then {@code buf[pos]} * is the next byte to be supplied as input; - * if it is equal to <code>count</code>, then - * the next <code>read</code> or <code>skip</code> + * if it is equal to {@code count}, then + * the next {@code read} or {@code skip} * operation will require more bytes to be * read from the contained input stream. * @@ -106,28 +106,28 @@ protected int pos; /** - * The value of the <code>pos</code> field at the time the last - * <code>mark</code> method was called. + * The value of the {@code pos} field at the time the last + * {@code mark} method was called. * <p> * This value is always - * in the range <code>-1</code> through <code>pos</code>. + * in the range {@code -1} through {@code pos}. * If there is no marked position in the input - * stream, this field is <code>-1</code>. If + * stream, this field is {@code -1}. If * there is a marked position in the input - * stream, then <code>buf[markpos]</code> + * stream, then {@code buf[markpos]} * is the first byte to be supplied as input - * after a <code>reset</code> operation. If - * <code>markpos</code> is not <code>-1</code>, - * then all bytes from positions <code>buf[markpos]</code> - * through <code>buf[pos-1]</code> must remain + * after a {@code reset} operation. If + * {@code markpos} is not {@code -1}, + * then all bytes from positions {@code buf[markpos]} + * through {@code buf[pos-1]} must remain * in the buffer array (though they may be * moved to another place in the buffer array, * with suitable adjustments to the values - * of <code>count</code>, <code>pos</code>, - * and <code>markpos</code>); they may not + * of {@code count}, {@code pos}, + * and {@code markpos}); they may not * be discarded unless and until the difference - * between <code>pos</code> and <code>markpos</code> - * exceeds <code>marklimit</code>. + * between {@code pos} and {@code markpos} + * exceeds {@code marklimit}. * * @see java.io.BufferedInputStream#mark(int) * @see java.io.BufferedInputStream#pos @@ -136,12 +136,12 @@ /** * The maximum read ahead allowed after a call to the - * <code>mark</code> method before subsequent calls to the - * <code>reset</code> method fail. - * Whenever the difference between <code>pos</code> - * and <code>markpos</code> exceeds <code>marklimit</code>, + * {@code mark} method before subsequent calls to the + * {@code reset} method fail. + * Whenever the difference between {@code pos} + * and {@code markpos} exceeds {@code marklimit}, * then the mark may be dropped by setting - * <code>markpos</code> to <code>-1</code>. + * {@code markpos} to {@code -1}. * * @see java.io.BufferedInputStream#mark(int) * @see java.io.BufferedInputStream#reset() @@ -171,10 +171,10 @@ } /** - * Creates a <code>BufferedInputStream</code> + * Creates a {@code BufferedInputStream} * and saves its argument, the input stream - * <code>in</code>, for later use. An internal - * buffer array is created and stored in <code>buf</code>. + * {@code in}, for later use. An internal + * buffer array is created and stored in {@code buf}. * * @param in the underlying input stream. */ @@ -183,12 +183,12 @@ } /** - * Creates a <code>BufferedInputStream</code> + * Creates a {@code BufferedInputStream} * with the specified buffer size, * and saves its argument, the input stream - * <code>in</code>, for later use. An internal - * buffer array of length <code>size</code> - * is created and stored in <code>buf</code>. + * {@code in}, for later use. An internal + * buffer array of length {@code size} + * is created and stored in {@code buf}. * * @param in the underlying input stream. * @param size the buffer size. @@ -249,10 +249,10 @@ /** * See - * the general contract of the <code>read</code> - * method of <code>InputStream</code>. + * the general contract of the {@code read} + * method of {@code InputStream}. * - * @return the next byte of data, or <code>-1</code> if the end of the + * @return the next byte of data, or {@code -1} if the end of the * stream is reached. * @throws IOException if this input stream has been closed by * invoking its {@link #close()} method, @@ -300,21 +300,21 @@<